| Message ID | 20240226090600.31952-3-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/acpi: Include missing headers | expand |
On Mon, Feb 26, 2024 at 10:06:00AM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 26 Feb 2024 10:06:00 +0100 > From: Philippe Mathieu-Daudé <philmd@linaro.org> > Subject: [PATCH v2 2/2] hw/i386/q35: Include missing 'hw/acpi/acpi.h' header > X-Mailer: git-send-email 2.41.0 > > "hw/acpi/acpi.h" is implicitly included. Include it > explicitly to avoid the following error when refactoring > headers: > > hw/i386/pc_q35.c:209:43: error: use of undeclared identifier 'ACPI_PM_PROP_ACPI_PCIHP_BRIDGE' > ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, > ^ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/i386/pc_q35.c | 1 + > 1 file changed, 1 insertion(+) Thanks! Reviewed-by: Zhao Liu <zhao1.liu@intel.com> > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index e0b3f55a02..45a4102e75 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -30,6 +30,7 @@ > > #include "qemu/osdep.h" > #include "qemu/units.h" > +#include "hw/acpi/acpi.h" > #include "hw/char/parallel-isa.h" > #include "hw/loader.h" > #include "hw/i2c/smbus_eeprom.h" > -- > 2.41.0 >
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index e0b3f55a02..45a4102e75 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -30,6 +30,7 @@ #include "qemu/osdep.h" #include "qemu/units.h" +#include "hw/acpi/acpi.h" #include "hw/char/parallel-isa.h" #include "hw/loader.h" #include "hw/i2c/smbus_eeprom.h"
"hw/acpi/acpi.h" is implicitly included. Include it explicitly to avoid the following error when refactoring headers: hw/i386/pc_q35.c:209:43: error: use of undeclared identifier 'ACPI_PM_PROP_ACPI_PCIHP_BRIDGE' ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/i386/pc_q35.c | 1 + 1 file changed, 1 insertion(+)