From patchwork Wed Feb 21 08:19:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 774495 Delivered-To: patch@linaro.org Received: by 2002:a5d:6ac2:0:b0:33b:4db1:f5b3 with SMTP id u2csp145303wrw; Wed, 21 Feb 2024 00:21:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVLbSC4NxAI8qf22j/s5NgwSXWa8+g+UT8wkGWBo4TJT5HYu2fSx1xcNsLTuImaai7b/k1tu+PQh0EfbWbwOmzG X-Google-Smtp-Source: AGHT+IGP/z4a6OS1L9HXqCnhQDZhJFVNuYf8Mr7F3DfDaGTeSwcTp7ViZOmRnyGBNnBEqXN5OZFB X-Received: by 2002:a0c:f2d0:0:b0:68f:555c:e331 with SMTP id c16-20020a0cf2d0000000b0068f555ce331mr9602216qvm.28.1708503715623; Wed, 21 Feb 2024 00:21:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708503715; cv=none; d=google.com; s=arc-20160816; b=coKDbmTKvB86rWpcvS/4rLpLilec6/Qhgr6+FUd1kZogF8XOdxByXNcLsVv4thjapj PpjY1fZahaSljFPC/3h5+R85/lOrD6mSQykOSlLF5mGQRdRAb1Jb7YNNx+iuSfBl00xu scM3s067BRE52DoNxsnycvTfnXQ8NN6/rlriWRi1Zr3SbD3F7a2BZ3FPzI2ocS5ZLEyi h0UBShUEY+P89wOpW5M0W0eV0MrXCbkfka85I6QWiIaOGI5QaLCq+nncD7MHyOouR2MK JWpJAaJSjzbzEvZDhkqiOLaPozm7ympMXJuheHnYExGrTQAGF71fw++Op7hEJczlygiE hToA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=kCQLqbpS3N8LvGiIMnyMwnx+tmnKw3/yxd3KumEv61M=; fh=xJ1URYKcMN3TM0/XAv5v+aCN+5tIbzAdcfBx5UNgoLw=; b=W4htNhTv3BUyyITXKgWSPnS562movTo+7TL0sAr3z9ecA8pdGB0FativBoMwDx+7k/ QMjTTj0IcRU6d9I4PPn9qSXI9zZGIEDFkvlQdMn4JZ86iBm+RY5PvRoYSPzcImSmkhit PziMZy8jEqeMYxD3cvo8ZCCsU3zPv45eWbyb8+umDO0NJSZgt8pwfWNBU0IqQ9CTd8N2 EqNNkloyLMi37XPOINZenqg4ncEEWTQCBxkSJz3EaRlSwLD29auq4HQYXIfXDmhOQyu3 lx94V6rJB7efE5+BD/S8gKlDpLJAHED6DAqnpiVaEz3LLDF1n5fAHNNZqHUjJ2GlWpGr 8GNg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 10-20020a05621420ca00b0068cd864e437si10472207qve.325.2024.02.21.00.21.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Feb 2024 00:21:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rchrO-0001ZN-He; Wed, 21 Feb 2024 03:21:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rchrJ-0001To-As; Wed, 21 Feb 2024 03:21:41 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rchrH-0002BN-K0; Wed, 21 Feb 2024 03:21:41 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 864B74F3C8; Wed, 21 Feb 2024 11:21:20 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 51C58860A7; Wed, 21 Feb 2024 11:20:59 +0300 (MSK) Received: (nullmailer pid 2142016 invoked by uid 1000); Wed, 21 Feb 2024 08:20:58 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , Richard Henderson , Michael Tokarev Subject: [Stable-8.2.2 10/60] target/arm: Reinstate "vfp" property on AArch32 CPUs Date: Wed, 21 Feb 2024 11:19:58 +0300 Message-Id: <20240221082058.2141850-10-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell In commit 4315f7c614743 we restructured the logic for creating the VFP related properties to avoid testing the aa32_simd_r32 feature on AArch64 CPUs. However in the process we accidentally stopped exposing the "vfp" QOM property on AArch32 TCG CPUs. This mostly hasn't had any ill effects because not many people want to disable VFP, but it wasn't intentional. Reinstate the property. Cc: qemu-stable@nongnu.org Fixes: 4315f7c614743 ("target/arm: Restructure has_vfp_d32 test") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2098 Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20240126193432.2210558-1-peter.maydell@linaro.org (cherry picked from commit 185e3fdf8d106cb2f7d234d5e6453939c66db2a9) Signed-off-by: Michael Tokarev diff --git a/target/arm/cpu.c b/target/arm/cpu.c index efb22a87f9..5d9bca5b8d 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1615,6 +1615,10 @@ void arm_cpu_post_init(Object *obj) } } else if (cpu_isar_feature(aa32_vfp, cpu)) { cpu->has_vfp = true; + if (tcg_enabled() || qtest_enabled()) { + qdev_property_add_static(DEVICE(obj), + &arm_cpu_has_vfp_property); + } if (cpu_isar_feature(aa32_simd_r32, cpu)) { cpu->has_vfp_d32 = true; /*