From patchwork Sun Feb 4 21:40:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 769858 Delivered-To: patch@linaro.org Received: by 2002:adf:9bca:0:b0:33a:e5bd:fedd with SMTP id e10csp1842275wrc; Sun, 4 Feb 2024 13:43:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyvBsZiNrJTK/Rtp2PeMHvz7bd4wB74jkEbYHW7cxdgj+pCtAufNQvKz7TncWf69csxccL X-Received: by 2002:a05:620a:1226:b0:784:8c3:3503 with SMTP id v6-20020a05620a122600b0078408c33503mr9002062qkj.30.1707082988970; Sun, 04 Feb 2024 13:43:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707082988; cv=none; d=google.com; s=arc-20160816; b=Gwu+K/JDLfabryaPg/GT1Q9pDp4fYXdiqzv23CxaaWWjz3uahXi5aC4cVXjzLKV0n6 K4aJ1sYmt1AOfCh1QYZgqdhzbNFgbjjhsQ9FjyEYafxhW6a04bjZGzO1EBHlrcGY1hHs PyUIIt/C6xunCyFju3jInnMAtUxo3mmCdlc1in+Ey2lErHghIMBR0o8qRs6AuCPf6Vd/ IfTWNwihfUuf93jIsSRA4/2M7rxD3jKZErIcZiWIs1BkHCXmoFGgpsXsaS4RS3d4r2l3 hfCtITelm2xCpvOjAbOc88UH2v+01sSqdRvOK9Orrz+Ev2HkA5krCKll3CRCQ2qVdaiu HacQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cadphwjaQtxJbfsAaQ8Tf54zJ/KIUtYE/z1XZRnv4ls=; fh=HzRDhqFXUvBnCUufIWd9t17y4Q2CamcYNfihKwTPeU4=; b=yvSm4Mo2Hg0ydw4XtpzeHOiKZFJ+WRBWlmm41DhDN91MpMnp3RVkamJA08IYCGf5Qw lisXMoyd4us+XsWPfqVtqq1+2h89DdwOQ3RpPmtriXfCVVeGlNHy04ceZ6duYFhhGE29 L9ap3JH7HvgcMTU35Y7FhA7UkWXZEvvX7xbTi6uSPbn5Mjxjx0WENqHfrDvTJXJ+d4ga lBFNpJavi2iAR54xfJDSatauJ6fuclVv4JlPsemzPvZW8317t4O8a613V1O+jjRMtiS5 C4gE7uJ1Q7WnzR+9BZzotzmnkXKQYq5pO1sWgOptvryJE08yuqFIHY6ciEwR7MrncPC9 UHIA==; darn=linaro.org ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ku22g3nG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=0; AJvYcCUla0mAv2e6Oqi02ZnGLsCxtWVdkzKm5B9lkTDMuAabgZkq8S4E21qHl4mOQKFPMFNhnWNixzml1+ILAAWa82D7 Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 17-20020a05620a04d100b007857ad9bd10si1753775qks.315.2024.02.04.13.43.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Feb 2024 13:43:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ku22g3nG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWkF0-00027W-E1; Sun, 04 Feb 2024 16:41:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWkEy-00027M-Jt for qemu-devel@nongnu.org; Sun, 04 Feb 2024 16:41:28 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rWkEw-0003Wx-T4 for qemu-devel@nongnu.org; Sun, 04 Feb 2024 16:41:28 -0500 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d7881b1843so33273865ad.3 for ; Sun, 04 Feb 2024 13:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707082885; x=1707687685; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cadphwjaQtxJbfsAaQ8Tf54zJ/KIUtYE/z1XZRnv4ls=; b=ku22g3nGIuWxxSCPbBcJd3oPlrdueh62068hPqewhZklqkBz2mPJbmvHFeuMmIytOb 4jGvXhrIaQungek92sEULLt94mGB/V5tmbp2bP4VkIyUgCyukuT9BxeUeOLAaqFUnLfm e5udlxLwS+pUrP9qGqplr/tQdTOEN0ztvXejetLCDobFnCQExV90YHKSag5CGXj8RKtN O3ZLop0KJbGxMZEAIUZB6xBT8qkQkFY2zovNlMcrQv1ZijCbWEIlNsYi3xHcS0f2ZnlN 04xtOIli9vLxpj1nzVmXE2x4i25aw/+qK5eJS1KO/ifgukFym/Hd7L6EG8ktczkSxBk2 0wYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707082885; x=1707687685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cadphwjaQtxJbfsAaQ8Tf54zJ/KIUtYE/z1XZRnv4ls=; b=LV1kPRqyaOyUXYaQvYjGG66LXUDJcipBy2gqYe5bBnALyyth/sRGCzZUJ+EMa6Zgdt pX54+wFYnamhZdluixORgcTNBK+QAOlzAPd7XEBrGk7qyDApS90oj4phZ5npfJFMowCR nOaH0G1NUZYbuArzpxe54cRZwUF6+MOw3sZO/OCvFK5NZeCSywk1pMWTHzblFRHjlJVK NiJQSwwzVr5382MJ4nUguYQxjsjE0pCWODltzBmMpUAPWkEJhVsF6tdxwP+dpalr6A07 qXv2enLpCy273OOn8NZQ8VIsE63MoolYzmItJcR7q7m8zQsjj8z+WxQ8/43tbL6xRMKW YK+w== X-Gm-Message-State: AOJu0Yyjc0esvimY77p7njT9CdF+Qsvce0PTVospSB0MZ6zLENyipD7C ydiuJHT+ZbyeUiKYEcBdZu+DEpPdV9STxaXTPmKJTKU5dShoaQcxF040Me/SH13p67r5Lbv+99i 01YU= X-Received: by 2002:a17:902:d34d:b0:1d9:5ed4:ec07 with SMTP id l13-20020a170902d34d00b001d95ed4ec07mr9583863plk.52.1707082885716; Sun, 04 Feb 2024 13:41:25 -0800 (PST) Received: from stoup.. ([43.252.112.156]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d8f5560503sm4953670plb.222.2024.02.04.13.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 13:41:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 14/39] target/s390x: Use TCG_COND_TSTNE for CC_OP_{TM,ICM} Date: Mon, 5 Feb 2024 07:40:27 +1000 Message-Id: <20240204214052.5639-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240204214052.5639-1-richard.henderson@linaro.org> References: <20240204214052.5639-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org These are all test-and-compare type instructions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index a5fd9cccaa..05fd29589c 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -754,10 +754,10 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) case CC_OP_TM_64: switch (mask) { case 8: - cond = TCG_COND_EQ; + cond = TCG_COND_TSTEQ; break; case 4 | 2 | 1: - cond = TCG_COND_NE; + cond = TCG_COND_TSTNE; break; default: goto do_dynamic; @@ -768,11 +768,11 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) case CC_OP_ICM: switch (mask) { case 8: - cond = TCG_COND_EQ; + cond = TCG_COND_TSTEQ; break; case 4 | 2 | 1: case 4 | 2: - cond = TCG_COND_NE; + cond = TCG_COND_TSTNE; break; default: goto do_dynamic; @@ -854,18 +854,14 @@ static void disas_jcc(DisasContext *s, DisasCompare *c, uint32_t mask) c->u.s64.a = cc_dst; c->u.s64.b = tcg_constant_i64(0); break; + case CC_OP_LTGT_64: case CC_OP_LTUGTU_64: - c->u.s64.a = cc_src; - c->u.s64.b = cc_dst; - break; - case CC_OP_TM_32: case CC_OP_TM_64: case CC_OP_ICM: - c->u.s64.a = tcg_temp_new_i64(); - c->u.s64.b = tcg_constant_i64(0); - tcg_gen_and_i64(c->u.s64.a, cc_src, cc_dst); + c->u.s64.a = cc_src; + c->u.s64.b = cc_dst; break; case CC_OP_ADDU: