From patchwork Fri Jan 19 11:34:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 763908 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a08:0:b0:337:62d3:c6d5 with SMTP id m8csp397239wrq; Fri, 19 Jan 2024 03:36:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/d8vM4YSwQ9osy+H44ezfJIG/3n9eKpKM+jiKi8AzlNqR8GkHH6Vbk3JMFCXBQF9MB5UM X-Received: by 2002:a0c:f144:0:b0:682:24b1:1ea6 with SMTP id y4-20020a0cf144000000b0068224b11ea6mr847942qvl.1.1705664201763; Fri, 19 Jan 2024 03:36:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705664201; cv=none; d=google.com; s=arc-20160816; b=op2GkmhcsveY1yYTtR5W4diGNnVhGuSKWwm5t7/zYh9XWAEa5tLz94FcLMWoLyiTSd bK5snMXkWV9/TrKOhIp8AZV3g3/h6+1Qo0v1jBFTvhpyJqJO9RFn6FRCCIY5nCBnjO2D xS/OoSuDHr3DCmmpHXYD2OzftoPqQTQOyXvNh90xI07r8sysiN5YxytPTeFZeObYlrve O6NvG86IXFHtjVzkEVXyxqvNdMYolDsbK+YXW0GQo+dxy13ZrEulzPSSOy1K/n4AXjIr ElgZDBvmTReGsg/ZwXbUttF5M3fU4Ag4Z+G2FN5m55WaGFdZnmJ1KyWKcOSHMQjSGL6R 1/dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4V5MwJ3yzBvCl1jR3LZsLDTSMljFxa13ddLlRCJyMuc=; fh=ljlq2IERA83R/N9I+W7btu6jk8dnbNWtb9KZN1Aqt3M=; b=aVGLj1T0hN8SLi1K7chY8aizX26W6/W8ntt6ebTvfu7CLrSiKMBd6HVirLAXHstu/K kfrp1DtRLoxwvnuSgV7v6BBOTD84ZA/3qzH0NDXheDHyqSYqR+rmGaS72bNmjNQgriIF VFq/ni+CVVy09u4pY3teozjWbLa/4LeH7bUi8lAfQuEWZfCrQr1vCn+UsJ39RvCGYgXq POiYgFjZ/ciFeexedWQR2MnqCbBfi/QSXZNQ1d0rprvjQ7LOrOGWy1obqSOq0rCXxg0m oX5U9hlLLdCTat/XScpyCGGEmrvinclCvSBRMbcqtvp7Moxa9Qq/TnfCgeaXyLPz1hyd KaPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yjueg+Bs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i19-20020a0cf113000000b006818c72d321si3561960qvl.56.2024.01.19.03.36.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Jan 2024 03:36:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yjueg+Bs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQnAg-00038P-UT; Fri, 19 Jan 2024 06:36:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQnAe-00030F-O5 for qemu-devel@nongnu.org; Fri, 19 Jan 2024 06:36:24 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQnAc-0002O2-AT for qemu-devel@nongnu.org; Fri, 19 Jan 2024 06:36:24 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40ea084ec14so1271045e9.2 for ; Fri, 19 Jan 2024 03:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705664181; x=1706268981; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4V5MwJ3yzBvCl1jR3LZsLDTSMljFxa13ddLlRCJyMuc=; b=Yjueg+BsESEHq9lwdZMlj9v/mN0HCf7eMYlMOQLpLYbgvcVKiNW1Sy6NVRBUw33doa WiO3dlMZtU/SxsigLh4Ik7Yl91tqU4gMORI2UCjhQvD5Ljkwzo5AGs2WpwEl9QyT0VsO J3jmC4vardD9+EDk58bRG1JOn6VBL+tDpx9wfRW8NZRpjvMsy2M2HaTnGt0/VfBe3b8b VrYdnDrEPmPrRyJYSBPeYC4Ed3ldnT2eDO9efu0cw4ZaPuNKLmB1sRjKynUzEPkTLrhd e0er/XjafnznvGibE7vmn5yQlzni3N1IaTaTdPKW4k62wx/1IT9V3KIWpcwvVg3n8jFY thXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705664181; x=1706268981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4V5MwJ3yzBvCl1jR3LZsLDTSMljFxa13ddLlRCJyMuc=; b=bSd+Uuo1qLbBr7jif/87XgoQPx/Hvcjr9+Xmcgon3l8qm4LFVV/mvMpmgymwtBu0e6 yDqxe904NQ5HUnvOJDFmZ8RR0nNp871EdCh9eWT/7hQLYq+78gQuqZrhOs6PAAliPrh6 E7Qi/MWtJ2T20TxmnS8ayp/4aC6sEgxW5hDsVhvWG6Zusc2Y1djbucQA6HyrJGIuqDzB Dl9vNa+VIM1PcDl1Uz4Bl533BlUkfjKjPKwvRZzLDOir4NuhWYM7hlw+pD7Ejvj0+qD7 GuxESyHfC6C6cggxC8cgj670oRNQ4cWRrkFACFtlZhBRYR1P4rwOe9CDTcgTTqBR9cZM o67w== X-Gm-Message-State: AOJu0YxfWxg2mxzMd8jQfiPjgmHTArmx4zs1IUWlVwWvo5PPLfEpcej8 1tYZO/u7FwB/oustC6uexkmCvd4tvz9+VGKxh/FPfmNr9YnsZQ5FsgB5vfXfWqdcep63H4Lswy/ 4pYu2SA== X-Received: by 2002:a05:600c:1990:b0:40e:50ac:d24e with SMTP id t16-20020a05600c199000b0040e50acd24emr1781197wmq.13.1705664180890; Fri, 19 Jan 2024 03:36:20 -0800 (PST) Received: from localhost.localdomain (91-163-26-170.subs.proxad.net. [91.163.26.170]) by smtp.gmail.com with ESMTPSA id fm16-20020a05600c0c1000b0040ea10178f3sm237439wmb.21.2024.01.19.03.36.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 19 Jan 2024 03:36:20 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, Samuel Tardieu , =?utf-8?q?C=C3=A9dri?= =?utf-8?q?c_Le_Goater?= , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , devel@lists.libvirt.org, Yoshinori Sato , Magnus Damm , Kevin Wolf , Hanna Reitz Subject: [PULL 16/36] hw/block: Deprecate the TC58128 block device Date: Fri, 19 Jan 2024 12:34:45 +0100 Message-ID: <20240119113507.31951-17-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240119113507.31951-1-philmd@linaro.org> References: <20240119113507.31951-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Samuel Tardieu The 16MiB flash device is only used by the deprecated shix machine. Its code it old and unmaintained, and has never been adapted to the QOM architecture. It still contains debug statements and uses global variables. It is time to deprecate it. Signed-off-by: Samuel Tardieu Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240109083053.2581588-3-sam@rfc1149.net> Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 2 +- hw/block/tc58128.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index e6a12c9077..15e39f8bbb 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -273,7 +273,7 @@ The Nios II architecture is orphan. '''''''''''''''''''' The machine is no longer in existence and has been long unmaintained -in QEMU. +in QEMU. This also holds for the TC51828 16MiB flash that it uses. Backend options --------------- diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index d350126b27..6944cf58fa 100644 --- a/hw/block/tc58128.c +++ b/hw/block/tc58128.c @@ -202,6 +202,7 @@ static sh7750_io_device tc58128 = { int tc58128_init(struct SH7750State *s, const char *zone1, const char *zone2) { + warn_report_once("The TC58128 flash device is deprecated"); init_dev(&tc58128_devs[0], zone1); init_dev(&tc58128_devs[1], zone2); return sh7750_register_io_device(s, &tc58128);