From patchwork Thu Jan 18 15:34:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 763628 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e5d:0:b0:337:62d3:c6d5 with SMTP id j29csp846421wrz; Thu, 18 Jan 2024 07:35:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHt3r00jQQn51UtHubN0z0FIhajgkyKMgzGbyRdzr6tzxCOJAFMH2VV7DSbGg2LDZ/lkosR X-Received: by 2002:a05:622a:20a:b0:429:c855:8b14 with SMTP id b10-20020a05622a020a00b00429c8558b14mr1103687qtx.99.1705592125998; Thu, 18 Jan 2024 07:35:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705592125; cv=none; d=google.com; s=arc-20160816; b=cjX/HMcL/9Wm1bFrerPAM3ohTKRCNohirDt9akkrx9snOtBtkm9+MD7WtniFvuXEdT HRdX9vsNB5diT9pp/8VNGtY6uXCK8cXhfuEFDwzTcXysi40XuY2D15MQ+28lRebAeYn/ ntbTQ+exomgsiK6XWsgOZFh40uEYwXZi9R93Ue+lRbeNmp/Om87726zGTk/iPz/5u/3+ ISRhJuvDlq4SR2EQCjFuV3tQEQE0YLYRKOs3vya0cyUKlG3FB7/XV1z/fW1K0sKfhlwb xQaNu+uNXrecEVvxXKz7yroYC643CAUm2dO5rHSSX/nWRifjtG+yVJnF5lIHWGL1zKVS 3+tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=SwuaHqluR1Y5JxpZebqlgJ2NJ8ORccM92Gb37cL7c0k=; fh=ew9iRnqeCcD1jPw1pctsy+llSKxpJ6iZH0WP+MzC0ME=; b=Z+KGbKrA1VZogHB6ft8/Aw/6L71a6W+N6RlR1g+m/XvDJ4VOS+P4oGXmg6Ebflbzfp kGqY0w8b2NKnlcmBVWCatI4KMwaHAnICsCTz0BhOcf8wi26RrWaTB07Fuj/z0hdqausk +jgGRmtEUbefZ/TU7Lb+PRQMjsNMDVk8JYq44FIFvrMQORRkziahyY/FaE9QXRqcjJPB H8OhtYGQS+G5R0pSrPcZN+Lp4RhJMZuOhl+QSjLKUljJ/zqQLMFjfyJowKzybEcS8Ra+ o+Be54QH60/AuKAf8jGzcehPJXCDQLWY9PgV52b90h3yMuu2R7l+HueLXcb+FoFcxBn2 WFNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIVskwNe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w20-20020a05622a135400b0042996ed2560si14374310qtk.132.2024.01.18.07.35.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2024 07:35:25 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sIVskwNe; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQUPT-0007Td-43; Thu, 18 Jan 2024 10:34:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQUPL-0007SB-6a for qemu-devel@nongnu.org; Thu, 18 Jan 2024 10:34:20 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQUPI-0002R6-L1 for qemu-devel@nongnu.org; Thu, 18 Jan 2024 10:34:18 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-337cf4eabc9so593906f8f.3 for ; Thu, 18 Jan 2024 07:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705592054; x=1706196854; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SwuaHqluR1Y5JxpZebqlgJ2NJ8ORccM92Gb37cL7c0k=; b=sIVskwNecz/a6NnLOcFpfmWR0s6w6xr8eHaiVA8IeMF47oN0uY8WhZr9RWR1KHNB7s qaG0TxM49A3b26RuRdM/FFhKk9tlUpO4Acy/WAAU/k+u5qI/6NrMNbIo2NVpa320/Csc AbFN4B9NL1GQH4bCefN5+1nhfkEMhed5IhwzFPXWdfymRWRn4YTTpPHIHpX0ibh5EJh/ +w+etVUarjc8QWQpiXz/tiR05b8TdMRHuqR6UXmtXP1sPmDgv3CAHMKBZCaj1zbaWs9A XeQIFKkyJPcHlyj2YDBozt0aOg9X3oyJ4+yygOdhMun52rd1c2WNhiWq9ek/IPgl9TLY b/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705592054; x=1706196854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SwuaHqluR1Y5JxpZebqlgJ2NJ8ORccM92Gb37cL7c0k=; b=Nn4LubVOsIqVcLRxVMRur5ra9TO6wf0kyAIaK0j5wT0DlFVbVmbGPeAH2wJbPjai68 cSFwB+1TstUIFcc4+jBWx8Rkv4oPvJGgvnZsTWpgMx17n7VQFBgPXm0Beq732Qy1SBYJ SZZzSY/gTBSzS9fJG/vqupw2NdxJW42HWF4nKa0FxExcwoMeiMvVPCDRKbh5UUFajtRE 5b18aO8wzQfdKl3bVOUqNmDRUQypqI3Q1+ceuFNo1Izm7por58G2wBu/nPMjFu6796j+ xSSf4HjTKF4cFYWWGthhQWg68YyGUv8A6aNEPYsAHJ7YgPecCxywKz1wyyOHEuXBJWRP Wmgw== X-Gm-Message-State: AOJu0YzkIa4yeVJaliv7cmNI66Z1EUNehwcgMdHBNqL7yOdPM3JFZsD6 dzffYHNIStDpWdrZNi4Aj/1A6vROXQg7qMTG01d+fYYmJUVkyvW82bMGXWfpePXxX6gTTXZIPXa 3+pYvcA== X-Received: by 2002:a5d:6712:0:b0:337:c4e2:a1de with SMTP id o18-20020a5d6712000000b00337c4e2a1demr532631wru.105.1705592054244; Thu, 18 Jan 2024 07:34:14 -0800 (PST) Received: from localhost.localdomain (33.red-95-127-38.staticip.rima-tde.net. [95.127.38.33]) by smtp.gmail.com with ESMTPSA id i2-20020adff302000000b0033788e357e1sm4271671wro.108.2024.01.18.07.34.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 18 Jan 2024 07:34:13 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Markus Armbruster , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH] ui/gtk: Strip trailing '\n' from error string arguments Date: Thu, 18 Jan 2024 16:34:11 +0100 Message-ID: <20240118153411.2907-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org error_report() strings should not include trailing newlines. Noticed running: $ spatch \ --macro-file scripts/cocci-macro-file.h \ --sp-file scripts/coccinelle/err-bad-newline.cocci \ --keep-comments --use-gitgrep --dir . ./ui/gtk.c:1094:56:"gtk: unexpected touch event type\n" Fixes: 5a4cb61ae1 ("ui/gtk: enable backend to send multi-touch events") Inspired-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 810d7fc796..c819c72a20 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1091,7 +1091,7 @@ static gboolean gd_touch_event(GtkWidget *widget, GdkEventTouch *touch, type = INPUT_MULTI_TOUCH_TYPE_END; break; default: - warn_report("gtk: unexpected touch event type\n"); + warn_report("gtk: unexpected touch event type"); return FALSE; }