From patchwork Mon Jan 8 15:13:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 760771 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e02:0:b0:337:62d3:c6d5 with SMTP id h2csp935713wrz; Mon, 8 Jan 2024 07:15:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqlndQFajZ3LvaOxNsJKE+qswKfQoOORb+LUAjV4yTaO1Tpf0Hkn5O7pTw6qyxB3WLPCIG X-Received: by 2002:a05:620a:b52:b0:781:62cf:8600 with SMTP id x18-20020a05620a0b5200b0078162cf8600mr4367242qkg.100.1704726915045; Mon, 08 Jan 2024 07:15:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704726915; cv=none; d=google.com; s=arc-20160816; b=YcP3IObSoMGJOn2hjUzwldXb6lIFZ4z+tvcndiOkI06I6vr9udGOJnE9xXMzCxHbOB sEOTZTFGuJgpzncoMeyXJ7DiMQ8ONm9rX5KbV1ZXJkDhOnM8pgqDDISHD5el7YWg2fjv NNUoAX4oxXghww4o6MOsfA1QymeB40CwRNhSW15CmZHQBW/iSsyyHG49L4Juck8VTuik BtdpeO79xqzE8e7+/XMCm+sNP6lAR+9SQXkqgmDzXMfaWZ5xE+A5RJKZdeSRtJ7CCx1f YZgVMqxqFq9bnLvV6sgofmSwy8njjveDjW8rwmy2ysd7TBl+4PeX8lxXIGnZeCPw4Csk J0Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k9MwYzVVCpi8aRF113OyWJJfAJmZSssygUp+Otb9ZUM=; fh=g0tniTQGvTweTFoeEF7OF4zugwZFysymytcP6QxI5CU=; b=xs8r2sXYw1BqiEUOqfDWJTXV06nJtpb87rXW6T/y0zDnFQ+TlvQQJTeNBbnNQnDK7u qb73zN9piHsHsaRT7X9eDTV+8w75K2K6MwxpmFi9bFVDZZ9/DsjAZOesxbf/76OY9iMN Cw0zcEgVfrARDXkKHU0NonmHhHqOR1cO8ImeK+sszL+rWdxQJoJCY6SLwejy6+bqCATJ W0EdM9PhOx5gB7GppPrGcZEsIM8SKhRMJLBStF5mQECrbnhfVLxHqOg2i0rViEXkKfVh gXs0Jb7aj8YLABgY7VGWPONupff82FY7d8HA2t8/QqqyoJpUAEDQs1DVK6s7R/s8NUfY ggtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YXS7hglE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a8-20020a05620a102800b00783264580b0si1093637qkk.57.2024.01.08.07.15.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2024 07:15:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YXS7hglE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMrKK-0004GK-Hr; Mon, 08 Jan 2024 10:14:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMrKI-0004Er-6f for qemu-devel@nongnu.org; Mon, 08 Jan 2024 10:14:06 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMrKF-0001aY-8Y for qemu-devel@nongnu.org; Mon, 08 Jan 2024 10:14:05 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-33765009941so1594206f8f.3 for ; Mon, 08 Jan 2024 07:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704726839; x=1705331639; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k9MwYzVVCpi8aRF113OyWJJfAJmZSssygUp+Otb9ZUM=; b=YXS7hglEEUflE7sy6TJB7AtaVu2eupXd7DiMSywJV2moysIrqrvHckOprwfa7L8SJ7 3EcyMV4vgF5yHHUZktmzLdds510bu+1rDNf3Q3eCTzBpoJ9j7YAtMbRf8ILF6ZIQEtYk qiwvTX19Z/UGlO7XCE5DFw9dCWqomh/NgWQa0JUT7pV8lZAIPCqs2t/Qae2QTMxOQDra 1GSCsoXtzye5ZVnPzMytHzVQhXkxtnOgS1o4i79RDPBUYm1CUVdoFQqvhVNrhZGEkdw7 KjD5Zr5uZu56+rTS7pJ1DF7O0lFb/OZm3acH8SRI4m+OtcTQz/Oi5L0O/BCITNYFvQ1B /dzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704726839; x=1705331639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9MwYzVVCpi8aRF113OyWJJfAJmZSssygUp+Otb9ZUM=; b=UkQ2WhWz8PogixZjfW//rWUjI+GMGDmUiWQtqYITie8Giw/4H3+KiFEqKKYwyfb/T6 +VIcSR6p1NQUhf0BQRQuvnXU1i4aTM9KR0RqCdEywurJqmr0NKXUUe8/wyRybonBNR0/ g86kpi6+T9IPDF2EShNQYLtX14+Vjll205N8MTnu3RtETjQpCNgE6k6rreGI/9UAq1YF rzBrGpx0GpoetIsVhBJFAFh/nL9x/AyflAMvAtdbZtJ2D2Kg/YSoHiSIrhjFK6yrRTrp q9+P/wNKbqJJgQlyA4+sQ2I80mH1W1B1c3EFeygtR2mo/GRKZHJUf3nPRhS2/3gkCw7q GVaQ== X-Gm-Message-State: AOJu0Yx0h2dxZ7L+uYiAH4fuwCG1zU+94t/vYFTihyKcvBXlPlPXcutH QEegspdGCXen7lDfyXAqK3bdrHFu//fE4w== X-Received: by 2002:a05:6000:1204:b0:337:5ba9:3435 with SMTP id e4-20020a056000120400b003375ba93435mr2090385wrx.124.1704726839640; Mon, 08 Jan 2024 07:13:59 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id h13-20020a5d6e0d000000b0033677a4e0d6sm8039039wrz.13.2024.01.08.07.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 07:13:56 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B75D85F94E; Mon, 8 Jan 2024 15:13:53 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , Pavel Dovgalyuk , Paolo Bonzini Subject: [PULL 10/13] replay/replay-char: use report_sync_error Date: Mon, 8 Jan 2024 15:13:49 +0000 Message-Id: <20240108151352.2199097-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240108151352.2199097-1-alex.bennee@linaro.org> References: <20240108151352.2199097-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Now we have a centralised report function use it for missing character events. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20231211091346.14616-11-alex.bennee@linaro.org> diff --git a/replay/replay-char.c b/replay/replay-char.c index a31aded032e..72b1f832dde 100644 --- a/replay/replay-char.c +++ b/replay/replay-char.c @@ -113,8 +113,7 @@ void replay_char_write_event_load(int *res, int *offset) *offset = replay_get_dword(); replay_finish_event(); } else { - error_report("Missing character write event in the replay log"); - exit(1); + replay_sync_error("Missing character write event in the replay log"); } } @@ -135,8 +134,7 @@ int replay_char_read_all_load(uint8_t *buf) replay_finish_event(); return res; } else { - error_report("Missing character read all event in the replay log"); - exit(1); + replay_sync_error("Missing character read all event in the replay log"); } }