From patchwork Fri Dec 1 15:12:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 748998 Delivered-To: patch@linaro.org Received: by 2002:adf:f9cb:0:b0:32d:baff:b0ca with SMTP id w11csp332079wrr; Fri, 1 Dec 2023 07:14:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmaXkTiFOKazcLUSlcdSfYFUggHF3EuUgwTYDNIyh8gRCn02FyXzucJNCNIw3KFMYf/Grm X-Received: by 2002:a05:6808:2a50:b0:3b8:3e7d:db75 with SMTP id fa16-20020a0568082a5000b003b83e7ddb75mr2844538oib.55.1701443682927; Fri, 01 Dec 2023 07:14:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701443682; cv=none; d=google.com; s=arc-20160816; b=qeaGb8JFvzg1LV/tbx/t5p7tFerejgtveDVxmLckzsIZ/ppAuaN5v80CWH9qemNuJN RR4sbh29yvAmkXAqUMvr6jWGj6bV1YAPP1im2Uih9wyls+4nMwiPVG8HDGQnBHw6Lf4D +uLzb8b1IrbCyIpFQ+PrONbu0pgHMb6x9DLM6zkafhbx/lkuwSaFM/ioiKOrU8PGSbki RNvNvXHKud98NiBf2L5e99B7d6iFi6KESVcoE7DOddYWxGqs63YzkdBIiJxo2vKtnKhT +rwwH9lX5AhlccKMSCVkkLD3Rs8EK4ORnUaemqn70P1cmr+C7ubvVDbT+2ABxKhG3ERd It0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=57x23omuVrExXgPDfxrIdHt1R1VqyRD4qvLTNT8D6tI=; fh=DIFnA2gnOkQcXehrWmw8CTqvvnWQSXzchOMXflrcMUw=; b=zGNHw09vWADGwbDG8jc/5bx2zQCIkEhlY+SBXgGRQ3n5+Qak8ELppcOnWufPbEW7dO kwwtSa+9HBQdzoFREGZcYlzRDobCM8KQ/ckbJ+l5YUc28xile4udX+3UqULc8AgFQATE JsU2TtpzoL91mU5pZFriCDUrUevffut9d+6WYXQmQts/ACae+dh8YucCmZbGcl5Q4KCD oqWqSvabmy8OQ/1V0u4cwnFyW9263+oFMlv+SkxF/AjDFMxoKbTgh4E3L0zIaxow/fCJ RFk/aUGJCNJFu8/FzHv8J+IfJ9fYSlR/uyQiKijWGfnHypgbnjxaIElpHJagqr1dUCvO VntQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eIKZVJhU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dc33-20020a05610255a100b0045f0a41b3fdsi835716vsb.606.2023.12.01.07.14.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2023 07:14:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eIKZVJhU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r95Cq-000583-3H; Fri, 01 Dec 2023 10:13:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r95CX-00052l-HA for qemu-devel@nongnu.org; Fri, 01 Dec 2023 10:13:09 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r95CS-00053c-3m for qemu-devel@nongnu.org; Fri, 01 Dec 2023 10:13:09 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40b538d5c4eso17076035e9.1 for ; Fri, 01 Dec 2023 07:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701443580; x=1702048380; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=57x23omuVrExXgPDfxrIdHt1R1VqyRD4qvLTNT8D6tI=; b=eIKZVJhUzGBzmdGVEfWRhAZe+jQQWaxG5pHOSFyZBZsRCqmD2hmxF/P96rprv+H+T2 FBrlNtKQAfnMg6Il9UlW4V+kUHjdK63RrpYrPpjColwcyKqSJ16ie0H1OQYCyIYSy+IX JE3UbMYxhkxawEd14J/nSfWlxKjalrdyRe2g0wvVGqWQX9kVldW1pEUX2cWu/OS5fLsY ut0C7VEbpbNfKXTmqsdcZi0Sby65PD0RdtLs97ie2DwoilL/1FJYZZbZI6JSgg+r5bwX ZJjkS2H9RiC87Lm09mOu6B1/QU54guumXrEeUH+MSVJtAiEdyqxEgwpfnO2TsfLcePNs iv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443580; x=1702048380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=57x23omuVrExXgPDfxrIdHt1R1VqyRD4qvLTNT8D6tI=; b=Xg2wNJbcV/1x1N8Pfg1m8VWXOfuue7XCKPAFA7/kg9LQOtZZwvL4JMz7R+m/u0DiOe YajROpmfEUUISacZ3Yk6zTAmWsvx99tBAtEBGznzjKJHNXBCelCvEtG6adWfqp3Q0neB SczBuGG3xePzlbflY0IeiZcRBYVUXKOuXuDm9FUJPi6ZbJTupddRlrWNDKYoXInAfc1Z E2shA3OeRcruDa7gi+I0WFKvrGPBCwovFTCHwvkzc9O59nuaQN2toOeRXCTmdy4uYjaZ by/k/nHUx31L4hxVk16ch94N8FecyLT7eecwG6SBkRICVC3n8uVUnJneHHVzenQlP/pA BRIA== X-Gm-Message-State: AOJu0YxliCxYdmEQ4N9ldC1YESuYNdIy5FV956kqncmUKtIvvlfxPQxI FSCYA+carQJRETZEgbVJ+2HCfg== X-Received: by 2002:adf:f48d:0:b0:333:2fd2:4add with SMTP id l13-20020adff48d000000b003332fd24addmr896006wro.89.1701443579792; Fri, 01 Dec 2023 07:12:59 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id v10-20020adfe4ca000000b00332f95ab451sm4390896wrm.58.2023.12.01.07.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:12:56 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 00BB45FB61; Fri, 1 Dec 2023 15:12:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Luis Machado , Richard Henderson , Stefan Hajnoczi , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PULL 1/6] gdbstub: use a better signal when we halt for IO reasons Date: Fri, 1 Dec 2023 15:12:23 +0000 Message-Id: <20231201151228.2610209-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231201151228.2610209-1-alex.bennee@linaro.org> References: <20231201151228.2610209-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The gdb description GDB_SIGNAL_IO is "I/O possible" and by default gdb will try and restart the guest, getting us nowhere. Report GDB_SIGNAL_STOP instead which should at least halt the session at the failure point. Reviewed-by: Luis Machado Reviewed-by: Richard Henderson Acked-by: Stefan Hajnoczi Signed-off-by: Alex Bennée Message-Id: <20231201093633.2551497-2-alex.bennee@linaro.org> diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 465c24b36e..5c0c725e54 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -24,6 +24,7 @@ enum { GDB_SIGNAL_TRAP = 5, GDB_SIGNAL_ABRT = 6, GDB_SIGNAL_ALRM = 14, + GDB_SIGNAL_STOP = 17, GDB_SIGNAL_IO = 23, GDB_SIGNAL_XCPU = 24, GDB_SIGNAL_UNKNOWN = 143 diff --git a/gdbstub/system.c b/gdbstub/system.c index 783ac140b9..83fd452800 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -183,7 +183,7 @@ static void gdb_vm_state_change(void *opaque, bool running, RunState state) break; case RUN_STATE_IO_ERROR: trace_gdbstub_hit_io_error(); - ret = GDB_SIGNAL_IO; + ret = GDB_SIGNAL_STOP; break; case RUN_STATE_WATCHDOG: trace_gdbstub_hit_watchdog();