From patchwork Wed Nov 29 20:50:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 748102 Delivered-To: patch@linaro.org Received: by 2002:adf:e9c2:0:b0:32d:baff:b0ca with SMTP id l2csp530765wrn; Wed, 29 Nov 2023 12:51:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGh8HscHV0zplwP4gYa6AgN5Ftf/3u/MLM9AsAqAqCM3BhUmC08/GAd6BWwxJZv26I9tZ26 X-Received: by 2002:ac8:4e42:0:b0:408:392e:2aa5 with SMTP id e2-20020ac84e42000000b00408392e2aa5mr38018624qtw.20.1701291087649; Wed, 29 Nov 2023 12:51:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701291087; cv=none; d=google.com; s=arc-20160816; b=FrWLaGwfkilGnoQf2gqc4OMj+/0zlmQSaXcSsAkn7Ar/Q4jNoL3k3gGiUJCp0pKMD3 gclqjnlfHXuiN+V9tPfV0Ps/XcEbW1mUw3e2K+KYWX0D2RMDDT/zII/e+UvcCWRAwJ99 XiE8FUMIx/vLrvIyfORlSoD3ugqjT9u3fUuyWF6Y5qMCwx5xRa/zRCEG/wTcLamQv+1M 2ZnOxixJSrRH4w8plWB70P/CqFpf1iBO4OHIGKYNZqbxzZ4YQlmNv5QpKH7pEpWmWCUI oWv6W11ItFkwa9GBRIGxXF6Re+6iW0+ExOzyZIhzH8YCqWmt8oAaB5+xtRy2cn+Rmj/p RQ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=SRIF0HwWnMcIde9FIOMMN3+/mbfqwhuX49V+gQ6VB9c=; fh=WBTPEgeDqJrASZwG1Yz1imANzBcrbKw4I7HWbwuFFmc=; b=b8Ewnggg8AAxykI/JKYiXZm/Y2oVFPC1Cg1ccrQL47McSphSKjZDvZqfRUEeKwRHew WEj+T2SgFqVt3Ww+A/0m5eU+n1tmp2bZu7l5PaXNdYp/5k5dHpho/G87GCiijdOKfAk0 oe5UCKrycjzTHkqshZAeyqh7DIdSob9I+r+iC3zj8t5XfsMM5BvsmSh2YPPTaJjFZeQC V+4H3kzjJo9tJhPW7PX+rx9mv4sBljkaVSFon1JaDkTLHZ2AJZ2yyGOysoNivdhY95hz tVF9aPGr9FMMlkyrUujv6/UBozl/Y0BiIEAeq8V1PYPY3lcpd/sCyVrM8KC8LecaRfga cstw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFRl+l1o; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id cg6-20020a05622a408600b004239df7167esi11960693qtb.68.2023.11.29.12.51.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Nov 2023 12:51:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFRl+l1o; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8RWC-0002mr-72; Wed, 29 Nov 2023 15:50:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8RWA-0002mU-3U for qemu-devel@nongnu.org; Wed, 29 Nov 2023 15:50:46 -0500 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8RW8-0006Ir-Ep for qemu-devel@nongnu.org; Wed, 29 Nov 2023 15:50:45 -0500 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9afe6e21fso3660581fa.0 for ; Wed, 29 Nov 2023 12:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701291042; x=1701895842; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SRIF0HwWnMcIde9FIOMMN3+/mbfqwhuX49V+gQ6VB9c=; b=oFRl+l1o+/V6v0nLsMnUlywDEYCI6NFX8NrQTEh/Bvf8iIIr7HlbxgLupmVWwsbTBT xQyc9JSXiKxNy5CY4GovkoniismNw5BYSh1J2IEM3L88wIGngBrFRmubxwFfpHzFDf8V EKK3wZaJjBb6pYMfgFZVU6CfMkysRwTDX2u7r/3KWdGaorILS8fNZts0pcANFtt3oyx9 P1u+2yHFMTrdkhfPShnQ2iF8xXFnUFuuW3XBv9c293Syo5N4zo7/RgV7ySfUk/Oexr5a z2hNOLT5dZ2DBTsDqU3XVZkhMuREGTZAF1BUfWA1zhu7s7gHumm4728QEAa3P+Iyz5mE 9z4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701291042; x=1701895842; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SRIF0HwWnMcIde9FIOMMN3+/mbfqwhuX49V+gQ6VB9c=; b=we4nk4PS8Jri2HbEZt4QTBnl6cAmAsq/uOPSMPW8yPqMMk2VlFAsL90EpTd1mo/y9/ NTJphuMCtHQqiyJzd9EiKsEKLk9tlIyNHWsDiuqtPFC48WVbDbzxLeoiy97YwIx25/O/ LJB9g2b7d9ekYgZK/XFFvkRXXrVoUu4FFzFAiEHmHa4RnaDUzf1ueSMaJqKSGL23etdt zZGAOFZVOCTVLBdQISUIKaFGWdsekiy6oyifa++RW59/j/hLE6rcK84lgrLi0CYDD0Sr dAVs4vLYPpvbhpgPk6ONkwOtQUKpZtKrlAPGOlbDy1u4j5gdOK3IMp2+bwY2xHHeVuIX rRHg== X-Gm-Message-State: AOJu0Yw7ep//eXfpGb+bZ/TPeWGIi3lnLi8hOZiheHP0xWBKJy0133c5 KxHh9wnkQ59vGCRD7Jn6VM9zEOBklnn90+xrnptppw== X-Received: by 2002:a2e:b1c7:0:b0:2c9:c3a2:c89b with SMTP id e7-20020a2eb1c7000000b002c9c3a2c89bmr1154586lja.45.1701291041715; Wed, 29 Nov 2023 12:50:41 -0800 (PST) Received: from m1x-phil.lan (sal63-h02-176-184-16-250.dsl.sta.abo.bbox.fr. [176.184.16.250]) by smtp.gmail.com with ESMTPSA id l15-20020a05600c4f0f00b0040b33222a39sm3398847wmq.45.2023.11.29.12.50.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 29 Nov 2023 12:50:41 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cameron Esfahani , Paolo Bonzini , Roman Bolshakov , kvm@vger.kernel.org, =?utf-8?q?Philip?= =?utf-8?q?pe_Mathieu-Daud=C3=A9?= Subject: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels Date: Wed, 29 Nov 2023 21:50:37 +0100 Message-ID: <20231129205037.16849-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=philmd@linaro.org; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org 'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/dummy-cpus.c | 1 - accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - 3 files changed, 3 deletions(-) diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index b75c919ac3..1005ec6f56 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -27,7 +27,6 @@ static void *dummy_cpu_thread_fn(void *arg) qemu_mutex_lock_iothread(); qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; #ifndef _WIN32 diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index abe7adf7ee..2bba54cf70 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -428,7 +428,6 @@ static void *hvf_cpu_thread_fn(void *arg) qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; hvf_init_vcpu(cpu); diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6195150a0b..f273f415db 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -36,7 +36,6 @@ static void *kvm_vcpu_thread_fn(void *arg) qemu_mutex_lock_iothread(); qemu_thread_get_self(cpu->thread); cpu->thread_id = qemu_get_thread_id(); - cpu->neg.can_do_io = true; current_cpu = cpu; r = kvm_init_vcpu(cpu, &error_fatal);