From patchwork Wed Nov 15 20:51:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 743987 Delivered-To: patch@linaro.org Received: by 2002:a5d:67cf:0:b0:32d:baff:b0ca with SMTP id n15csp2964874wrw; Wed, 15 Nov 2023 12:52:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyGkSsqSzbV0zB5tcOe9lwwRB5m5QlPqDk3QgnD2r3tPWULzXaupLdRZv8IWgFJAxbwHqE X-Received: by 2002:a0c:d6ca:0:b0:64f:4e64:5962 with SMTP id l10-20020a0cd6ca000000b0064f4e645962mr6495360qvi.31.1700081533615; Wed, 15 Nov 2023 12:52:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700081533; cv=none; d=google.com; s=arc-20160816; b=dIAn+OxXTJRZNi4CKH2/xaElze+fJ/IDev5AWof+jIMwe9FSU2HcEN20K2GdGsfLJz R0vB3nu2kNOMNoyWBXKezr+O6YaS3TEOoAeHykZHDfi0rDIGo8ocK1uM3u3AkK6x5NWT OtzZc1EeRS5P2hvVllIBiyl1Qr3I+SrIypTmEGhzWRw64z2572J5VkgV6M1VZwMSOeoQ 59SGPmGBMv8cPaO5oyYTIuyoA0oXUXatMVOaKaRIaWLo8rraBq4aB7lKk7ftO+oYtUla FA6dD9Q9Lvyn+br+wSWngmIfq6gpTHDQujoXfAqhmAi/hrBFwcUBfUai+YmSEJlX7SZO 98Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=WUOuiVx0sbzDsigWcQKOEegvye4SJYDrqQTnsd5ZUSk=; fh=lgXgEkpyYg0PTOSnapzKBq7lV6Zwuumx6sGWdqFIz9w=; b=LWUbGeoCQF7gzz7xp2I6sw9Q6ajoyNQOyKd7l0MqaVv7c+26mABS5u/NTOaJvXQ1nG HxNzZzEWAKv/0lZztFE334Wuf5Srvfja/0JMgKLbb0LCClfnK1Ma1m99v7GxumwmaGGg YKnryHuQ8hHm19oghKx+0mvldp78OF/haXSaJlyAPqZXLHTHMvKYib57U7vZ/TXMHJto q2hsLhxYJWIVeNRQx0K6LdyC4NM1Sa8NlWCjrfuyMK1794KHLC1iCLh/U9R8PcUn1hDt fD/xNhIbBAIdfpZ+SbUCHRZ+WOnJeCDcY3zFZBpJvFewd5Twb6wTfL9MpdzC4/ptrXil uAEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SIJ07cFZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jf8-20020a0562142a4800b0066cee07e205si11805114qvb.175.2023.11.15.12.52.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Nov 2023 12:52:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SIJ07cFZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3Mre-0003Kg-2i; Wed, 15 Nov 2023 15:51:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Mrc-0003IH-5v for qemu-devel@nongnu.org; Wed, 15 Nov 2023 15:51:56 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3Mra-0004QD-Dl for qemu-devel@nongnu.org; Wed, 15 Nov 2023 15:51:55 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-33139ecdca7so71831f8f.0 for ; Wed, 15 Nov 2023 12:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700081512; x=1700686312; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WUOuiVx0sbzDsigWcQKOEegvye4SJYDrqQTnsd5ZUSk=; b=SIJ07cFZOmdapY2YYVCXxHHYyhzuT6bU/4QHpa0HbLLixwnthwSB3Gdr5mPihSJALX lQgzGlEmjcwsepAeVHDFWK0v1g4OUCCP9wlHo8gPbBCfkFIXLrfW3zfGXjeaDprsnY7X KQMDGir+LgnykUFYXRLtlq5X1HYRqKy+HiCTtpSQUdDdzIz3pwSpy1BddZIpgbKfwXoJ GVJtyXRTtGdYOWvaCLgRMDBU63cOvj6tXrjSojBWYZF0XKbOGTEiIyyztLwiewQmH68D UDc5GuH2e5e4Ny5R7ep7y2VfcNTtfzeEp+rOURCEuFoHmsWAh6JOkVyCCS1QVBVULwH4 +rdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700081512; x=1700686312; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WUOuiVx0sbzDsigWcQKOEegvye4SJYDrqQTnsd5ZUSk=; b=idt7nxfY0LBIHU6fTEKsy5cRLgnBLkjsfx3KNYwRZu8KuCbCR/+jPEKqbwAi1VX7rm XzMA5F+/Hxq4DQXvgzeL5iGf7QSG9qJkLNnPHHknUMazKxWBLDie9gepVefUy3eTQf2I oTpNv4rXTbRURAY9TQYgtuy+L2LlSB6WknM/kViaVTpJ3wRY0gSH3YAaUT5yYXnlDF8s 8b+jcdTxXnB5X0CZjDrKnMwVhV07uoz/hw8aNmiVSdK5L+5jEzhxqU674nGm8OgO2cTO GppPyzAK5cfp9c52m62whMa/GRtl9pcME+vlCgtDkrdzLeG561EjJl2H6vjCEiQT+jKr QTDA== X-Gm-Message-State: AOJu0YwPWopLu6bRTOXkpNiSyzjpNwXcZH/p2gz4bl/QWHdZGpjiEGDK K9qYabqaEC4OUjB0sxqLZkYUFyGi94FBJ6RsgIE= X-Received: by 2002:a5d:4576:0:b0:32f:7bf6:db01 with SMTP id a22-20020a5d4576000000b0032f7bf6db01mr7880224wrc.67.1700081512126; Wed, 15 Nov 2023 12:51:52 -0800 (PST) Received: from m1x-phil.lan ([176.176.130.62]) by smtp.gmail.com with ESMTPSA id l10-20020a5d674a000000b0032d09f7a713sm11484002wrw.18.2023.11.15.12.51.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Nov 2023 12:51:51 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , Beraldo Leal , Cleber Rosa , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?= =?utf-8?q?el_P_=2E_Berrang=C3=A9?= , Thomas Huth Subject: [PATCH-for-8.2? v2] tests/avocado: Make fetch_asset() unconditionally require a crypto hash Date: Wed, 15 Nov 2023 21:51:49 +0100 Message-ID: <20231115205149.90765-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In a perfect world we'd have reproducible tests, but then we'd be sure we run the same binaries. If a binary artifact isn't hashed, we have no idea what we are running. Therefore enforce hashing for all our artifacts. With this change, unhashed artifacts produce: $ avocado run tests/avocado/multiprocess.py (1/2) tests/avocado/multiprocess.py:Multiprocess.test_multiprocess_x86_64: ERROR: QemuBaseTest.fetch_asset() missing 1 required positional argument: 'asset_hash' (0.19 s) Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée --- Based-on: <20231115145852.494052-1-thuth@redhat.com> "tests/avocado/multiprocess: Add asset hashes to silence warnings" Based-on: <20231114143531.291820-1-thuth@redhat.com> "tests/avocado/intel_iommu: Add asset hashes to avoid warnings" Supersedes: <20231115153247.89486-1-philmd@linaro.org> v2: Fixed type in subject (Alex) --- tests/avocado/avocado_qemu/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py index d71e989db6..304c428168 100644 --- a/tests/avocado/avocado_qemu/__init__.py +++ b/tests/avocado/avocado_qemu/__init__.py @@ -254,7 +254,7 @@ def setUp(self, bin_prefix): self.cancel("No QEMU binary defined or found in the build tree") def fetch_asset(self, name, - asset_hash=None, algorithm=None, + asset_hash, algorithm=None, locations=None, expire=None, find_only=False, cancel_on_missing=True): return super().fetch_asset(name,