From patchwork Fri Nov 3 19:59:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 740718 Delivered-To: patch@linaro.org Received: by 2002:adf:fd90:0:b0:32d:baff:b0ca with SMTP id d16csp9639wrr; Fri, 3 Nov 2023 13:05:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5m1wjvREY3mx39YyTj7MDS9tGDS3q1zOCPY+iYDsgvIy0qrrBxKVosMeQgz4uZj4rWb6/ X-Received: by 2002:a05:620a:24c1:b0:774:2dc0:649b with SMTP id m1-20020a05620a24c100b007742dc0649bmr6396977qkn.18.1699041904225; Fri, 03 Nov 2023 13:05:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1699041904; cv=none; d=google.com; s=arc-20160816; b=LZmVVRnUivONM8KpbxfRjJN2argJ2vbx4p8BKvGeDO9wBW0OGt5U1cd9/2xtnqtE1Q 5nc1B+VwrHvCOOs+cU7+/6vmhpauQ3xcn3QgLH9ruWaB9TYPu+TINPLx5lhzpIzzWx/s jp2226F6qB1gdN7evz8jelHWzezCm1LBeYNQo0Qb6PozeQ6tv92EAWTKj37ZiuTooKx7 8xsiBO5PvM1QhxD2ycT1RMn/HSP/ezaIzBmhbwgvp3nHnfSNQ6tfG8pYfG7KFXjwQa/T xEY7n0Kwp6vkrFO3haYDKmUlAx6xwSpZINRPnICxSJqR1z8Yj7FhqfD4PfHXQd5RK8dz Tzpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KYZuWVa43D0DKc9oObff9+vpWR6o8oc5r5+fymGHhRI=; fh=Kx2XI2Yx2wBtcq6Uh/oWjWfpY5DZOGguZfb2uQrLFXM=; b=jyHUnmWTIpowDXyV8LAn3sK/msLcN06N1zPCvA+o6MGHfjKZ2p72nSRZ+LmYeZzyuW 6bAxqqo7E0EC+fpNTK4Ij7hpWfdfVQyY96XHHpDVkODqZlL7nzSpRrglHrqnW145Mplg J/O4eaLkD97zyJspBdvYl9xjFzmxw8gPfrKGUtC1voVqL/u7rC+rex3XzCnxBopX3ZJ7 elH50wRq4uvTSuWCHfqWrp47EkGR4JKJiyfM5RxwD6FJgLGxYw0I76MYpGyCtZ4BBhQR 4fvHgIientGQLyPUBWwlNSZaL0XkFmpS+iw8tHDFi8/Dnt/oZI8z4PJVDcQukYWoWTO3 4vdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cumF0FkW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a12-20020a05620a438c00b00779ab3d4204si2069608qkp.648.2023.11.03.13.05.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Nov 2023 13:05:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cumF0FkW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qz0LV-0008Rk-8f; Fri, 03 Nov 2023 16:00:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qz0Kv-00088o-Pc for qemu-devel@nongnu.org; Fri, 03 Nov 2023 16:00:09 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qz0Kp-0005Ld-DJ for qemu-devel@nongnu.org; Fri, 03 Nov 2023 16:00:09 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-32fb95dfe99so533096f8f.2 for ; Fri, 03 Nov 2023 13:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699041601; x=1699646401; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KYZuWVa43D0DKc9oObff9+vpWR6o8oc5r5+fymGHhRI=; b=cumF0FkWaivF51fD/Urub2D1CpzAw2Dz6T1PT7trM7nguvlDlry20iSM0w+uGp9TYv NKJeE2aLI5aGWmXu9BWZDL2lD8nKbx+6NNCOnKU7vIP6X7a8Z/FdS8VVF4fmNtbq4wh6 VcifJETRim+/sVOHRSn60cmH0Ao/VOv+8AFNrXSRTQmhQCMSPPSIbeaZhzs4Y5lclwpf A3NSuEMbHghKZT1SWZnL/yPX+Js2p4n9EiZq2iOhM+lamFakVw+ymIL8X68zvkodAH2J zaRyCSOL+lr/B6n5YWVxXZbNonoT5ZNZvLjrEOJ/EEyPqHehzPcEJLfQ8HKstjtUTbdZ KGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699041601; x=1699646401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KYZuWVa43D0DKc9oObff9+vpWR6o8oc5r5+fymGHhRI=; b=GylYoE9CjBVynD9scw4lGQRUzXbpgP1jobuZuUTUb+NKvbFDhp4XZdbVTbb4bN8+Ow lbiM7r1oOX8zx5vEtWVh5pAI1nKEbso1CyAZmrlksvJapfUhQ92u1t3vpxfegqfiHqMA IjLrph1sSawBX9qJJw/ZRCQzPqcQ2kh0H0iBfGuNeccH54BDAwvjCU9wb+yy0GyXvQNf TCsX0inzfmz3s3p98BO09WdvkPpLDm9h14ZgyNyLIeDaHUZAQuI6zmW11WAzJNrzZNri uU1ep+TEUhdFuHp6Y2qwFyOHsK139T7C/l4Fd8zFp813nAz9Xt4OmBBI18+xIG2TpWAO K3wQ== X-Gm-Message-State: AOJu0YzSg2Ra2+DS824x9+wE902KX19XdEbK7OFSAyAoY+PkbQeLfOAw 7QDpC5Q806atlQsGZmRuud/N8g== X-Received: by 2002:adf:f18f:0:b0:32f:bdb5:98b0 with SMTP id h15-20020adff18f000000b0032fbdb598b0mr1409673wro.66.1699041600885; Fri, 03 Nov 2023 13:00:00 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id r7-20020adff107000000b0032db8f7f378sm2625170wro.71.2023.11.03.12.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 12:59:57 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id EBCA865742; Fri, 3 Nov 2023 19:59:56 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Peter Maydell , "Edgar E. Iglesias" , Song Gao , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Wainer dos Santos Moschetta , Weiwei Li , Marcel Apfelbaum , Ilya Leoshkevich , Daniel Henrique Barboza , Yanan Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?C=C3=A9dri?= =?utf-8?q?c_Le_Goater?= , Paolo Bonzini , David Hildenbrand , Brian Cain , qemu-ppc@nongnu.org, Palmer Dabbelt , qemu-riscv@nongnu.org, Eduardo Habkost , =?utf-8?q?Phi?= =?utf-8?q?lippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Liu Zhiwei , Cleber Rosa , qemu-s390x@nongnu.org, Laurent Vivier , Yoshinori Sato , Nicholas Piggin , Thomas Huth , John Snow , Alexandre Iooss , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Mahmoud Mandour , Daniel Henrique Barboza , Bin Meng , Beraldo Leal , Richard Henderson , Michael Rolnik Subject: [PATCH 03/29] target/arm: hide the 32bit version of PAR from gdbstub Date: Fri, 3 Nov 2023 19:59:30 +0000 Message-Id: <20231103195956.1998255-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231103195956.1998255-1-alex.bennee@linaro.org> References: <20231103195956.1998255-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This is a slightly hacky way to avoid duplicate PAR's in the system register XML we send to gdb which causes an alias. However the other alternative would be to post process ARMCPRegInfo once all registers have been defined looking for textual duplicates. And that seems like overkill. Signed-off-by: Alex Bennée --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 5dc0d20a84..104f9378b4 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -3727,7 +3727,7 @@ static const ARMCPRegInfo vapa_cp_reginfo[] = { .access = PL1_RW, .resetvalue = 0, .bank_fieldoffsets = { offsetoflow32(CPUARMState, cp15.par_s), offsetoflow32(CPUARMState, cp15.par_ns) }, - .writefn = par_write }, + .writefn = par_write, .type = ARM_CP_NO_GDB }, #ifndef CONFIG_USER_ONLY /* This underdecoding is safe because the reginfo is NO_RAW. */ { .name = "ATS", .cp = 15, .crn = 7, .crm = 8, .opc1 = 0, .opc2 = CP_ANY,