From patchwork Fri Oct 27 14:39:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 738667 Delivered-To: patch@linaro.org Received: by 2002:a5d:5101:0:b0:32d:baff:b0ca with SMTP id s1csp472058wrt; Fri, 27 Oct 2023 07:40:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJqM1dEkhBuSHpYcy4uhHHbwx7lMj/lwMZeU23xfFIRK9dPaW4WuZLFufWHGoXxTLzAMCT X-Received: by 2002:a25:d15:0:b0:da0:6179:4298 with SMTP id 21-20020a250d15000000b00da061794298mr2518244ybn.52.1698417649545; Fri, 27 Oct 2023 07:40:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698417649; cv=none; d=google.com; s=arc-20160816; b=E4vp+0wF1zLZoIlgKVZJyX8DIJg0m2xhr1jp2Y3qHHSVqXXlIM54WBNqgMP1iQZdKI Nw4og/p2u0B6D4JKWRSN5TfLYUOAU4SVSyAXKZMHWL2gGG5euCjG4kbZsESl7UDHB4gY ppQa3FAgvjT3c4L4gFLOeCZPpbCqkPnATYrhRl1n+z6/FI0iZfqLXP1aXbqj9ZYkLsZU sCA1DJNk99IbE5DdDMP2ZlmS1ECzC1M050vFywYsXNtMgTBDzNkdWMKMdruErwETFMU6 2UhOvpZFvKQ1xw1mbvk2mV0fgnIPT38d39NlDkRoaNXMU8gnq/bE8CYiMpaMX0GERHb/ AjBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ooIxHMi95VXio8x/IzvnYifgViPdiDgXLTDa5pp5B1I=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=DEXdgrYWTGMwPgdvQJm63ExvuSE1J8/IooYflBz09MTeivUc2PJOcrZ0f33YoYl28r Gf9WB6Og4Hjvonxh9jzyGu64U9m/mwiLJC3l988YSLNJmL+3eAweS39wlOZ+TXJCosFv e/RO+yqelF50eWMJ5yO+Wu8jrDrQnmX0WDyhF5UVnuD2mXWQW+0bhc0QNIvRVjoVWLcn nnynusqligDK3rTyLiRwkYGkEEnFANjzthWVUiRD7qOQD5Uc6s+AWryu6A+Ua4e/8ICT fJ5/TILqJavVI/340BfvxrrAn+8b9bKx1nsQlTNoQ/RyzS7si3vsMtdJHMAVSgh3Gb2e NObw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M30YwRnT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d204-20020a254fd5000000b00d81504fa809si2534181ybb.112.2023.10.27.07.40.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Oct 2023 07:40:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M30YwRnT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwO0Y-0007Uj-Oj; Fri, 27 Oct 2023 10:40:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwO0F-0007IN-6F for qemu-devel@nongnu.org; Fri, 27 Oct 2023 10:39:59 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwO0B-0008AF-Rh for qemu-devel@nongnu.org; Fri, 27 Oct 2023 10:39:58 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-31fa15f4cc6so1488326f8f.2 for ; Fri, 27 Oct 2023 07:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698417594; x=1699022394; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ooIxHMi95VXio8x/IzvnYifgViPdiDgXLTDa5pp5B1I=; b=M30YwRnTo5KnoQN8I1Lcsu/mEomArVNHgezrYAi1qhAkc4LFjCttqu+84Od0ScaKfa m7a6x7tiDkLfrTKPRoCGJIHA0M7tZcR6vorbMTroJl0U/JiENrLm/UokZ20coztDOeK/ Je7HKa3Wj1OkoAISBNZxz53AiKWXCbn0CmzQlU5uT402o/6q/toMLMxNw7tdnCoMwZ4S ZcgFoKu8ISne0lPVQAuvuokJyhVtpxpgpcdDRn28nSTw29pq1Z2geDw04AKGnEVy9H43 usEbhs4M8fw6lz1b5fP9C6nkwwdE3AcdZ5zTehweCXu/4JarX7oyTYkaLL9S17oh5ruM rTeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698417594; x=1699022394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ooIxHMi95VXio8x/IzvnYifgViPdiDgXLTDa5pp5B1I=; b=Lss7xMyiNtM7okC4NOQq5ZNuJ82jAYzlxMoFS6Cteqsj8jjNch7Hp5bAWSZYTRyD/O vdHLUWnt54z4mjca5QJEYNAtw8I+zUd7QwNuh+++NnZHu0k4F+ZVx4VAjHAQQpgRdfkD wb+OgIMPEO6lrJshxpTxyxOPsreN+uHm4T0jrQ0grzONKbmEVN683cdlWYhULNbscVcE QlN0l40e1tKFl4EO9YyEANudss5sWaVXAngVTQD0p2ugla4O3C2FhlEyKEellFYwl2PM cSrn3O8tQAEhCXK+9DvVelI3dVq/TQ2X2UCKCzLARd1bdF/noSzpd7nP0vXP47l+gaw/ S57g== X-Gm-Message-State: AOJu0Yywh963QoMD45rCErWv4NWxUKAeYq1k9E2dEVNhdAs4dma3dXpA mQbQpgJZMmR8xvVf8APJkzSb80W8x0yHXl5MQJo= X-Received: by 2002:adf:ed84:0:b0:32d:a2cd:ad0c with SMTP id c4-20020adfed84000000b0032da2cdad0cmr2128329wro.50.1698417594563; Fri, 27 Oct 2023 07:39:54 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id e2-20020a5d5002000000b0031c6581d55esm1874123wrt.91.2023.10.27.07.39.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 07:39:54 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 22/41] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it Date: Fri, 27 Oct 2023 15:39:23 +0100 Message-Id: <20231027143942.3413881-23-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231027143942.3413881-1-peter.maydell@linaro.org> References: <20231027143942.3413881-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé sysbus_mmio_map() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-id: 20231020130331.50048-4-philmd@linaro.org Signed-off-by: Peter Maydell --- hw/pcmcia/pxa2xx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/pcmcia/pxa2xx.c b/hw/pcmcia/pxa2xx.c index fcca7e571b2..e7264feb455 100644 --- a/hw/pcmcia/pxa2xx.c +++ b/hw/pcmcia/pxa2xx.c @@ -142,15 +142,12 @@ PXA2xxPCMCIAState *pxa2xx_pcmcia_init(MemoryRegion *sysmem, hwaddr base) { DeviceState *dev; - PXA2xxPCMCIAState *s; dev = qdev_new(TYPE_PXA2XX_PCMCIA); - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); - s = PXA2XX_PCMCIA(dev); - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); + sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base); - return s; + return PXA2XX_PCMCIA(dev); } static void pxa2xx_pcmcia_initfn(Object *obj)