diff mbox series

[PULL,02/11] tests/throttle: Clean up global variable shadowing

Message ID 20231027093710.273558-3-thuth@redhat.com
State Accepted
Commit e9894bc95afba5d5e8422b723fcf7d658cba1fea
Headers show
Series [PULL,01/11] system/qtest: Clean up global variable shadowing in qtest_server_init() | expand

Commit Message

Thomas Huth Oct. 27, 2023, 9:37 a.m. UTC 
From: Philippe Mathieu-Daudé <philmd@linaro.org>

Follow all other tests pattern from this file, use the
global 'cfg' variable to fix:

  tests/unit/test-throttle.c:621:20: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
      ThrottleConfig cfg;
                     ^
  tests/unit/test-throttle.c:28:23: note: previous declaration is here
  static ThrottleConfig cfg;
                        ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Alberto Garcia <berto@igalia.com>
Message-ID: <20231009100251.56019-3-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/unit/test-throttle.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
index ac35d65d19..2146cfacd3 100644
--- a/tests/unit/test-throttle.c
+++ b/tests/unit/test-throttle.c
@@ -618,7 +618,6 @@  static bool do_test_accounting(bool is_ops, /* are we testing bps or ops */
                                  { THROTTLE_OPS_TOTAL,
                                    THROTTLE_OPS_READ,
                                    THROTTLE_OPS_WRITE, } };
-    ThrottleConfig cfg;
     BucketType index;
     int i;