From patchwork Tue Oct 17 06:12:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 734298 Delivered-To: patch@linaro.org Received: by 2002:adf:f0cd:0:b0:32d:baff:b0ca with SMTP id x13csp324511wro; Mon, 16 Oct 2023 23:21:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpwwPo3dhqc0vQigv6GY01E12Lb0KeqAZyl7MI7fnXBQaE9rTdsdshpAHo3lFBsAuVDejJ X-Received: by 2002:a05:620a:40c7:b0:772:63d9:6e69 with SMTP id g7-20020a05620a40c700b0077263d96e69mr1038839qko.35.1697523717274; Mon, 16 Oct 2023 23:21:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697523717; cv=none; d=google.com; s=arc-20160816; b=uBuBknzDmfvR/LF0DOLgGlTyk9X7VPUeWVRRPprsLngCQp8G1ZxR7jGaNZQIK/8v2Y PX08pY6MXEoDFXgoK2kswxzTtzXkaDKa/vYqj9c5StaN016HmsUUILHaseYdOVbQALvN xeN3VU6lB75drtmcju8kwMarkdl9jAkAQnr/tTNRZcK0ErdDn+gUP797C9D+MAW8QNOA oCgy5t+Ulw+xoxQvKkypbdJxrbhQYDgaZiB0dxxwALjm1dNEoZN6MGrFqlK4NhCLLHpr lXCnXxWd+RRhbwL7sXVichERwnKxEmyt58N227eZZDYWD6N/UxWcsdlG0xNQ9kMvr5aA TTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0vCuq+uuID5Z32hzaclmdSsH09x8KML1p7HKEF5dnuA=; fh=TYrED6TOMxGX0VC4GtjviASLbYyJe19+7/tKWjN44KQ=; b=O7IWVrpZ0kwpUMLge3GPzAFgxfoVTF7Bj8ySimo9QEDUIxmLB5bkCP1SrR6cF47Hep y4utscEehbcQih6iypCKHI6CEPsEaQZLu4+EOqUOBN6Ulzc0ttBhPt37Jdi8NnaTbm3O qw/04y5Iv9spIh8lwdOuOnz5/kbBB88OEtgH1vHm6yaRgcO+pYaIxkXvWjJjVlLTIBZI k0umEWruwM9+ve9vzmiWYoQtfU2VOuaiEenGz9PamC7Gu/iR2/Ie4a22dUQs0JhCsRW5 skF15Ct6L3rsPRO5G0ZfOeChlJSpXoawVoOmfGREg28DOVzr1yWCsXOXH55oo1JT0qBm eTXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CqAnKowJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i9-20020ac85e49000000b0041965efdac4si642827qtx.395.2023.10.16.23.21.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Oct 2023 23:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CqAnKowJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsdO2-00045u-Nr; Tue, 17 Oct 2023 02:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsdNt-0003dK-V0 for qemu-devel@nongnu.org; Tue, 17 Oct 2023 02:16:53 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsdNr-0004pG-3v for qemu-devel@nongnu.org; Tue, 17 Oct 2023 02:16:53 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5892832f8daso4886842a12.0 for ; Mon, 16 Oct 2023 23:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697523410; x=1698128210; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0vCuq+uuID5Z32hzaclmdSsH09x8KML1p7HKEF5dnuA=; b=CqAnKowJVMDawXz/b3myT8j/N7r1AeL9nQJTGEIsDPEkatPQpIAvFY8ddN3zpSQjDS /XPNzHRfkwXvLEr+XmKhV7NX75yXKN/+BSKQbK3lOpnxt+UwEU43dk/VTC6YazqVjDD1 Lnk94VXx+NC1CNdqWGhOrxxZZ92SfbWqY8wJNf1QoXn4rWUTMyLAK5gk3VL7Lf3Q8RJL OHVLij5I3CFdkdDqBFGoQOBwbHg6Bak0/KDw60D0pJiV41ORnUab+82V/uIpwA6kzv6H H9QAI37TCTdCY/VJf98GjqXFwvmNholkryhrcUVq39ab4JBHqSro1Ri6o0n7h7BA/8xA Rvrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697523410; x=1698128210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0vCuq+uuID5Z32hzaclmdSsH09x8KML1p7HKEF5dnuA=; b=vg3H1BRTv0tmfvyYJFPM1SM1xy+G++sZo4+kdss+0ZE0zeAlE6t0FyWyFFPIIjjfwu XeNL32unOvXT2LXnrdupVOVVDLWXXCtdXnBSj5memt/WRFAZbxm4Iswt4nXdDieHI6dK dO7jqqQ3GFOHSM69WKkpW+DEycd9BCmYkwYmz3nyvQ88tkV74EkvKlC0GheoiWR1OtRj Zoi0oDyLqj682nHlA7m/ryMazSSAPQlVeUBBKUemdqDG5aXO0hExFHNro36055jFLJqJ LO8HpS7tCh58j9zYjJqsPmmcnnVo53osIfqdOfjZj2wSSpkuNpDeOrw1W5evp4q4U1mq HNng== X-Gm-Message-State: AOJu0YwQ6gX0/GMglJMglwcedPGBIcudlGCQj2xX9jUoEcRniARkdgLH t4+FQzdHcMoLnm8Hdz6MZBidiUX9dUcldz5x+iY= X-Received: by 2002:a17:90a:4b0f:b0:277:61d7:78be with SMTP id g15-20020a17090a4b0f00b0027761d778bemr1461000pjh.14.1697523409777; Mon, 16 Oct 2023 23:16:49 -0700 (PDT) Received: from stoup.. ([71.212.149.95]) by smtp.gmail.com with ESMTPSA id m10-20020a056a00080a00b00690ca4356f1sm579280pfk.198.2023.10.16.23.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 23:16:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk Subject: [PATCH v2 75/90] target/sparc: Move gen_fop_QQQ insns to decodetree Date: Mon, 16 Oct 2023 23:12:29 -0700 Message-Id: <20231017061244.681584-76-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017061244.681584-1-richard.henderson@linaro.org> References: <20231017061244.681584-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Move FADDq, FSUBq, FMULq, FDIVq. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 52 +++++++++++++++++++-------------------- 2 files changed, 30 insertions(+), 26 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index a86c9c85f7..0f7d898071 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -243,12 +243,16 @@ FSQRTd 10 ..... 110100 00000 0 0010 1010 ..... @r_r2 FSQRTq 10 ..... 110100 00000 0 0010 1011 ..... @r_r2 FADDs 10 ..... 110100 ..... 0 0100 0001 ..... @r_r_r FADDd 10 ..... 110100 ..... 0 0100 0010 ..... @r_r_r +FADDq 10 ..... 110100 ..... 0 0100 0011 ..... @r_r_r FSUBs 10 ..... 110100 ..... 0 0100 0101 ..... @r_r_r FSUBd 10 ..... 110100 ..... 0 0100 0110 ..... @r_r_r +FSUBq 10 ..... 110100 ..... 0 0100 0111 ..... @r_r_r FMULs 10 ..... 110100 ..... 0 0100 1001 ..... @r_r_r FMULd 10 ..... 110100 ..... 0 0100 1010 ..... @r_r_r +FMULq 10 ..... 110100 ..... 0 0100 1011 ..... @r_r_r FDIVs 10 ..... 110100 ..... 0 0100 1101 ..... @r_r_r FDIVd 10 ..... 110100 ..... 0 0100 1110 ..... @r_r_r +FDIVq 10 ..... 110100 ..... 0 0100 1111 ..... @r_r_r FdTOx 10 ..... 110100 00000 0 1000 0010 ..... @r_r2 FxTOd 10 ..... 110100 00000 0 1000 1000 ..... @r_r2 FiTOs 10 ..... 110100 00000 0 1100 0100 ..... @r_r2 diff --git a/target/sparc/translate.c b/target/sparc/translate.c index a875ca716b..f1bc85c1d7 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1624,19 +1624,6 @@ static void gen_ne_fop_QQ(DisasContext *dc, int rd, int rs, } #endif -static void gen_fop_QQQ(DisasContext *dc, int rd, int rs1, int rs2, - void (*gen)(TCGv_ptr)) -{ - gen_op_load_fpr_QT0(QFPREG(rs1)); - gen_op_load_fpr_QT1(QFPREG(rs2)); - - gen(tcg_env); - gen_helper_check_ieee_exceptions(cpu_fsr, tcg_env); - - gen_op_store_QT0_fpr(QFPREG(rd)); - gen_update_fprs_dirty(dc, QFPREG(rd)); -} - static void gen_fop_DFF(DisasContext *dc, int rd, int rs1, int rs2, void (*gen)(TCGv_i64, TCGv_ptr, TCGv_i32, TCGv_i32)) { @@ -5051,6 +5038,31 @@ static bool do_dddd(DisasContext *dc, arg_r_r_r *a, TRANS(PDIST, VIS1, do_dddd, a, gen_helper_pdist) +static bool do_env_qqq(DisasContext *dc, arg_r_r_r *a, + void (*func)(TCGv_env)) +{ + if (gen_trap_ifnofpu(dc)) { + return true; + } + if (gen_trap_float128(dc)) { + return true; + } + + gen_op_clear_ieee_excp_and_FTT(); + gen_op_load_fpr_QT0(QFPREG(a->rs1)); + gen_op_load_fpr_QT1(QFPREG(a->rs2)); + func(tcg_env); + gen_helper_check_ieee_exceptions(cpu_fsr, tcg_env); + gen_op_store_QT0_fpr(QFPREG(a->rd)); + gen_update_fprs_dirty(dc, QFPREG(a->rd)); + return advance_pc(dc); +} + +TRANS(FADDq, ALL, do_env_qqq, a, gen_helper_faddq) +TRANS(FSUBq, ALL, do_env_qqq, a, gen_helper_fsubq) +TRANS(FMULq, ALL, do_env_qqq, a, gen_helper_fmulq) +TRANS(FDIVq, ALL, do_env_qqq, a, gen_helper_fdivq) + #define CHECK_IU_FEATURE(dc, FEATURE) \ if (!((dc)->def->features & CPU_FEATURE_ ## FEATURE)) \ goto illegal_insn; @@ -5112,23 +5124,11 @@ static void disas_sparc_legacy(DisasContext *dc, unsigned int insn) case 0x46: /* fsubd */ case 0x4a: /* fmuld */ case 0x4e: /* fdivd */ - g_assert_not_reached(); /* in decodetree */ case 0x43: /* faddq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_faddq); - break; case 0x47: /* fsubq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fsubq); - break; case 0x4b: /* fmulq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fmulq); - break; case 0x4f: /* fdivq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fdivq); - break; + g_assert_not_reached(); /* in decodetree */ case 0x69: /* fsmuld */ CHECK_FPU_FEATURE(dc, FSMULD); gen_fop_DFF(dc, rd, rs1, rs2, gen_helper_fsmuld);