From patchwork Wed Oct 11 10:33:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 731944 Delivered-To: patch@linaro.org Received: by 2002:a5d:54d1:0:b0:31d:da82:a3b4 with SMTP id x17csp326274wrv; Wed, 11 Oct 2023 03:35:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErLllThhk9ymbklpDkImpa9m0uuKxCYmH8N9Yy+4GoWuqlie4Uir+OXOeukFxjLBJjBGF1 X-Received: by 2002:ac8:7d0b:0:b0:418:737:87fc with SMTP id g11-20020ac87d0b000000b00418073787fcmr25811331qtb.18.1697020551546; Wed, 11 Oct 2023 03:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697020551; cv=none; d=google.com; s=arc-20160816; b=qA3mKK1zp407YhkJUZ3ERbCEpW3c5URr10B45FAjxFaLBVxO35+qZG2I1b2sQo1cCU 4Bh7yhSVKTBrasXLMWQNt4XjhWSIoTEbpOGSaTNrplrJt5EClaozgg8nQj2XHNA5U0oM TnZVdLZN0X9/vCs+Xp/dY43D2K5GQaIeLer5WjdLUWS3CKLdKAR0F9N//0swiLEqi3P4 YEG5kJv4EQQ623w87vVTpzx25lORmw52sCSF6VFaMniJwG2cWFJcnUd4bABm1f5NZt/X xqAkTxja8FEX0PgbsQc20oSVV2r8V25c4jDhB8QKKRWIWqTrz2jhyb5GiqeZLg7abKPc 2aEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tXtc55X9ZMWnLYaJ7rtH4hZORRpdhmNZnt+nFsO0Mb4=; fh=0krr7TACl5TzF2Q+IYI3uEo233L4eFHoGi0NC6HgaMw=; b=ms5UBD5uOxXbJexwk9ma9+p1rv7BXix0ZqACJn1Cjc5dekf4ULROh/j2fmshJZ/lxJ 4CZ+U/zn386uWbmFNvePqGfi0NZjw1t/nr3MsQaGeTpEfYyXJyYDMjYAoQVr9YCuIVDI wkj1F7T/Cm1Sm1m0l3VDS/WX3T2RBt+ad+DnQQP6t3V7ttrX88Fv3xNd85ZSSLSLsYpc MXHXlhlLW76pDB8HgnSlj/JIPLlBAgwL2zvVTp4N0LLl8lDg182/9LrdUSJPVJ3ErM3c ET3Z2NjF96Te4bBvxmZ1l7CHwwUhxiejMXDwHp/qH2Lkw+HdECQdO4AmZDU+VWql+TL5 FRpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwSNGSro; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g12-20020ac8580c000000b00417ced9f09asi9070259qtg.735.2023.10.11.03.35.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Oct 2023 03:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OwSNGSro; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqWXG-0001Xm-El; Wed, 11 Oct 2023 06:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqWX5-0001Ku-MQ for qemu-devel@nongnu.org; Wed, 11 Oct 2023 06:33:41 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqWX2-0005BM-8w for qemu-devel@nongnu.org; Wed, 11 Oct 2023 06:33:39 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4066692ad35so62488245e9.1 for ; Wed, 11 Oct 2023 03:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697020414; x=1697625214; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tXtc55X9ZMWnLYaJ7rtH4hZORRpdhmNZnt+nFsO0Mb4=; b=OwSNGSroQ/SYg4FQJi0KsND0GwFE3rVu00zA3JPaM4h28oKvsO578klV8VMyEAgF6y bmosV9vyXMSoJZ5cn68DkJq3OYf194UlzdESClr3c1N338/jECa2eexDcU+tQXFFF2s7 JcQk781bbIjqQgQmcRZ24iUTRXCn2ZmsHP0v5DBJdIr4kGqg9U++vsrpb0aeL6IIate7 v08dBOzt/wamyFON4vSpgVKzUsjFLlzAAZwwU8Szi9zXu6JwFtTx2tf9DjRpL0qSqnYV W3Ai7DZyFrR6YdNF+oMMCSPGk/6lz5ltyedctFkBq7Jm87G8eCPA9V/vzfZNXTmWDDx/ mdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697020414; x=1697625214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tXtc55X9ZMWnLYaJ7rtH4hZORRpdhmNZnt+nFsO0Mb4=; b=e2eLKPqtK05a0UubmwNOWk3w6l3CiKUdWoFehXkXbyeXjzIBIc/xOJwE2JDu/0Jits 90jzpPX2r1I/uSAb5q/Nd9uykJ472jF8T1Wxl5+bFZgVcR/uGR1w2Iloq2bCTnhfdd7G kJsfrB91aLZeiwFeG6GXhDbPomeuH/AXDcyGxL/aRWYkpfEOp8H7e8vqRKUxermz18Vf zt4O3kRM9VdyU7G+fB9jk5RCibRtDUH5oYwYajxnt43bZ4tUMvLrFTRvZmfnSc9a/Bpj iVVSlR/ckqys7YoB7I0ldxF+os0tgV3bWng2+OIGglQ5ulBcr/ALpj2JPuJwFfcq8Lb8 +JeA== X-Gm-Message-State: AOJu0YzeyOZhmRcH9B/u7EwU97f2MxxH8l0rnXpwib5RQYTqTVOSthAt i1cgEAv0QOkxsA3qiv6OxR626g== X-Received: by 2002:a05:6000:24d:b0:32d:84a3:f3fe with SMTP id m13-20020a056000024d00b0032d84a3f3femr1147488wrz.41.1697020414270; Wed, 11 Oct 2023 03:33:34 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id s13-20020adfeccd000000b003198a9d758dsm15094918wro.78.2023.10.11.03.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 03:33:32 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 367431FFBB; Wed, 11 Oct 2023 11:33:31 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Akihiko Odaki , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexandre Iooss , Mahmoud Mandour Subject: [PULL 10/25] plugins: Check if vCPU is realized Date: Wed, 11 Oct 2023 11:33:14 +0100 Message-Id: <20231011103329.670525-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231011103329.670525-1-alex.bennee@linaro.org> References: <20231011103329.670525-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki The created member of CPUState tells if the vCPU thread is started, and will be always false for the user space emulation that manages threads independently. Use the realized member of DeviceState, which is valid for both of the system and user space emulation. Fixes: 54cb65d858 ("plugin: add core code") Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-4-akihiko.odaki@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-11-alex.bennee@linaro.org> diff --git a/plugins/core.c b/plugins/core.c index 3c4e26c7ed..fcd33a2bff 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -64,7 +64,7 @@ static void plugin_cpu_update__locked(gpointer k, gpointer v, gpointer udata) CPUState *cpu = container_of(k, CPUState, cpu_index); run_on_cpu_data mask = RUN_ON_CPU_HOST_ULONG(*plugin.mask); - if (cpu->created) { + if (DEVICE(cpu)->realized) { async_run_on_cpu(cpu, plugin_cpu_update__async, mask); } else { plugin_cpu_update__async(cpu, mask);