From patchwork Mon Oct 9 16:40:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 731002 Delivered-To: patch@linaro.org Received: by 2002:a5d:574c:0:b0:31d:da82:a3b4 with SMTP id q12csp1311404wrw; Mon, 9 Oct 2023 09:44:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNbRFJfHM7JjcqVn9iA6flOT5BNnT3Vr4nebTDb6qyOLL1R6q6Z2IHyswvYpA2kMYm63y4 X-Received: by 2002:a0c:d98a:0:b0:66a:f5f3:87ed with SMTP id y10-20020a0cd98a000000b0066af5f387edmr8882668qvj.3.1696869847417; Mon, 09 Oct 2023 09:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696869847; cv=none; d=google.com; s=arc-20160816; b=itlPW3+1djyPUfc2MTtoSzAmeJgj5R253jtScOu+w3kzpmFAJWfSidAknJF9Jtrkzo EjddADvnPH87Qyn7SSdpjJu39oXMRxZQWkdtIyd8Usuq88MxyhzL+nnZ99pMNb1WG6as uhAnPHezYxd6hbrOvCt62B1hoiFyTOgSZcETnohDGk67hurNU4olWtQd8wb6u6kHNJS+ 3bAro3tt1FMWBC/J4Z41ebPJkEocJmLQ/T9RV/bBEy3F+KIchd93yRcVdWPFfUQBSwTB HUparqbC6pSPz7MOkAWpSD098LCWGEQx9J9P2Y17+vlPB4zjL8QITZxu5WPYujWdUk5u 29Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LG2NkApx4TVidHIbE463d0CCb2MX5UuJ0CO2x3DfXcM=; fh=FL21b9FDJBPKO4Cw1gBqBPIr8gb5CEXpVKTgM6hLIl8=; b=col4s9Npr6YY4/XoXJ7EWUfk3Oaj4qiQbtd4IMIBLR6X2h6mJuydYgr5/arjc+7kQk qJkEHrw6z7HmnRHFv+wFcRvMceBC/aCV6Fm77DDAtdgLeAZaZvkyamclC0DPd1pWCUlP VaOLXjyAQb41+XaLPzDsytZU0+T0nmClS0p356X1lKm5Dqo1qdi/vV2gSg8IizcxYKXv Gwigweqs6k/xy2oAet29dVPmypDauYG+hrp/z1BgNumbOmWXB51ao95hxb8CVMvNZZDU +CobknQsbgym3IBV4rPgjWs88xhPsQlvZnLY/PQYA0IVVhO3oxwFtQWTHRtpT+DMZQvv GZvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VHPcBfdx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g19-20020a0cdf13000000b00658b21e541csi6191138qvl.174.2023.10.09.09.44.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Oct 2023 09:44:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VHPcBfdx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qptLy-0000a0-TT; Mon, 09 Oct 2023 12:43:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qptK5-0005Pi-0x for qemu-devel@nongnu.org; Mon, 09 Oct 2023 12:41:38 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qptJh-0001Yc-Un for qemu-devel@nongnu.org; Mon, 09 Oct 2023 12:41:36 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4064867903cso47824485e9.2 for ; Mon, 09 Oct 2023 09:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696869671; x=1697474471; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LG2NkApx4TVidHIbE463d0CCb2MX5UuJ0CO2x3DfXcM=; b=VHPcBfdx2L7ZbR58IPP7pSCrU/Nmybk9SLs6Ki0CEKuojLFfqOlYL23ZzZ7tqGQbCW /MAHfJugVKRxbeZzuWfGerDQtP/fZpMYvdS++h59+ZPRUcvPIBmza4MOvqRyPBBNkSCh UC/nPXejCTfGMetaocCKw4A1R44WBByHO+619EbgFZjtu39O8wORv1KnODf8jBXZ3P5X QTbVPCzmz3Pa3VNam5EVh2o6NdkKxMq07n6nL3EG4PugSXeHml9GhrnCJvEE0R1UNKPD hqxgrX32/MjK1oAuDZLjtpMVKQySnODoG2xnvm4t1YyZELgWdmvFeyXV1fGZu+IsFIiI xKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696869671; x=1697474471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LG2NkApx4TVidHIbE463d0CCb2MX5UuJ0CO2x3DfXcM=; b=MhiJ5wyNLt1VVIYURO+bLuhYbKbBFnMaGk+EZSrMJnQhd1QGsdqd5356228s88OkGL LfcaZlIhpEv1ExCYbXgwGLihKTIXX7VrIIZpbex5uC2K28Pp+1Yk75faZHQGtjPQsKUo sY+axYLZi/lJqYRBYUTMMZ4o2NZriaHuxueFOnyuLr1RwZHC6IGHl4MFm33mjvzcjlVK gjTepVlQf+45h/fmOkPj9D+DUNL9rrTSpT4Cq5t7Vb2ssMnkeuCOtAjcH5pAkaZEdMky w5zJvdvO9ElN01oqPY8VoOzmpTgnj4AHQMIukd64OVGDoT2uU2MzVndZLH5sBOQMZWUd Nqbg== X-Gm-Message-State: AOJu0Yw7IW6QLuA/hM5G+lTZq9vvGzNVMVVHxXfq9yblu0+PzskzhWtJ jC3dKQTVeijjBtQEXbSrAE5nMA== X-Received: by 2002:a1c:7218:0:b0:401:d803:6243 with SMTP id n24-20020a1c7218000000b00401d8036243mr13668682wmc.32.1696869671310; Mon, 09 Oct 2023 09:41:11 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id i2-20020a05600c290200b004063d8b43e7sm13939902wmd.48.2023.10.09.09.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 09:41:07 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2BB891FFC3; Mon, 9 Oct 2023 17:41:06 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Xiaojuan Yang , =?utf-8?q?C=C3=A9dric_Le_Goater?= , =?utf-8?q?Alex_Benn=C3=A9?= =?utf-8?q?e?= , Bastian Koppelmann , Brad Smith , Radoslaw Biernacki , David Hildenbrand , Cleber Rosa , Ilya Leoshkevich , qemu-riscv@nongnu.org, Daniel Henrique Barboza , Alexandre Iooss , Nicholas Piggin , Bin Meng , Leif Lindholm , Paolo Bonzini , Eduardo Habkost , Alistair Francis , qemu-ppc@nongnu.org, John Snow , Liu Zhiwei , qemu-arm@nongnu.org, Wainer dos Santos Moschetta , Palmer Dabbelt , Peter Maydell , Yanan Wang , Weiwei Li , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , Beraldo Leal , Yoshinori Sato , Mahmoud Mandour , Richard Henderson , Song Gao , Marcin Juszkiewicz , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Akihiko Odaki Subject: [PATCH 09/25] gdbstub: Fix target.xml response Date: Mon, 9 Oct 2023 17:40:48 +0100 Message-Id: <20231009164104.369749-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009164104.369749-1-alex.bennee@linaro.org> References: <20231009164104.369749-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki It was failing to return target.xml after the first request. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-3-akihiko.odaki@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 8eea21450c..4f3762fccf 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -396,8 +396,8 @@ static const char *get_feature_xml(const char *p, const char **newp, g_string_append(xml, ""); process->target_xml = g_string_free(xml, false); - return process->target_xml; } + return process->target_xml; } /* Is it dynamically generated by the target? */ if (cc->gdb_get_dynamic_xml) {