From patchwork Fri Sep 29 08:50:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 727616 Delivered-To: patch@linaro.org Received: by 2002:a5d:60c8:0:b0:31d:da82:a3b4 with SMTP id x8csp333084wrt; Fri, 29 Sep 2023 01:56:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGjB18l7bBKfF5zJnyPaegwHoKjgwc8KLJlhyWBrSgZtDwdyUn2ohMxUx9ITIHQtCWEpH6 X-Received: by 2002:a05:620a:3913:b0:773:b2b1:6f6a with SMTP id qr19-20020a05620a391300b00773b2b16f6amr3696763qkn.59.1695977778298; Fri, 29 Sep 2023 01:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695977778; cv=none; d=google.com; s=arc-20160816; b=TzGK3in/wzG/GdR7LjnOEPGVgLepSGzQ6WiW2zt+n2oi4ogORTzHxqJhKO+LZ1cE9Y fZOrSgJHb0GG4rfUYn1s6P/OxZ+DdcSChyo1e0L9udkzVxxqFqhpGEvyBsYPJ2p9l98j KuyfRgzGzbQomzDRoki4/zf1AekrnNCkMOY+/zXYGqWyR2TwamW8M/YRamlYUURqaiAT QtCE+s70lsfcP9UUPht29gf8DHlVuZftNqluopT5YqTaBSZQYuYjA0zsVXDRSwxmr3ms BjoEh/TMNz01Hvo5hX3isEteZVHG441jFsE8leis+dyxecf4oCnHiITx6SBq7rHf4DEQ Cjng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u+gXFHyiOssKuws26aj3snZMvL7ARvGkD3IT5khP5Gs=; fh=4BNfS75s1GAZLJLea+sTLx/vsXqv6uUvqeHQnw8gEeM=; b=XujqmXiD8YwYhSzgDbnrxDL72sYJqwsevAH4CnP1yyWNk5tNOSx/otm5jZSZRhr/s+ syGkTS34hoM7Irnhz/5sVr1Vc9VFgLPieMp4lcgVQbXiopxUJjOtXfRzZSbyPK3OhQWG EF/S26nwNVAWEkEzwWmWN8ZKSAJMBHSzbo9Z14ypzyL6OO7V+KCuRzFnas+6ItbcGzZT Pt61mMTSgsyPp6d4LJdSADHJEL2M4He/YxHElh5Vn6QhUDmMZIQUjQj5foaTcAch+Vo1 ChpU38M2HxsC7Jnszp3VovBJh+DMDMZlyolR2Rxmj/886I3tzcsEzvnrsYLCdTBiyWfH M/1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IRmI0hMb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id re24-20020a05620a8e1800b0076daeaded07si9556427qkn.74.2023.09.29.01.56.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Sep 2023 01:56:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IRmI0hMb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qm9Dc-0005C2-QK; Fri, 29 Sep 2023 04:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9DQ-000507-Ng for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:51:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9DA-0005bl-LT for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695977459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u+gXFHyiOssKuws26aj3snZMvL7ARvGkD3IT5khP5Gs=; b=IRmI0hMbijL9PGvPcLbqExV4cHXf0wofA0Frn+Yhh6PBq0U3Rsgrz00pFwRJly/OwXEvh7 Uqz4wSt3KlFVzTq7aV5LfYzfR2H+hLOTI3bAxf0XklCKGNsXyv3ry+o20pfH3P0CmWrXOM CDAHnh/8wPw4Ie8P8Mtj3rrMVzkYIdE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-687-6k7aB4tCOci4Zb3cCu60Lw-1; Fri, 29 Sep 2023 04:50:56 -0400 X-MC-Unique: 6k7aB4tCOci4Zb3cCu60Lw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED0F03806737; Fri, 29 Sep 2023 08:50:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1AE0C15BB8; Fri, 29 Sep 2023 08:50:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7512621E6916; Fri, 29 Sep 2023 10:50:53 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Bastian Koppelmann Subject: [PULL 13/56] target/tricore: Clean up local variable shadowing Date: Fri, 29 Sep 2023 10:50:10 +0200 Message-ID: <20230929085053.2789105-14-armbru@redhat.com> In-Reply-To: <20230929085053.2789105-1-armbru@redhat.com> References: <20230929085053.2789105-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Fix: target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows a previous local [-Wshadow=compatible-local] 5016 | TCGv temp = tcg_constant_i32(const9); | ^~~~ target/tricore/translate.c:4958:10: note: shadowed declaration is here 4958 | TCGv temp; | ^~~~ Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20230904161235.84651-7-philmd@linaro.org> Reviewed-by: Bastian Koppelmann Signed-off-by: Markus Armbruster --- target/tricore/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 6ae5ccbf72..9ca211b2a8 100644 --- a/target/tricore/translate.c +++ b/target/tricore/translate.c @@ -4962,8 +4962,6 @@ static void decode_rc_logical_shift(DisasContext *ctx) const9 = MASK_OP_RC_CONST9(ctx->opcode); op2 = MASK_OP_RC_OP2(ctx->opcode); - temp = tcg_temp_new(); - switch (op2) { case OPC2_32_RC_AND: tcg_gen_andi_tl(cpu_gpr_d[r2], cpu_gpr_d[r1], const9); @@ -4972,10 +4970,12 @@ static void decode_rc_logical_shift(DisasContext *ctx) tcg_gen_andi_tl(cpu_gpr_d[r2], cpu_gpr_d[r1], ~const9); break; case OPC2_32_RC_NAND: + temp = tcg_temp_new(); tcg_gen_movi_tl(temp, const9); tcg_gen_nand_tl(cpu_gpr_d[r2], cpu_gpr_d[r1], temp); break; case OPC2_32_RC_NOR: + temp = tcg_temp_new(); tcg_gen_movi_tl(temp, const9); tcg_gen_nor_tl(cpu_gpr_d[r2], cpu_gpr_d[r1], temp); break; @@ -5013,7 +5013,7 @@ static void decode_rc_logical_shift(DisasContext *ctx) break; case OPC2_32_RC_SHUFFLE: if (has_feature(ctx, TRICORE_FEATURE_162)) { - TCGv temp = tcg_constant_i32(const9); + temp = tcg_constant_i32(const9); gen_helper_shuffle(cpu_gpr_d[r2], cpu_gpr_d[r1], temp); } else { generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);