From patchwork Thu Sep 28 19:41:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 727098 Delivered-To: patch@linaro.org Received: by 2002:a5d:60c8:0:b0:31d:da82:a3b4 with SMTP id x8csp94260wrt; Thu, 28 Sep 2023 12:42:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0fHZs5TIq1jA1aYkqjQ8KaIpGCLVOQdU9wJBzN5WMN2p/gqZqnuzdLeJtivaqCJWe6g5P X-Received: by 2002:ac8:59d4:0:b0:417:fe9c:6dd4 with SMTP id f20-20020ac859d4000000b00417fe9c6dd4mr2346502qtf.17.1695930168126; Thu, 28 Sep 2023 12:42:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695930168; cv=none; d=google.com; s=arc-20160816; b=JQENOrfxhFVzBRMq32I+Tn6N84yjHEhj87o0ZmxCGz/bDvdqbgXO5ABm8nf3edPJ23 S9IcEnJqupd6q/mQL91Q5rB+tv2qCHSuYEMfMJd4QKRhPwNIArYL1AZrMxrBxPcrLYIk O0l4S2/guCFcwqGS0YOFUL+DwQL/AHOz1IlXohQcnlXm0sS4CVFezOIrDSVx4enQBEvO ZsVa9wOX35M1lW/lybUMNJQjs8rVrnx/e9n3aF8aoaumXS+cQ2wYOYQF9j+2huBRMSf8 cmKy9wk7ZoRiAa7JMqS2KFax7+xMY+A/77uxt+yRV+38MpxtNDjXdqQaLarJN2G/gLIj 5QEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ujd1qr2cxmKKRJwbJe5azKA+HhGSxwUyFcBo+rqU3b0=; fh=kQadAhxV42GJ3cd2VUw1RyURv/zJQGvmUdF7iLEVTtc=; b=sKPCFLjMAkJURRT8/a1VMKQsonqYSnpUqOGJOI2xzsub2N/lOXTjGEfoUrcEJYAKRv 02A6743mXnHgxrql7LZu6VYiq0r0FV0rf7RWfPhvoWJu7aF30j42Gvdb4T5Em4r2V2My MCjvzcu2rP7J5vs0hCJNg1svIPFW5Kxo4wVBel/7BRMzze/EFGXt3NeJm8Gmtd4nAz0x sgJWP7urkNTP1+laG5MzhLNw7zAiCy81YflloJYdLM2ACrcubeqU2hphNViX0MXaA5Vn GvLao/fJB2mZ0ivm8iGkewEMuEn4iiVY09haIVQupxf5So2oQmjsiSuYONurokzfcjoV 32eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cmV4NsvX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b4-20020ac85bc4000000b0040694778c33si6132680qtb.32.2023.09.28.12.42.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Sep 2023 12:42:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cmV4NsvX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlwth-0007vn-M1; Thu, 28 Sep 2023 15:42:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlwtg-0007v5-OE for qemu-devel@nongnu.org; Thu, 28 Sep 2023 15:42:04 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlwtc-0007wN-Rt for qemu-devel@nongnu.org; Thu, 28 Sep 2023 15:42:04 -0400 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-690f7bf73ddso10547874b3a.2 for ; Thu, 28 Sep 2023 12:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695930119; x=1696534919; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ujd1qr2cxmKKRJwbJe5azKA+HhGSxwUyFcBo+rqU3b0=; b=cmV4NsvXiGgLTljIM7wkEpTpK2Z9OsvPYWoGK2qFUL3ncyjfHC8vE8vnFrV30+Lym/ UvYXzuG8q4g6Gxq1tSYf8cpwQjcg5Yp0xWNxc++v4g+vuwNqZSSTxfHPHehvpW/Hx8NX XlqRZA7r6TE/eH6JrVhiuBh8wkzHhL0Jaj8cEXMzxU4GCABJNZZ48kvl9QoU15MAj1zH KT/llk5TWB7jY7PHlkzZ4xe50UGZDfvg7Ibv8rk7yXmxKigvDUryAY20shUoEkt16EDo NXQ0KPrA85jnEAgEVoJ9VttLfL9ZPoCNbc/TRaaBqzLDSIUJGqqv2YWxK5CTYcDy9mxF JlTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695930119; x=1696534919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ujd1qr2cxmKKRJwbJe5azKA+HhGSxwUyFcBo+rqU3b0=; b=t/h3y//F8Gw79DDTdkXHJ0wiwLvYvPIxBIDEADD9JfXoxrjGkhRH+tP8gvepXs9vVG LP0+VsN15L+NcztOaRHv+mKe7S4dPwG0Y2afTkBjqPAh4pJY69MfwYGnlOG3N4a6K+JO EYYOjQcaCkJFFiR+zxWR0dsj4L2lssmdYTp+DfZgytwhfZYIo4082osNZc8CwTdRYZBp 1ga25FmVeHSUbVG+B5EUXY8sxOP4y7Dwb0ZzaJySwJsgABrCForflHkeSuO0L18RF/dw FCjsDU3t15gPgXAO8Mpy3FMgmpKmnaGiLm9qkdgGylyy5R9leaFAxiTgfCmFqRGi1b5R 74EQ== X-Gm-Message-State: AOJu0YxnpzzxCkbd5hgrBoi+Q5RnMmzj6i583tNQBQB58uDQpHL5cFfC yVFKJtaWpYmGOUMzP67td8eLvyWEvd3fRl8oBco= X-Received: by 2002:a05:6a20:1609:b0:14b:887a:6d70 with SMTP id l9-20020a056a20160900b0014b887a6d70mr2012330pzj.15.1695930119236; Thu, 28 Sep 2023 12:41:59 -0700 (PDT) Received: from stoup.. ([71.212.131.115]) by smtp.gmail.com with ESMTPSA id x23-20020a170902821700b001b80d399730sm15273450pln.242.2023.09.28.12.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 12:41:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 1/6] accel/tcg: Avoid load of icount_decr if unused Date: Thu, 28 Sep 2023 12:41:51 -0700 Message-Id: <20230928194156.237351-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230928194156.237351-1-richard.henderson@linaro.org> References: <20230928194156.237351-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org With CF_NOIRQ and without !CF_USE_ICOUNT, the load isn't used. Avoid emitting it. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/translator.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 1a6a5448c8..a3983019a5 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -49,12 +49,15 @@ bool translator_io_start(DisasContextBase *db) static TCGOp *gen_tb_start(uint32_t cflags) { - TCGv_i32 count = tcg_temp_new_i32(); + TCGv_i32 count = NULL; TCGOp *icount_start_insn = NULL; - tcg_gen_ld_i32(count, cpu_env, - offsetof(ArchCPU, neg.icount_decr.u32) - - offsetof(ArchCPU, env)); + if ((cflags & CF_USE_ICOUNT) || !(cflags & CF_NOIRQ)) { + count = tcg_temp_new_i32(); + tcg_gen_ld_i32(count, cpu_env, + offsetof(ArchCPU, neg.icount_decr.u32) - + offsetof(ArchCPU, env)); + } if (cflags & CF_USE_ICOUNT) { /*