From patchwork Mon Sep 25 14:48:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 726018 Delivered-To: patch@linaro.org Received: by 2002:adf:ea87:0:b0:31d:da82:a3b4 with SMTP id s7csp2432702wrm; Mon, 25 Sep 2023 07:53:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXIGpYTc8JCYw4JN35iHg5zezuC/WzTOzA2oJff0LHRc7xo0BxPa8JalqQeKlsA2yCyMwS X-Received: by 2002:a05:6122:45aa:b0:49a:4de3:e290 with SMTP id de42-20020a05612245aa00b0049a4de3e290mr1435217vkb.8.1695653601213; Mon, 25 Sep 2023 07:53:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695653601; cv=none; d=google.com; s=arc-20160816; b=wRiSSukk46hhE3ufifmp9abR/W3rwf5YJcpa+x/OUBVOseqJLhr0J7+DOrrIYv6wMf yyHBd8XqYHyyBuIIZ5MtJ9+Yi9Dkd2QoSrgMOiVdFjESioMSsgUkxE5RJnwUe2bke8QZ ZQqCoyFQx7zTIiMkoAODiupkRm86q5n6xksk2aD0n4akxxBQVuPqCUiMtcugkoeq9kS2 qihZoZrWbPB26A64Q+MWRUqlTBSMj30HH17KY8dfY5vGEGUSOsCJLYbFdGeN95FFOqnn stWKclfBasXD4i+iSbU0my44YdVYM6yiZ/qHPLw2wJC4Wcn6boGfqITAlF7PFDtw+GJX veqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DlEhphEtX0KtQL/e4ae/jun4tEwNOtAavPJ6o58muzg=; fh=mlkRjkvEMCBvV2NmkuZ9E+MTYOKspqfxSPvD1d2xG14=; b=X3b6raPWE5OP1jHkXuKOtTq0xdGorEUxwZ2WO4Nd0x/HBYyoz/AMPTnAI8wFaza7MX CZqIAhBG43kO8gCg03V34/8aU/r2H72aIiNlXp+ZMlccj03y8CwSua4ix9ersUk9oPU2 l7rCrdGuQm1pl439gnqAjy2u0Hit17/GgNCKM+q9WdHpg8ri/SV8n9AZ0zrDHbrlFDg9 iiP0Q4vOf/+Ib7auCCBkZ5acd2RDC719f2oJtsEXGttwJUwBIwlU8m7C0sB2YU1ZtjvW ipIAe5XAHtku4Ic+Z+BQvKVcb7UpqzXZ902gLnguFIuEFCcxpSSC21OqHERYyMHdavyM g7dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o/nUgvjA"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w3-20020a05622a134300b00417aff48cf5si6356808qtk.693.2023.09.25.07.53.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Sep 2023 07:53:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o/nUgvjA"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkmtl-0001PT-7R; Mon, 25 Sep 2023 10:49:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkmtf-0001Br-H6 for qemu-devel@nongnu.org; Mon, 25 Sep 2023 10:49:16 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkmtR-0008HY-OA for qemu-devel@nongnu.org; Mon, 25 Sep 2023 10:49:15 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40528376459so66392365e9.3 for ; Mon, 25 Sep 2023 07:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695653340; x=1696258140; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DlEhphEtX0KtQL/e4ae/jun4tEwNOtAavPJ6o58muzg=; b=o/nUgvjAXOP8v2n0hbHEcBWRjMZI4980/xMJyrB9IzV3Mpu9/kPkYsNFQf4Z2f392l CN6cFmmPNhIinKQk3Yr4YOHoht0Ps6NhtxjZzXIXRsmP08/hTWudXOsYZ+VE33/Pd1aO rRWPI/GxAbNBTkZ03tV0cKH2Pio6ybNz8y2HIq11I0cpNRAlp4FtPgdfdjq8WqVp/fuj bXO5VO/0ZOZ9/eJ/ObccQK4YPHB6S9qWEna7ID+TQMubJ5eu8geo8I/Ub8tzStHuzb6p rdO/va++RBpbZxq5MDA4Cpwee1U/mDcgbYYQVF7ulB5NMvVa50aBp4Mwus4M1Bg4UQYg mV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695653340; x=1696258140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DlEhphEtX0KtQL/e4ae/jun4tEwNOtAavPJ6o58muzg=; b=sXw/FCcam5T7do1LbPSN/mDyRZIzvD1+i+Y49EH9IcOWkKh1F6uw9C63t+yNgazD59 IeSCKI1Ut2Tk10qZTbaO9slU8DT7Y8F4SPOLvy77m0OgfGy16e648VQ6qTDEaDoqTGr7 RhN7r5K+FxiyJU6N24+WDOcUM6ZXyFbGZtx+/jWSATmgTSZaKGMPnvgTI6qRMwi3nD2j IhH0ij6pyY7YHcU5L2GnGUbShvC0ZIu9vRhfU9Unio3mmz21/iuZOCPKUmELJKpfUOcL ztUwzBeGXIe2BskOraMQJg66BQ5+QyBvieaQgjO96uA/C/pZE5QkKE8/dMMWkoQHcozS qgKw== X-Gm-Message-State: AOJu0Yx52DJ+rkCry0tSPLyywdQlWmsquKAFjcFpfOq4H2UGx01AwBpV CeZREWaEkeMuy9YefAioSNCOfg== X-Received: by 2002:a05:600c:22cd:b0:401:b493:f7c1 with SMTP id 13-20020a05600c22cd00b00401b493f7c1mr5917888wmg.35.1695653340198; Mon, 25 Sep 2023 07:49:00 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id y23-20020a05600c365700b003fefe70ec9csm15207988wmq.10.2023.09.25.07.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 07:48:57 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 347651FFC3; Mon, 25 Sep 2023 15:48:56 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alistair Francis , =?utf-8?q?C=C3=A9dric_Le_Go?= =?utf-8?q?ater?= , Marcin Juszkiewicz , John Snow , libvir-list@redhat.com, =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , qemu-s390x@nongnu.org, Song Gao , Daniel Henrique Barboza , Marcel Apfelbaum , Bastian Koppelmann , Liu Zhiwei , Weiwei Li , Nicholas Piggin , Radoslaw Biernacki , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Cleber Rosa , Paolo Bonzini , Mahmoud Mandour , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Richard Henderson , Bin Meng , Alexandre Iooss , Xiaojuan Yang , qemu-ppc@nongnu.org, David Hildenbrand , =?utf-8?q?Alex_Benn=C3=A9e?= , Yanan Wang , Peter Maydell , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Palmer Dabbelt , Ilya Leoshkevich , Laurent Vivier , Yoshinori Sato , Leif Lindholm , Beraldo Leal , Akihiko Odaki Subject: [PATCH 10/31] gdbstub: Fix target.xml response Date: Mon, 25 Sep 2023 15:48:33 +0100 Message-Id: <20230925144854.1872513-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230925144854.1872513-1-alex.bennee@linaro.org> References: <20230925144854.1872513-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki It was failing to return target.xml after the first request. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-3-akihiko.odaki@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 349d348c7b..384191bcb0 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -396,8 +396,8 @@ static const char *get_feature_xml(const char *p, const char **newp, g_string_append(xml, ""); process->target_xml = g_string_free(xml, false); - return process->target_xml; } + return process->target_xml; } /* Is it dynamically generated by the target? */ if (cc->gdb_get_dynamic_xml) {