| Message ID | 20230914185718.76241-4-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | accel/tcg: Make more files target agnostic (& exec/ housekeeping) | expand |
On 14/09/23, Philippe Mathieu-Daudé wrote: > In commit 00c9a5c2c3 ("accel/tcg: Restrict 'qapi-commands-machine.h' > to system emulation") we moved the definition to accel/tcg/ which is > where this function is called. No need to expose it outside. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > accel/tcg/internal.h | 2 ++ > include/exec/cpu-all.h | 5 ----- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h > index e8cbbde581..cd6b9eb7f0 100644 > --- a/accel/tcg/internal.h > +++ b/accel/tcg/internal.h > @@ -102,6 +102,8 @@ static inline bool cpu_in_serial_context(CPUState *cs) > extern int64_t max_delay; > extern int64_t max_advance; > > +void dump_exec_info(GString *buf); > + > extern bool one_insn_per_tb; > > /** > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index 71efc2d404..221ada2b6d 100644 > --- a/include/exec/cpu-all.h > +++ b/include/exec/cpu-all.h > @@ -406,11 +406,6 @@ static inline bool tlb_hit(uint64_t tlb_addr, vaddr addr) > return tlb_hit_page(tlb_addr, addr & TARGET_PAGE_MASK); > } > > -#ifdef CONFIG_TCG > -/* accel/tcg/translate-all.c */ > -void dump_exec_info(GString *buf); > -#endif /* CONFIG_TCG */ > - > #endif /* !CONFIG_USER_ONLY */ > > /* accel/tcg/cpu-exec.c */ > -- > 2.41.0 > Reviewed-by: Anton Johansson <anjo@rev.ng>
diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h index e8cbbde581..cd6b9eb7f0 100644 --- a/accel/tcg/internal.h +++ b/accel/tcg/internal.h @@ -102,6 +102,8 @@ static inline bool cpu_in_serial_context(CPUState *cs) extern int64_t max_delay; extern int64_t max_advance; +void dump_exec_info(GString *buf); + extern bool one_insn_per_tb; /** diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 71efc2d404..221ada2b6d 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -406,11 +406,6 @@ static inline bool tlb_hit(uint64_t tlb_addr, vaddr addr) return tlb_hit_page(tlb_addr, addr & TARGET_PAGE_MASK); } -#ifdef CONFIG_TCG -/* accel/tcg/translate-all.c */ -void dump_exec_info(GString *buf); -#endif /* CONFIG_TCG */ - #endif /* !CONFIG_USER_ONLY */ /* accel/tcg/cpu-exec.c */
In commit 00c9a5c2c3 ("accel/tcg: Restrict 'qapi-commands-machine.h' to system emulation") we moved the definition to accel/tcg/ which is where this function is called. No need to expose it outside. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- accel/tcg/internal.h | 2 ++ include/exec/cpu-all.h | 5 ----- 2 files changed, 2 insertions(+), 5 deletions(-)