From patchwork Mon Jul 10 17:50:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 701052 Delivered-To: patch@linaro.org Received: by 2002:adf:fcc5:0:0:0:0:0 with SMTP id f5csp5305564wrs; Mon, 10 Jul 2023 10:54:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlHz8y0FHLHAY5wCIFU63hphJrdbWxdjORRdh+NNId82ZhTIB6/d/dK2JB4jB9+d+Kv6BrLL X-Received: by 2002:ac8:7f0f:0:b0:3fd:e1cf:627d with SMTP id f15-20020ac87f0f000000b003fde1cf627dmr15687310qtk.21.1689011674033; Mon, 10 Jul 2023 10:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689011674; cv=none; d=google.com; s=arc-20160816; b=TbDf45UTcnVlun66rwiaF+ahabxrjAa2JtrZenC2lOGjxW9PL6qpbrrGT+YDFQ5VPB CgUKylJFXd3dS6FAQtexUsVlLJGoBp8jIs9y0vcQGNZLnBg4F3s6/MqDhEbxvWgZuK9L 7cBV3Ufh4DnJdJMe+Ofxh7qRwohK5CulnJY2LNPSwg53Roclaf5M2/YJXsWPgsq6QQNr hGU3SabpjyCsgUdCOmLxxwmQFbwGquzI9wXie9klzWFeX1pHqZ+g6GB1AZBjvHdnapCE e3lj75hb14REVuv0B5WOBxbkYBFg5vtzOKajogDZzklcGVQ/7iBsXoZnvIQ1i3YJzpIt zLTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3N6F5aMrOUR9NN4jQ1KnUxsit6lU8XCjQJ4gcKL1MRw=; fh=4TWVGTMFk+XB48cTX7H3L2FEUZf3X6lSQ5h15kr1III=; b=U6HWQeTEH4fiGQB4U0zADf3FZaV1q1JXN27n9/mpdzbBEm7xaHU77mx5wpzCcwXlHd h+cA1PhTWRgsrXRyy5Mg7R3SE7iT6U6b8TcNhdPDXqU4IUQCuxHBFSoLVvqOh8zoecSn uMvtYQGXoA5A8pQpf25BRYh0vE3wH3B2tGq/2vIKZeUsyuXK6Rb+RCRgXV0qX/aZpmNe 5TtcPzRSDECzxaX2DGIs8LC90uRNixflNtU/icHsq5gnLbQRDnpWeuNIKMw4KhLvf+3e JkWwyE6fYm9PrwH39CoIFh9lgjdD0HOd+233WiMoV5DCEVMSMv1wlG5/jIJt83/y1peg kIDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V6m1EVPS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n10-20020ac85a0a000000b00403b1e68f33si133514qta.169.2023.07.10.10.54.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jul 2023 10:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=V6m1EVPS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIv2x-000142-OA; Mon, 10 Jul 2023 13:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIv2i-0000yK-Iy for qemu-devel@nongnu.org; Mon, 10 Jul 2023 13:51:26 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIv2f-000070-Oc for qemu-devel@nongnu.org; Mon, 10 Jul 2023 13:51:24 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3159da54e95so1035829f8f.3 for ; Mon, 10 Jul 2023 10:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689011472; x=1691603472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3N6F5aMrOUR9NN4jQ1KnUxsit6lU8XCjQJ4gcKL1MRw=; b=V6m1EVPSeqCVWicO+/rHjnCcNpkhEL/iqv2RogAXrTB1U7YrydIjf4GrICKB95LUt6 dmVndOyKeDp9ipw3v14498l33bPCm18TdAV8oJWPCi9dIma6Fzsmje4pWLuZ9RA1vUQt hoH80iBQYE48fJzeou89Wpv28rCzjlWI7V+affJwiV9sdxBF8Kwgr65ZBePTaUsXtzBS LFmTrOxCTe79GlNIc0732nFXNZHb7UYGoaE/nYjlBX40LNxDrsUfWx8rVPxy2s4nWbT+ SqMREOy02GAhdeHXABjkj7SI84cNaYIKdV8iauriivt6oBlRo6k9VPxPBYym7qw2j8VF pzKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689011472; x=1691603472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3N6F5aMrOUR9NN4jQ1KnUxsit6lU8XCjQJ4gcKL1MRw=; b=UQDpQMKu7TaEW5JjG7c4q75MsGZP2A9oDZZ/EtRMhbLNKIAKSN6ZFfUVQRA9PiSUCJ ArhIXB7i+Xih/T/23pWjwdcw2EVH1CeMKtqKqcnamQH2dEdxAgg9bmx3YGtUEs2sWzvF ++KVEJNsAza+Dr80HDn91mR4sWvOd/0gQJxgAwkiEFI4WXz2opNCP6VfpQSWuOf5CdvI 2+hOZqMkPvvkPv12KfnRMGTLyCFfyXf5yEYbSTS7Z3/SOh1KwEhh2kARM4CFSI2XSCNP OVMowdY8Sa3zbBTdOSc2V5QNLTLJr90HEi838LB8NdC30vnEfz1UtG1TsgNJXsz1sHpb Iw+A== X-Gm-Message-State: ABy/qLY/cFVxP9EKNGLpuHxMjLt5iFpLgZMksp59Rhi9nJLiCYtSkzIf 9vov1LeEopwKGiFWBknFhvK9ReF/lskJTQgAsBECIw== X-Received: by 2002:adf:f602:0:b0:314:34f3:10af with SMTP id t2-20020adff602000000b0031434f310afmr13287777wrp.14.1689011471834; Mon, 10 Jul 2023 10:51:11 -0700 (PDT) Received: from m1x-phil.lan (mst45-h01-176-184-47-225.dsl.sta.abo.bbox.fr. [176.184.47.225]) by smtp.gmail.com with ESMTPSA id f14-20020adfe90e000000b0030647449730sm18811wrm.74.2023.07.10.10.51.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Jul 2023 10:51:11 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell , Evgeny Iakovlev , =?utf-8?q?Alex_Benn=C3=A9e?= , Gavin Shan , Paolo Bonzini , qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 01/11] hw/char/pl011: Restrict MemoryRegionOps implementation access sizes Date: Mon, 10 Jul 2023 19:50:52 +0200 Message-Id: <20230710175102.32429-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230710175102.32429-1-philmd@linaro.org> References: <20230710175102.32429-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The pl011_read() and pl011_write() handlers shift the offset argument by 2, so are implemented on a 32-bit boundary. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/char/pl011.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 77bbc2a982..73f1a3aea2 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -358,6 +358,8 @@ static const MemoryRegionOps pl011_ops = { .read = pl011_read, .write = pl011_write, .endianness = DEVICE_NATIVE_ENDIAN, + .impl.min_access_size = 4, + .impl.max_access_size = 4, }; static bool pl011_clock_needed(void *opaque)