From patchwork Mon Jul 3 13:44:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 698703 Delivered-To: patch@linaro.org Received: by 2002:adf:fcc5:0:0:0:0:0 with SMTP id f5csp1762677wrs; Mon, 3 Jul 2023 06:54:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlHf2duAarHDhT812++rvIg+ulkWFbVVz+MTUOThmgOLn+RSKAV7vqeuMMIS8S3u5C3S70yD X-Received: by 2002:a05:6214:518f:b0:635:dda5:bb88 with SMTP id kl15-20020a056214518f00b00635dda5bb88mr12345247qvb.53.1688392474868; Mon, 03 Jul 2023 06:54:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688392474; cv=none; d=google.com; s=arc-20160816; b=CHXTDSWpe17GsjdoDcD0IOKGnUQbdBnSpixjo1dH0F1qe3UtT7lAo4AY8ue4F0JFuO vBn+MHFxpQUW9yUO4fOIgykdEIqSHDWXYM0plC6EWH116Ew7aPT7Mozr6FKSwAJbGylZ K0KQvnZSoCtB1xRI6yOFfmnQo7Hq8qgThbvrPEXBTqlGlW623cI0FJl1KnRmaS+SSR17 E6INp3AOK8S163/SxHa1BzBi1j78VzqCNrFR/nHC4l2KiTLUc6MpEpCuJXP9Ce91BPV0 P4jAjvrBlrm1jXhnbaAUOTWaMt1SvwicIquRDyAibD4VkKtPRrB++4FWZSxFkkAQjuPf RhxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=26POj3Pp+gIP3un1OHTdCprJFHUE2qyF+wMmQYT3qCc=; fh=Y8TRRYG1QdS8sAgFvmAxFM5bbl6KJN803Tcgs3gYDWs=; b=Wnq7HSOAaPTfxBuGlr+NAr0HthOqlYTqskl2euiNveKDEXPge1FCWJnGDDZpAyGnTk 5npdhP/zoa3AeVQ2sk1Ec9K0o6zFXF6bYcIeOgRvSsRYE8TzStefgPeABkx6A1g6ZxEA 54ciPQvpeeylXSj21Yebs/ZQdlu/GmnV/nGJBz4jLAhuj8ACnMNSXwNmY+ky36dN/V9d eo6TxHbUgWSMoqiemocRAD9CkZjC+e8guS8UNNLL+Pu+jVXD3tmejSk1nVjJEakwlmMG mE8IB6YxLbbnGDdg1HaAO7pJbSMl2byjEMgHV4aasZO1ivYaoEWcudGTEXHwZS9FsD5U KwVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n0XSF8Rc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 8-20020ac84e88000000b003f8682e1200si4411989qtp.13.2023.07.03.06.54.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2023 06:54:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n0XSF8Rc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGJzk-0000ZT-T0; Mon, 03 Jul 2023 09:53:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGJzh-0000UD-5e for qemu-devel@nongnu.org; Mon, 03 Jul 2023 09:53:33 -0400 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGJzf-00081y-5J for qemu-devel@nongnu.org; Mon, 03 Jul 2023 09:53:32 -0400 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fb7dc16ff0so6924531e87.2 for ; Mon, 03 Jul 2023 06:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688392409; x=1690984409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=26POj3Pp+gIP3un1OHTdCprJFHUE2qyF+wMmQYT3qCc=; b=n0XSF8Rck5Et9usUCtaJvF4oZ43rppy52jY2c61oPqRrP3tJtXTeIAfn7bdkVqfPe3 vMMIRxsYYJlfwqo1MdLldWMzRa1lXVPJvzoKIY/H93Lf3PQSYHhkchTlzRaIvoOcA+cW S5x3n4EIyXSPs0E1RszfUAaon/FNCoBF2EJWFzzPTrN9Cm8H07nIGDneM57MxT5fKGA5 2btc96bFB6OmS+gMdzdG/samNINXcLikDocFq3dVeUmNmqhlWMZq7LKQimNimtzrn421 TQTsKbLTh0bTBXPJd3lt04q0AcPKWuwMLvqUFpQqOaVGN2qzf9h5qVZMHPLVzN2riGDl 1O9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688392409; x=1690984409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=26POj3Pp+gIP3un1OHTdCprJFHUE2qyF+wMmQYT3qCc=; b=dClu8EVnRdvVZUvCK0EZ4fFUBbbbSeKvXPMLyyGmHJdS39UL4FMH4MJVALRrp14JM/ ZxfTr5AxJXVcWpRB6jQ/BF52J4NwUvUFvjstZbeb9vJmdAiCf5b3pOfNqJVgHDqoQnxO qQ4aCmruSDX4jyN8RKHjkGVJ5ws1rb49zcayRMY0icSrQT73SB5KtwawfGjxT7hPvmHp 9mRcdHtX/Y9Zim+ClSnSYcLtSfUOmqhMH/eobO1G+AdIE+0wfhw0hvlPkJlYSWGpWPvC 9eHgDQhqKZyYNPSMQIln3Qoha3C941fURoFwIgknfX1z0aPx14FBjUvsO9ZRLPg5hrAl EXTA== X-Gm-Message-State: ABy/qLb1kCDoWuxzGFtWxXUeU3khcEzwplpf8B0vK9yWr81+hhPbGUd/ oivXM55WbXgwLRnl1UeJANHKau0Hg9doeYylHQg= X-Received: by 2002:a05:6512:2107:b0:4f6:6b:a43b with SMTP id q7-20020a056512210700b004f6006ba43bmr6581280lfr.52.1688392409507; Mon, 03 Jul 2023 06:53:29 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id b2-20020adfde02000000b0030c4d8930b1sm25548544wrm.91.2023.07.03.06.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 06:53:28 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 317E61FFD3; Mon, 3 Jul 2023 14:44:31 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, Nicholas Piggin , qemu-stable@nongnu.org, Matheus Tavares Bernardino , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , Taylor Simpson , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PULL 29/38] gdbstub: Permit reverse step/break to provide stop response Date: Mon, 3 Jul 2023 14:44:18 +0100 Message-Id: <20230703134427.1389440-30-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230703134427.1389440-1-alex.bennee@linaro.org> References: <20230703134427.1389440-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Nicholas Piggin The final part of the reverse step and break handling is to bring the machine back to a debug stop state. gdb expects a response. A gdb 'rsi' command hangs forever because the gdbstub filters out the response (also observable with reverse_debugging.py avocado tests). Fix by setting allow_stop_reply for the gdb backward packets. Fixes: 758370052fb ("gdbstub: only send stop-reply packets when allowed to") Cc: qemu-stable@nongnu.org Cc: Matheus Tavares Bernardino Cc: Alex Bennée Cc: Taylor Simpson Signed-off-by: Nicholas Piggin Acked-by: Matheus Tavares Bernardino Message-Id: <20230623035304.279833-1-npiggin@gmail.com> Signed-off-by: Alex Bennée Message-Id: <20230630180423.558337-30-alex.bennee@linaro.org> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index be18568d0a..9496d7b175 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1814,6 +1814,7 @@ static int gdb_handle_packet(const char *line_buf) .handler = handle_backward, .cmd = "b", .cmd_startswith = 1, + .allow_stop_reply = true, .schema = "o0" }; cmd_parser = &backward_cmd_desc;