From patchwork Wed Jun 28 15:52:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 697244 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp4422226wrm; Wed, 28 Jun 2023 08:55:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ77t20xXcflOThjXnGAGyLqdxNOxcX1g4WPNSyhzpPkpKtdhueE1wVjvP4n5BQkO1IIk2CQ X-Received: by 2002:a05:6214:d66:b0:635:f88b:1557 with SMTP id 6-20020a0562140d6600b00635f88b1557mr4621097qvs.19.1687967709956; Wed, 28 Jun 2023 08:55:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687967709; cv=none; d=google.com; s=arc-20160816; b=Eg+f5BInNpRSujhtrj154M85nBh+0lZHM8m3mlEV3ftLebVM5/9U2/+7JMm7qZy7a7 wGCtya+wTiYwLO0wyrwAkQc3Xn0T3xhzs7oPs/StJj+YJkyQVbgCKGi+K2zhzEjGeieR e6LbPOXQ8w6nuq5dVn5nrYqbbnPrJjEqsSgVRksvlDuhxHbdf1UFNh43vMiZjB7CqLpk B79kyMYqKzdMzN0Wi5skAyIDS1JHIvhog+JgoJcrB4vY+pu0Ao5uG6NMpP7R0dvOmZN/ wTcNau0/8VCzqNis9u7sRAdJvsf20JtnU8e0aRzYkkiAoJcietAgAo+6xOTZ8Rs33Xp5 T97Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ngq1vqqDWR57+w6BNtF6G/pe8jppamc/e1NYlOezZ3M=; fh=qtn8prgQtzf5IzCNvLChUZDElvNECP6ej9YfjQeBz3I=; b=YTHt+Rsr5iSIPyMsW65q/4du+XoO1ck6gXjJPzLF9S0qFbRXWhZHIA90CHffTZcU7o 1AuS/B+TKZYK8V1nEmSoG17z1OWRD0o6VPu1G4hvgVtFG20kV+WlJVXJ9L2ZlBs1TFvk joyWWU4IUQ1XOSgnYv5GmEu0tDZJwyumbbclmB/diEJJmaMvaoz5XD71lmvtptsxnQEm Uce/tJH8R5Tg+J/gMz2yewZVo6lCBC4akdUt+kYEW1d0ig/EVI+yYGBtDUSNMAMgZ9dJ pB2ItPUjJwurb/4uQUnQci9Mc3gPlkfTekA68HfdUuCXE4f0XyBxr8JxxcAJsKdjjGM9 u9Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zb8kyrF2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l12-20020a05622a174c00b003f86b64e2f8si367093qtk.686.2023.06.28.08.55.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2023 08:55:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zb8kyrF2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEXUR-00064Q-9I; Wed, 28 Jun 2023 11:53:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEXUP-00063W-KP for qemu-devel@nongnu.org; Wed, 28 Jun 2023 11:53:53 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEXUO-00084R-1G for qemu-devel@nongnu.org; Wed, 28 Jun 2023 11:53:53 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fa8ce2307dso517195e9.2 for ; Wed, 28 Jun 2023 08:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687967630; x=1690559630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ngq1vqqDWR57+w6BNtF6G/pe8jppamc/e1NYlOezZ3M=; b=zb8kyrF25BKeOg2uKJoRy36vTHu+J1ICpHrMkeWg7DWikCtBtoneE0onDGH+9jc+Uc U/p/uIKuGcFgWlCuNLOHEKynwNXFQNfQRjCCAd1lQGlSaxW8jvLmCvLw0fJq1X6z80Bo tF8HEryye25tQughpSWxFbgSOg1dk0Fto1ul3Dj1I8rxOeaRn8xmxfE+Y3qaLwNXYNfN 6CbtNyR/1kEX6Gptrd0GTY8y7eNlEz+F15VKy3nXbEFZ6xyQpRPNSucW7X6Hoha38pxM YhubFmjmaE4yJuYKjg8sj8lYoJ4MlCnONXyRV8lck2OnyQ5B/DZPf7246HCIkSuXNk0Z 2OBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687967630; x=1690559630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ngq1vqqDWR57+w6BNtF6G/pe8jppamc/e1NYlOezZ3M=; b=dIFwP4ggI1zRHn9zKijVyYBx/yJnD1jVbURTYLim44uLIwf/sH3a2d+bV8ikfiTlrg sd1ds9ZO3zuuHfPvgOlmzHChbNZFEdkbyE/D4TlKNlQEvAwHT4OHKm487shAPRUJBElB qDwdAhjA/uOBUrP/612se4Zi/wQjTQ1zZ8VqaQR/x6O3oGGeBUrPUIuE8svCD1B5zsqK 8JNld16XgsVKq3nCZJHwnaAsy2ik8ayobcZJ6VTtwVNxwDuJAOZ5Wwc31kpbxay+GQJJ dHdf8av0yU8rxGSdoYCUNaNIv7NRqt5e3T1XE9XdlwCumt8NtMkI8ADeThQ+O8r2kfJD U9bg== X-Gm-Message-State: AC+VfDwgvLJGrrwRWVpAHv7NpUCEZqKAZ+46VQfNpC8dNEYUj1EP8zvm bJYn1tIq9TmlovL1BZxBEAkiBpbJgJz1LIEOxGc= X-Received: by 2002:a5d:690a:0:b0:314:dea:41b with SMTP id t10-20020a5d690a000000b003140dea041bmr2465805wru.52.1687967630215; Wed, 28 Jun 2023 08:53:50 -0700 (PDT) Received: from m1x-phil.lan ([176.187.207.229]) by smtp.gmail.com with ESMTPSA id r15-20020adfe68f000000b003111025ec67sm13564763wrm.25.2023.06.28.08.53.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 28 Jun 2023 08:53:49 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 06/30] accel: Fix a leak on Windows HAX Date: Wed, 28 Jun 2023 17:52:49 +0200 Message-Id: <20230628155313.71594-7-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230628155313.71594-1-philmd@linaro.org> References: <20230628155313.71594-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org hThread is only used on the error path in hax_kick_vcpu_thread(). Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230624174121.11508-5-philmd@linaro.org> --- target/i386/hax/hax-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c index 3e5992a63b..a2321a1eff 100644 --- a/target/i386/hax/hax-all.c +++ b/target/i386/hax/hax-all.c @@ -205,6 +205,9 @@ int hax_vcpu_destroy(CPUState *cpu) */ hax_close_fd(vcpu->fd); hax_global.vm->vcpus[vcpu->vcpu_id] = NULL; +#ifdef _WIN32 + CloseHandle(cpu->hThread); +#endif g_free(vcpu); return 0; }