From patchwork Mon Jun 26 20:25:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 696490 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp3416925wrm; Mon, 26 Jun 2023 13:27:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60kzfxPBV4/FQ4OJblWND8XFkTfkYwX7BEo41ka4sqcTa6Rv5FWYdZQu6p9N1t6uY9nf8J X-Received: by 2002:a05:6214:1c47:b0:5b5:9c2:8c29 with SMTP id if7-20020a0562141c4700b005b509c28c29mr29431648qvb.12.1687811224261; Mon, 26 Jun 2023 13:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687811224; cv=none; d=google.com; s=arc-20160816; b=dLJpaX8gIxyKz8BtARmP8wMC0eg2YgdN2fOLWrS9tmMAJp04nVAKmRbcJmxe2PtYsP HecZM1WKBG3RObHGdge99hSUR8rUT8BNDskY2fJEzPtn8p5r860ckNG1vQhxZygqs7da l27vJBjpVwPe33zZqPMtKbJEsZF8FbuCnuz4LnJ0WcLqrd7C5WnuxD+WXlXM9hH/2IGq rAyJFiwq+RXIxm/UdcUL95p53s/vkhQyAZ2ZFgYuwCV63UxH9Mtcl/Lp2pqHhDa0Txl9 M8WdQ4WukLilDo+qBd5l+3QKO96G132OtphfyBBJgiQpI9lzz+PnulI1tmOSl/XFSJGW L7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; fh=gTl3JKI/PjJECOcixmjK8XtvKaOol4SROZQjj0ROPbU=; b=ZujEf6VpTmOHFWmlLggeqpfhaVSRx0AgAxgBIE9FSoduwb24X7SC0eVCH3oC1vwEK0 LLw+HzIZaYusfLILFF5rhb/LBWGTlEp7TOaC4AHLv8Ez8ydz4uNZYycq91/i+6xZjCEJ C+1fB1b8aZNjIrd1s6Gq02JxPVTJb6cBjDjfPyQE7kael105rzqmckLj5juKh/23Wmfp UI8RbOkv8LayLsp3FLfqlrTSQTLhKNhTy2Xk/gGVKssWXc6nJfDHtq8BivzpDIVxo4bV MYVkYuy/2s2/dNvi/cW1l01KBVU9j5bdExZ3xdfJGk81OAymJw2OMBmWs2q7uznYUr5T Vn3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rlEhtYgZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ke21-20020a056214301500b006259b105384si482659qvb.515.2023.06.26.13.27.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2023 13:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rlEhtYgZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmH-0005uY-5a; Mon, 26 Jun 2023 16:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005dC-Ml for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:26 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-00055Q-GH for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-313f3a6db22so1316646f8f.3 for ; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=rlEhtYgZC/4LHm7w+Tx/oFBYOax+Ydar4y/83sQWoE7RAwC27lNK6f2/6Ivk8JHaOi NcgFkfqMY063tNjgm/xXa/Hi/zkMe5doCvIup/NeR0VgZKvXSjqlVweX9lVhPIuRXtEN fwlAbibbqsEsylWCB0a30oa1svi9ftwR81qm96uzN3m/l9KyKUT6Bv1RxI3PTOnBYL+u O3Iw5i3ApPy7SZEc1+n2hu0Ta1iD40h9oiDD1YhZV3CkmOEx5iEVL3hVcZiUJAiNerQr 3GVgWuemE3f6NBW86mxJmvx4vWQajYXYxyKOoAiiJxQnw2FAQmZpSOAKl06t31zmQoIe 7jZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=ZHKAFHEUYsc9lyDayCIX9E8r3fDeuSj1OCkSFpYF2tvrbzHh9xoYMhcidrzFKPvuZl Co37SYRLjVFssr0gnH20h3zFRnceg4gtZ1ZFielSeVMSAfIsaEaMol5dKjnTm8NJZcQQ ailZrFDIyrIJXYnk97C0qDJsoHrIA0yBBcypmMqSBGEiFvBFKYB2vzknyosVrBZcTtLw kVkHjAHpyVcJE+CUTQQ1LbpQg1OCEI4Sg+cFSd17SRJVnbc8j4PnH6f7kxYPIrda0SJe p5IvJlLH8DR1nPU/m3S/EDmmQMcxbVRwvnwynLUlHpIYKv4J9D1m4Mn6bxdkVEOh9pgd 4TQw== X-Gm-Message-State: AC+VfDxZgVBxZpNuWlzy8M+MMlIvtZBu/iHMV/xZyknYPKYSqtUiNp7m Wjgpv9gUPg/IYDPA4yDg1JCo3w== X-Received: by 2002:adf:f711:0:b0:313:e553:b858 with SMTP id r17-20020adff711000000b00313e553b858mr5694878wrp.33.1687811118166; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o10-20020a5d58ca000000b0031128382ed0sm8283322wrf.83.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8A25F1FFBF; Mon, 26 Jun 2023 21:25:16 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?utf-8?q?Daniel_P=2E_B?= =?utf-8?q?errang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?utf-8?q?Alex_Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier , Ani Sinha Subject: [PATCH v2 4/6] docs/devel: remind developers to run CI container pipeline when updating images Date: Mon, 26 Jun 2023 21:25:13 +0100 Message-Id: <20230626202516.2507915-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Ani Sinha When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there are no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrangé Message-Id: <20230506072012.10350-1-anisinha@redhat.com> Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 203facb417..8f18052ba7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project: `CI `__ documentation page on how to trigger gitlab CI pipelines on your change. + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``.