From patchwork Mon Jun 26 20:25:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 696488 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp3416812wrm; Mon, 26 Jun 2023 13:26:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BBSocGVo2JN88JIgoJUEahX4yWz7CLYAxUQltktNZMYfdkYM7Kv0ZcKLyxhxOhjpcD9Uc X-Received: by 2002:a05:622a:1353:b0:3ef:2f81:7865 with SMTP id w19-20020a05622a135300b003ef2f817865mr38562337qtk.33.1687811205004; Mon, 26 Jun 2023 13:26:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687811204; cv=none; d=google.com; s=arc-20160816; b=YhkxR58/FP/+kM0LAgw2Fe53tY4PO53UiY9j9AeFfixyKFHJgHyi6jwSHrnsBNVy1w Yf+5iwyB7tepsw1Wdps4FAh84OTom/5HT+Ar4I2EaBwgQ/XOoWJtR6eyFnK6Y4voEl1z pjThXXT3zbt3SuIevc39wpDJ3vwOhOUZqM6wewX38TbvC3EXHzQTE5wBl93b505sT/M7 NYqrkF/N5FN5A2nmcWSPv4cKadG7Qc6kA2oYkrZRBHDEi2V6nK2V1cvXJDdRi/cWL0/5 I5KOl43nHyc/nV8nOCELXpHNVp5NaCYJdwoxcX7aTvOJLleCLmfPYgoGrOfeZnviQscW nwSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; fh=+72hqC9CJwo/HJv/dERzrbqiWQh1jGfkEiyYBAgNgqs=; b=vLyRcV9r2mHXSlmRWk2VCr5vNeOPtNoI4qgak5DUkmrE4MNJ0jIS9oGZtGpeOhlaIC QTurdyFmCVXw5fzX5SVfW7Fo8F9MUngc64UVRFDzahR74a0qKMVKS94JBBxPiL2dxtgX +BVrsecas8yQA3AIrCFh84Gq92sNddFmaZ90uXwkfJ/Ma20m3xkD8W42hEGR4uxAviQg nQ7/GtIeqH5Y3t8k6u3kt+dcygqsK8sdpQMOPCy+EHiy9sJtWVKJzE1fl5WCQtGF4rpt DTeuSoYbJeAy40OgNTWnnp3vpYPWJ7g0poep03WhnZl7EeBHEEwNoFkcTnJUSaVfbcfU 5caA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YNUvfeAs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t19-20020a05622a01d300b003f39080fac5si2225942qtw.2.2023.06.26.13.26.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2023 13:26:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YNUvfeAs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsm8-0005eB-Cw; Mon, 26 Jun 2023 16:25:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm0-0005aP-Pe for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:22 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsly-000550-Kh for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:20 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-313e12db357so4046618f8f.0 for ; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811117; x=1690403117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; b=YNUvfeAsZnV6/D+m7nIKOhHvM//ambdKCHNu2NuJLqSCW6R7qjNRtBh8+1Gbbju8je 59akoxOgEOFIczhZCF5+VbHdwqnrEYHtPLAQkVcd8+1boQPAqo2RouW8Qw9Fq6zotyC+ TLOzwMpx/6hrBqKeiqqp3gyJO5XyDfOUduBi7VhiVr7USBEZCFZXkASoO1FLaQp5zGOo aZFY7OD6J5kyuwO7TjQMUY1o8t42EOwP66Vr+1SWi3ghxfn9kJJ1LOc+ZNymLFWeK2kK 3ypSMtE8kDpX1jaY57KCTDRryZuhgzixifvPbu5RzteEZh2kSemD0yhYTTl4qKRlzxRL NLqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811117; x=1690403117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lp6KR88j71QtkzhoL0VNQhU+0wKLrKZSfG0XhX5V00g=; b=EyRpdKxPB0T95ya3clLVxIziLbQLBdluhPWOGkEiLv9vdbII8K6rhIC+DwnEMkT3BO 3DP3jMoTKbp1GYObB2L0uNp11pJov1DxK16mpE9wEnCavHES7p54mNGICb85K0cCmgJE BYa5+/LwAFomDY4N0BuT/GFne8a7mvXmw+9X7l35JLscjc24V5u8OQGFf/Q5///XlDvK 5ZwcLvBq94BrWzabRAUCjBLivhiHVov9xcamaUOSROrBz0WI5kh7jvEytGZfABcPVDLl lSu1mu6fiWonAkbGqIyQwnAQX8qwnlUF/D5W+l/SCtzWRnfDMTJyewp+rJBS2aB/9ryR tRcw== X-Gm-Message-State: AC+VfDyF3+wRaOkmgTnWgYe/pGLZAsBR61bb7aLnbaUVX1EBhTD8hx3v H3aY6SBRCxNUnBoMQUQEQmLyUg== X-Received: by 2002:adf:efca:0:b0:313:f6fc:1f48 with SMTP id i10-20020adfefca000000b00313f6fc1f48mr1804084wrp.14.1687811117190; Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id v2-20020a5d6102000000b003127a21e986sm8193795wrt.104.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:16 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3FA4E1FFBC; Mon, 26 Jun 2023 21:25:16 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?utf-8?q?Daniel_P=2E_B?= =?utf-8?q?errang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?utf-8?q?Alex_Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier Subject: [PATCH v2 1/6] gitlab: explicit set artifacts publishing criteria Date: Mon, 26 Jun 2023 21:25:10 +0100 Message-Id: <20230626202516.2507915-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Daniel P. Berrangé If not set explicitly, gitlab assumes 'when: on_success" as the publishing criteria for artifacts. This is reasonable if the artifact is an output deliverable of the job. This is useless if the artifact is a log file to be used for debugging job failures. This change makes the desired criteria explicit for every job that publishes artifacts. Signed-off-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Message-Id: <20230623122100.1640995-2-alex.bennee@linaro.org> Message-Id: <20230503145535.91325-2-berrange@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest-template.yml | 4 +++- .gitlab-ci.d/buildtest.yml | 2 ++ .gitlab-ci.d/crossbuild-template.yml | 1 + .gitlab-ci.d/crossbuilds.yml | 2 ++ .gitlab-ci.d/opensbi.yml | 1 + 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 5da61f4277..f3e39b7eb1 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -25,6 +25,7 @@ # rebuilding all the object files we skip in the artifacts .native_build_artifact_template: artifacts: + when: on_success expire_in: 2 days paths: - build @@ -53,6 +54,7 @@ extends: .common_test_job_template artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt @@ -68,7 +70,7 @@ policy: pull-push artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" - when: on_failure + when: always expire_in: 7 days paths: - build/tests/results/latest/results.xml diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index aa833b62ca..24bba061cd 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -462,6 +462,7 @@ gcov: coverage: /^\s*lines:\s*\d+.\d+\%/ artifacts: name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} + when: on_success expire_in: 2 days reports: coverage_report: @@ -587,6 +588,7 @@ pages: - make -C build install DESTDIR=$(pwd)/temp-install - mv temp-install/usr/local/share/doc/qemu/* public/ artifacts: + when: on_success paths: - public variables: diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml index 6efb0d2a54..d97611053b 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -55,6 +55,7 @@ .cross_test_artifacts: artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 1e0e6c7f2c..34f9df2be9 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -169,6 +169,7 @@ cross-win32-system: CROSS_SKIP_TARGETS: alpha-softmmu avr-softmmu hppa-softmmu m68k-softmmu microblazeel-softmmu mips64el-softmmu nios2-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe @@ -184,6 +185,7 @@ cross-win64-system: or1k-softmmu rx-softmmu sh4eb-softmmu sparc64-softmmu tricore-softmmu xtensaeb-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index b4d7eef688..fd293e6c31 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -63,6 +63,7 @@ build-opensbi: stage: build needs: ['docker-opensbi'] artifacts: + when: on_success paths: # 'artifacts.zip' will contains the following files: - pc-bios/opensbi-riscv32-generic-fw_dynamic.bin - pc-bios/opensbi-riscv64-generic-fw_dynamic.bin