From patchwork Sat Jun 24 17:41:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 695718 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp2502659wrm; Sat, 24 Jun 2023 10:43:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7d+8ZPfoRKIZUNoUAMMOqHu7rG5C8t/bLSCZwIipoV5Pe0Sg+Z35cupRpn3+4cW7RVCgEc X-Received: by 2002:ad4:5cca:0:b0:62f:ea7b:2911 with SMTP id iu10-20020ad45cca000000b0062fea7b2911mr34516663qvb.56.1687628580515; Sat, 24 Jun 2023 10:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687628580; cv=none; d=google.com; s=arc-20160816; b=pXaIFd9OAPaRX743g/H8Zh9paIcZZRhzsNij3YsARii5q/OPr5OGTy9czrhqPUfBpP 0QpyYYzGGVKu3TvA8jQoZq+rbrmEKdzNyNPVVpEoeINFO0DN1a3BOeBz8WDEZTAPD1+e 0zd8f8NaZ3mB8gHzwLPrcb4nkZ3xloUmSDq7zdKPKC3rZuvO+MnEvejCN6e/z6/SXQYs XmT/HwM2+4CggeKXNWR1c6ecBOIpSJROyZq3JqJJ/bRa/Xt0FJz9EhMxx508kDqmhuCm 8SgHXoxmzH+jvng5HnWiKXALy/O6ShaFHjk83f3BfQb5z98L4OXJkSbrlO593vJxWA+w lbMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wDJq03Cy4udm0BY/tdQJBSn7cYSDg3Mije1czkKCJYY=; fh=dxlO8U8n9FJbkfu3NZ9xTJMkF/Fn5IQj359CkmYw0tg=; b=aLEGj5mBj8OJmCEiCWgqNCRCJdOTO5rmo3C0L8FQvUhvP7oo5kzUFQCEccoAokAtWc 5aSsxPfS5QmPABGc6kD6ZO4tY3HJTaS18CBnE58VP1gpkHJlLo0Z/QmQdgNIG3Q8ahHQ MGOB9dIcKqDcXS1tjJp/rya7viayENYX3WcU4tWWta9S6Ze7nXng9nlNYPxg4UdJgAWQ 4oLU1MqoVorOkwQ8oSkRZv+vbQKw+xIXiucluDGsNbFXlfnWRTqN0HFHzDntCTMmRbQh KKkPTnITgJhHvtMPfDDVIgA0+jc+tSIFvYaUX3Lom1t0TWmG0HLLDhQ+jJ9AFsnNR3qq 9lmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RO2avB+F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y15-20020a05622a120f00b003f6aee83d03si596115qtx.693.2023.06.24.10.43.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Jun 2023 10:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RO2avB+F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qD7HQ-0007NL-HJ; Sat, 24 Jun 2023 13:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD7HP-0007LW-4S for qemu-devel@nongnu.org; Sat, 24 Jun 2023 13:42:35 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD7HN-00070x-I0 for qemu-devel@nongnu.org; Sat, 24 Jun 2023 13:42:34 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51bee0c0acbso1695268a12.1 for ; Sat, 24 Jun 2023 10:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687628551; x=1690220551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wDJq03Cy4udm0BY/tdQJBSn7cYSDg3Mije1czkKCJYY=; b=RO2avB+FoBAH/Di/V4kIhFyDQH7uIlgC0gwfCgQrD89bwE83AmBBFg0CcRlHBZjeo8 xf712Qc9aR38nPiF+uDaf5yc8gD19WEsCR2svxAprxd1bFxGUA2r4lMmJIlwctgs7QkB EUtMNoLLcY3J6LBbohSpdImmOm/n5GLZ+fA8stYV9O4SnDoSh8DTgNabJ/O9qfxzX4AN 5t1XZJvA/e/bJFTTAZaWg85tev9gNfCnctzxCTxdaNAK3TWI6g6FLKy1iSyDWwm7ICVw UkmuMgdFFe7lQAMN+uYaq3GLpkAMayp43PGSU3d6bHrT+2SGnuNJPvNFppg8VTyk9Otn 2Akg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687628551; x=1690220551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDJq03Cy4udm0BY/tdQJBSn7cYSDg3Mije1czkKCJYY=; b=V3rLE8K1sG81Uofrb9F54dHpbjLugaLQQ754YTVJ81epiaaXzhJAmE5hDQ7AdEDasv m1nXRfuvv0LaP3lDjRIFGW2wq4JvI6mBKbggnRnaXDso69Tw0INT+1khko/cDeoFAyhv uSk3GanpSjnqb9EUUDf10TrNwobU41uFOR0zermH/WRTMOp6X5c1a1pBtTBdFc3f6ssZ CQ89wxG1clUNoPExdjZ/UiPtZse/5Oa/NzTI/2/nhhPLv7Fyd6yEQ+73QFSKgTO4DA0P LJ9yhzR8XxK3YubYtpG6Kp8DBeTKIbCD5ryfkPX3egl9PQrZ5ikx7Xp5RRvUTFs3+gyC 2UXQ== X-Gm-Message-State: AC+VfDwPtxwW+XLXKFFj294uvexyXaYpKzak5Z6MsTaHyugtYoKKhpeV HdQopE2J3g1EWCel//WZJZVqqqE2dH0FUjRvwRE= X-Received: by 2002:aa7:cb47:0:b0:51d:9130:3c54 with SMTP id w7-20020aa7cb47000000b0051d91303c54mr196875edt.26.1687628551740; Sat, 24 Jun 2023 10:42:31 -0700 (PDT) Received: from m1x-phil.lan ([176.187.217.150]) by smtp.gmail.com with ESMTPSA id d15-20020a05640208cf00b0051a3e7d7996sm872902edz.83.2023.06.24.10.42.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 24 Jun 2023 10:42:31 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Marcel Apfelbaum , Peter Maydell , Roman Bolshakov , qemu-arm@nongnu.org, Richard Henderson , Alexander Graf , xen-devel@lists.xenproject.org, Sunil Muthuswamy , Anthony Perard , Stefano Stabellini , Yanan Wang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paul Durrant , Reinoud Zandijk , Eduardo Habkost , Cameron Esfahani , Paolo Bonzini Subject: [PATCH v3 09/16] accel: Remove NVMM unreachable error path Date: Sat, 24 Jun 2023 19:41:14 +0200 Message-Id: <20230624174121.11508-10-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230624174121.11508-1-philmd@linaro.org> References: <20230624174121.11508-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=philmd@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org g_malloc0() can not fail. Remove the unreachable error path. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/i386/nvmm/nvmm-all.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index b3c3adc59a..90e9e0a5b2 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -943,10 +943,6 @@ nvmm_init_vcpu(CPUState *cpu) } qcpu = g_malloc0(sizeof(*qcpu)); - if (qcpu == NULL) { - error_report("NVMM: Failed to allocate VCPU context."); - return -ENOMEM; - } ret = nvmm_vcpu_create(mach, cpu->cpu_index, &qcpu->vcpu); if (ret == -1) {