From patchwork Thu May 18 16:20:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 683388 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp464916wrt; Thu, 18 May 2023 09:21:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6g6df1sW0k95eXA8ZjTrfvhgIrdTG/mjGl5RHkuJDCdWGi+6fhyaleF5jCXDELCCm7tsrf X-Received: by 2002:a05:622a:101:b0:3e3:9117:66e8 with SMTP id u1-20020a05622a010100b003e3911766e8mr409973qtw.35.1684426910878; Thu, 18 May 2023 09:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684426910; cv=none; d=google.com; s=arc-20160816; b=Z4RSu8qTJ8m7iKgpYkkSaJ4/5NGC9aC5H4PiEQpb8JRo7d/V549+sh7pTJslOikZir YsPOI56eZSBjajJQJUpGgCStEnPzfxTHKEjXrXBXzxdAhZR8OTinXPZc2QZdC+j0rHCQ yowmB4oSSizVYLgYCRzk4HMr+wXsL+9kB6uVk5v1Ad/WmzN4SQcf5+lxvjf/NrLrY6Su KNuJGhB/FrhVGdRsNuLWkc4nisPiGOIJkCvvp/V+JMsp8+1Dv8M5aGKnPBsKR+e4xZ7K XilsUW7Od0MLQa3L4q8LxvKmrR3rsPB8D7h4gMkg+UYHM5C+QsBRlHFhwoWPQx/8Xt3+ iAAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Zbl8XzyKlaQzQKkmBpRC1BQfjMk6noU7XtypXo8S4mE=; b=UpCDPPLEZLR+dj/Vl8FhxXnvB5LI+5c7XMJFlyA60Ua4grF4pqeaooSkfZZHVfLvz5 AFUZwtzbsHFR1hHFIPgkoNsWDlbk8sJlWLKD5kDv0hChIX7NUL97fs8zhyhjczi4ivvD 2Lnpsu6WJmYGUP1/bVNVs9qjBGEtXrTKagzn+CTS6+zTse83GftVXDF1vzqfUQtZoy1g 3+DphlfFQndT6as3wBpbEJuOz1GdzG2aXM0JfNvEQDFAoWDnLo9aaTOxBIhF+lMT8h88 7tj5PxEL5oTgFJNUIu3CSyalxXfsNz2PzyBxVlFklMecMZsjyuuum7i5UFBE/stmb4ml MwXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CP2cQJ6G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id os41-20020a05620a812900b0074df6609c96si1265157qkn.115.2023.05.18.09.21.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 May 2023 09:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CP2cQJ6G; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzgMz-0007dv-BF; Thu, 18 May 2023 12:20:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzgMq-0007Yn-7b for qemu-devel@nongnu.org; Thu, 18 May 2023 12:20:41 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzgMn-0006OA-Gg for qemu-devel@nongnu.org; Thu, 18 May 2023 12:20:40 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f420618d5bso14716625e9.1 for ; Thu, 18 May 2023 09:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684426835; x=1687018835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zbl8XzyKlaQzQKkmBpRC1BQfjMk6noU7XtypXo8S4mE=; b=CP2cQJ6GvxK3TcLDMcCNHZlEIXw8ACYWLWF5vHj+FHngZJg1D4ePURAr+EDf4uuLS4 nvWqOjcvm6jvC4DwbF0TC8afc9Uw1rfJOWXbp3CnxcdWJbfnqm1fj7c34ieZyCa245Nk o+OElouFDouEVf/+i6kz2PEIV2fZIAUhqChDmXysTOp7yLUtrK2F10/ckkpy++EonJYc 8OWesbRYpmk59kfQw1G0IvazZzLftCSR3aDYubIRq0Xip3t7zi04u7gEEEuHlNKk5zcH kldZftgNn3aVz6gc940PlG8BxuL4XccCoT/NT6abPER/MZyuwFw27BQp0kiVKsvGDzzf CWsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684426835; x=1687018835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zbl8XzyKlaQzQKkmBpRC1BQfjMk6noU7XtypXo8S4mE=; b=fAYbaLaUJZq+TFJ4800UGjQU1O0m3W1z5NAGByTx0oOGPakRkJN9JNf5Efk12yx2IO F3A4QFxO+N5v3szVBdFr8aj2e1vQJxs5vUWvHaSNHvf3C0A5hRvh5ucIglNZPMYQ6lEC //4X+EVk8ESXGaEgHFT+swc3SNecYZfdTOYknJgR3Yve8bI4zuoIL6GlXmcU4c+7KYYX PGE5Hmf7z7zysdg3gpJeyvAB08AaN/L+t3TZOGtymkIeDcGy01vGQgRmTU56BJe4pSRj ymjocSEfE7Up+BZ6hVUPLLXlGSw/oJwsoUr9pHFOLJnvh0cxY1ixOcoaNdUjldB1p2Q/ UWkA== X-Gm-Message-State: AC+VfDxM5ku5wvYT4gDZYHxkhnj81dE1ITwDETgnMDspdhOG7p5KCc2C AlpGHYN1yisbgb7oBgi4j0t1pg== X-Received: by 2002:a1c:720e:0:b0:3f4:2d31:11b2 with SMTP id n14-20020a1c720e000000b003f42d3111b2mr2050672wmc.13.1684426835237; Thu, 18 May 2023 09:20:35 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m16-20020a7bca50000000b003f4fbd9cdb3sm2504196wml.34.2023.05.18.09.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 09:20:34 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5DE2F1FFBC; Thu, 18 May 2023 17:20:34 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Markus Armbruster , Richard Henderson , Peter Maydell , Thomas Huth , John Snow , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Daniel_P?= =?utf-8?q?=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , =?utf-8?q?Philippe?= =?utf-8?q?_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Mark Cave-Ayland , Wainer dos Santos Moschetta , Cleber Rosa , Beraldo Leal , Bin Meng Subject: [PATCH 1/8] gitlab: explicit set artifacts publishing criteria Date: Thu, 18 May 2023 17:20:27 +0100 Message-Id: <20230518162034.1277885-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230518162034.1277885-1-alex.bennee@linaro.org> References: <20230518162034.1277885-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Daniel P. Berrangé If not set explicitly, gitlab assumes 'when: on_success" as the publishing criteria for artifacts. This is reasonable if the artifact is an output deliverable of the job. This is useless if the artifact is a log file to be used for debugging job failures. This change makes the desired criteria explicit for every job that publishes artifacts. Signed-off-by: Daniel P. Berrangé Message-Id: <20230503145535.91325-2-berrange@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest-template.yml | 4 +++- .gitlab-ci.d/buildtest.yml | 2 ++ .gitlab-ci.d/crossbuild-template.yml | 1 + .gitlab-ci.d/crossbuilds.yml | 2 ++ .gitlab-ci.d/custom-runners.yml | 1 + .gitlab-ci.d/opensbi.yml | 1 + 6 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index a6cfe9be97..d90bd6419f 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -29,6 +29,7 @@ # rebuilding all the object files we skip in the artifacts .native_build_artifact_template: artifacts: + when: on_success expire_in: 2 days paths: - build @@ -57,6 +58,7 @@ extends: .common_test_job_template artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt @@ -72,7 +74,7 @@ policy: pull-push artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" - when: on_failure + when: always expire_in: 7 days paths: - build/tests/results/latest/results.xml diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index bb3650a51c..0bb5cd56f9 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -462,6 +462,7 @@ gcov: coverage: /^\s*lines:\s*\d+.\d+\%/ artifacts: name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} + when: on_success expire_in: 2 days reports: coverage_report: @@ -587,6 +588,7 @@ pages: - make -C build install DESTDIR=$(pwd)/temp-install - mv temp-install/usr/local/share/doc/qemu/* public/ artifacts: + when: on_success paths: - public variables: diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml index 4f93b9e4e5..a7e34e0145 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -55,6 +55,7 @@ .cross_test_artifacts: artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" + when: always expire_in: 7 days paths: - build/meson-logs/testlog.txt diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 61b8ac86ee..ee4c1b74d9 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -161,6 +161,7 @@ cross-win32-system: CROSS_SKIP_TARGETS: alpha-softmmu avr-softmmu hppa-softmmu m68k-softmmu microblazeel-softmmu mips64el-softmmu nios2-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe @@ -176,6 +177,7 @@ cross-win64-system: or1k-softmmu rx-softmmu sh4eb-softmmu sparc64-softmmu tricore-softmmu xtensaeb-softmmu artifacts: + when: on_success paths: - build/qemu-setup*.exe diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml index 34a1e6f327..a0aef96a07 100644 --- a/.gitlab-ci.d/custom-runners.yml +++ b/.gitlab-ci.d/custom-runners.yml @@ -20,6 +20,7 @@ variables: artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" expire_in: 7 days + when: always paths: - build/meson-logs/testlog.txt reports: diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index 9a651465d8..867e34c19f 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -65,6 +65,7 @@ build-opensbi: stage: build needs: ['docker-opensbi'] artifacts: + when: on_success paths: # 'artifacts.zip' will contains the following files: - pc-bios/opensbi-riscv32-generic-fw_dynamic.bin - pc-bios/opensbi-riscv64-generic-fw_dynamic.bin