From patchwork Wed May 3 09:12:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 678820 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp947471wrs; Wed, 3 May 2023 02:16:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6YUS+Fe92ByX1Z9/fFbHbFa5C67cpducno/MFtJ2u5x7rubcD2JE8rFAFQRv45mBb3zJaa X-Received: by 2002:a05:622a:1902:b0:3ef:344b:2099 with SMTP id w2-20020a05622a190200b003ef344b2099mr33962556qtc.4.1683105414748; Wed, 03 May 2023 02:16:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683105414; cv=none; d=google.com; s=arc-20160816; b=DzCpaaCxqkWoLm5mM9Gxqikl9uHOTEfext1rvdMmjrvXhHy7oTKoTrQ52QL+1q/SA2 5v8jbOYjPeoUghreQE4oPjLVM2Wo7ozK37Y4bFkU3Y2H1sFJl4v+ncb9s9NaZgAaF/gQ hfV2ppfS0ojfwimFeYbx7El6FlipQCcPtv0HnCsO1ov3oZAHItWu+y1g+uQxtwdcWu8k U+deO5n1TSwVm61pwd65OIqx5ObvIgExmZ1udoiB05cxQcZM3LpozHgme8RZSJZ2Cc1N 3WO6/URpVzX8HQZ2utq6XoFQ1oFKVvrzWuTEb5EA4l8AfvKSrqv1VdScRbgaZfwOlZel wh6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=59DATpvhJwGGAwW9/5YfnTLXtpUBYi07i8tRAsShAvw=; b=t88OnRey2hxYyxXtw8efinZskez/2z38dsKiZuyGHBROCeeniPnEaOSHQCGh0e3GkZ ko1GVsESr+wr2QHK4J8S5AucZptdhrzsvldJP0r7wB8i+ECNJ6y7/OP7uTGVjc94dZdU tccBi+JWTjvUIeBy4yv/fScoYwZm+38onMBlPNoNqDwKsQn26NYEueMbdKRyPWRyvD2v rmTi8iZ8fIuIZ3GGI4d/Q8FrpxM26KbOrP8mNZe4GePQ9zsHLDvVXfVf7h5zg2krw6Fy RJ/Y838vH1s9hVpe/ceTG+1X8QswnuREuOZqoYJbZ4QYSejsMI5h5Sqng/TFzV8dQe1H v5ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FmJUGO+f; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l12-20020a05620a28cc00b007459f798d8asi19505041qkp.223.2023.05.03.02.16.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 May 2023 02:16:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FmJUGO+f; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu8YE-0005fv-SB; Wed, 03 May 2023 05:13:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu8Xx-0004Z6-L1 for qemu-devel@nongnu.org; Wed, 03 May 2023 05:13:13 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu8Xc-0005tD-8U for qemu-devel@nongnu.org; Wed, 03 May 2023 05:13:13 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-2f95231618aso2992472f8f.1 for ; Wed, 03 May 2023 02:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683105170; x=1685697170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=59DATpvhJwGGAwW9/5YfnTLXtpUBYi07i8tRAsShAvw=; b=FmJUGO+fBUt9Lb4G9cszUd0sU+1XNYb5Itru8EY242WTve7HRmSifI504BDyhNEal4 vvUWwUkZHvLv1HmLiWnhCepkTeHjS6pjHPl2/WbVaiv96znddlQDB57O17I0yrayuvjH 5/Cr+XffmYXEAc/kcHF+8XvAuFlNzI6SV2ZRmzaXHN6fOpr5ROeG8fn+dVSmoDrJFpL7 53nihWBfFi2GTTb69aNjkCq1lCVQIM0dVh1D/4YkzRGtmjN+ENyhwgUVLlmVLeclMTSF bcWyrBKj7afkdty7ump53inRIWevQVeuOr+44sFVZevGzsjp7q2pv6ylWn1+FRtCH2XX SbYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683105170; x=1685697170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59DATpvhJwGGAwW9/5YfnTLXtpUBYi07i8tRAsShAvw=; b=HuGtx9VMSE7MlDyduYb8C3EmYfBNc+NTAF9MTX5JgPtqBql8NjtXA6LlP+fXOyxMr4 XFVQiaFXMBcgSah/BLq2yAcmeUsnA1ouZk5pLcjT4cjZ6Dm27nWVl12mZFqkWyQ9T6qn rMdJkmENw4K64xubf5xn/xsTtVK6r/sKjLfn04vhT9PhwjHKoH3RVZ941HSvOfJgdtRi O7CVwSAkfIqZ95JsolzjyN1IT4eVXb2oAdJBiI3uhcBh3AtetL4coUs8I7X5kypeHUPX k9e8fgSb1DMzDQaFXVNn7U1O7SvvyxWkm1YJq9Njx8Yx2KqIZefQEqjsqsuaisX6j4sD XOPw== X-Gm-Message-State: AC+VfDygLULhkj0Pmug+D6l8q0PgQPqTt6n4s2iltGzRf846As7SNOzM WIn9OarIOVt7gLqGBFeP/2yCVA== X-Received: by 2002:adf:f7cc:0:b0:2f5:9800:8d3e with SMTP id a12-20020adff7cc000000b002f598008d3emr13618863wrq.47.1683105169933; Wed, 03 May 2023 02:12:49 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a7-20020adfdd07000000b003062db9cc21sm7475316wrm.92.2023.05.03.02.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 02:12:48 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A0E101FFC0; Wed, 3 May 2023 10:12:45 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Artyom Tarasenko , "Edgar E. Iglesias" , Wainer dos Santos Moschetta , Thomas Huth , Leif Lindholm , Paolo Bonzini , Gerd Hoffmann , Helge Deller , Xiaojuan Yang , Stefan Hajnoczi , Cleber Rosa , Peter Maydell , Eduardo Habkost , Juan Quintela , John Snow , Yoshinori Sato , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ilya Leoshkevich , Pavel Dovgalyuk , Andrew Jeffery , qemu-s390x@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , qemu-arm@nongnu.org, Bastian Koppelmann , Beraldo Leal , Max Filippov , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Mark Cave-Ayland , Jiaxun Yang , Radoslaw Biernacki , Aurelien Jarno , David Hildenbrand , Markus Armbruster , Song Gao , Joel Stanley , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas Subject: [PATCH 06/22] hw/arm: Select VIRTIO_BLK for virt machine Date: Wed, 3 May 2023 10:12:28 +0100 Message-Id: <20230503091244.1450613-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230503091244.1450613-1-alex.bennee@linaro.org> References: <20230503091244.1450613-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Fabiano Rosas The virt machine has IF_VIRTIO as block_default_type, which causes the generic code to try to create a virtio-blk-pci device pair at configure_blockdev()/qemu_create_cli_devices(). Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-devices): $ ./qemu-system-aarch64 -M virt -accel tcg -cpu max -nodefaults -cdrom foo.qcow2 qemu-system-aarch64: -cdrom foo.qcow2: 'virtio-blk' (alias 'virtio-blk-pci') is not a valid device model name Signed-off-by: Fabiano Rosas Signed-off-by: Alex Bennée Message-Id: <20230208192654.8854-7-farosas@suse.de> Reviewed-by: Richard Henderson Reviewed-by: Juan Quintela --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 4c23fbf800..168c1e8089 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -34,6 +34,7 @@ config ARM_VIRT select ACPI_HMAT select VIRTIO_PCI select VIRTIO_NET + select VIRTIO_BLK config CHEETAH bool