From patchwork Tue May 2 12:14:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 678377 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp474418wrs; Tue, 2 May 2023 05:23:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7SbwZgDPMy8HF69aC+eVclZ7eTYf7OBWG/HBFgykUQefl/uXi18vrUzx/FyVaantf8y9LY X-Received: by 2002:a05:622a:15c4:b0:3e6:720f:bad7 with SMTP id d4-20020a05622a15c400b003e6720fbad7mr23075530qty.54.1683030235887; Tue, 02 May 2023 05:23:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683030235; cv=none; d=google.com; s=arc-20160816; b=ZKfIlAgKsGKUNDIvOvqX2aVJg3D9T8AgCV9TcQuNKCMDpemEJ8frWcFe7bGvDH2Ss3 xuFnCZCG0alE4lMNv35JXykLpVa7XOkIEQT0NqiFPSW+6L6u9vrU7tgD75jgJ2F41ddp HwFD+mXtCCEDK+ijBGcJsivypc7JRz6ciEonagoKDLR8WHnP1whPAlLDJw/1I1a7sQId Np/jA86Kfe/iU3fDF/OJQnc6bDUFlKdeCMX+LjPbfRpBWSLFniT+S+1c/lfARJIINxZ+ XB9RcO27H1TQ5oFBp8qyM0LsV6Q/UtzcKMrjqitxuRQbeeXDBVo5FB3aDpk1u2KVsG2J QpsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ijXKWKHhny3h877w5LeEg4sVNPT7JiYssZSYC6serVo=; b=JgJRqe5fjFyVdXpXYOHyg5QsZSDRzmGDcxr3ouJ1Yfnbqu5z+nRwGmz0x1+Bv3aW7U uPOmD9zCsBSRHkASkQInfWoAyW14Vo9rZGySLq0MN7razhIRlcALBVyb7canTb1e06rG J+5YoExEefxiTNFhfZsnuAt4uVxpZkQpzZEdp3TAxhQcUDDOF5G8FxB3uuwKpOufNpuN fx4bsgTjeYAlsj+tZS/OBOE/7S+oozh7ytU8LVa3dgKIcOk6i6ph946p1aPk7GCVSKCR PUrbBvAuUiW9mmDFFZnS2VQhD34kRJXH3EWBS4Sgljb3nz1byIsIfRNoDeeBz4H4V9O4 eszw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EQFPl9p8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w21-20020ac857d5000000b003eb14a22fdasi18304410qta.238.2023.05.02.05.23.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2023 05:23:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EQFPl9p8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptov9-00043X-5S; Tue, 02 May 2023 08:15:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptoui-0003oS-UJ for qemu-devel@nongnu.org; Tue, 02 May 2023 08:15:34 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptouY-0003Dr-Ul for qemu-devel@nongnu.org; Tue, 02 May 2023 08:15:22 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f19a80a330so22281615e9.2 for ; Tue, 02 May 2023 05:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683029712; x=1685621712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ijXKWKHhny3h877w5LeEg4sVNPT7JiYssZSYC6serVo=; b=EQFPl9p8WK2fD8EyQ4QmqtuLs0uARWodtXfOF4Wut1qvdfvdG2rX4VGL0V8UpOP/wZ 8FDRFANiywcjgdoAHQjoOcLf7fNqPD/grqySPq3o8bBcfkGTJ/o5UJjGsVEccl1jyFDn wKniWCoSW8n9YKn1p+hbvhfYM4JxxCaUEei0PJNqiFS5169AWKiEJBlJP6DluqNuW7dr s1VZxxpLEeBSmc5Y3Q3ojum0gV6ISqAtXE6YfjdGwVxYFKlqlli12BsDQGYTyUYMoIT+ UwQjMYAoCrS03SDsrd8D639uNRhm/XHmKsfM5FXNy+FgqjB20iOhqKmPCVE+ikhrD8y6 wBHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683029712; x=1685621712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ijXKWKHhny3h877w5LeEg4sVNPT7JiYssZSYC6serVo=; b=ZWzSj9wLrPesnk1J1jSIJBpFLqo9xDvvUmMF0Nt9auRC0GJEStz1SEQtVsuOwA+qxc XQi3JpDxV6PvVj287XnLPiQwn6/Y4Ql/7G/QO9PIUgYotC6aW0LihuSOpt/6wtvI63Ba D/oLoMpWugDoC5Il2kSH/XShohtTN+Q36sR7iyMvIdOYoFShG/cfBMM8ly+MxDSs442c UBqIrUTUrV8Ls5ED2bVuTNtHORFpp//nHWqHMi3PCcQWgYpXZQAJvEAtAmCvTqbJpdNu eivQIqdhvdM/F9Tzlr9WbJoQDTqPA3DkLsdnJh0sz4rjDWY7AyBSYPazDeM+LC8ydLOv Phew== X-Gm-Message-State: AC+VfDy9suo6m14xMmCWC6JgEIJK9YqUKHwuMNg5DwHIVANMOq6s7Tkr RZSyMhflwJPdRg40bmveb5qTSyiElgbh+Cox0OY= X-Received: by 2002:a1c:6a17:0:b0:3f1:7c38:719b with SMTP id f23-20020a1c6a17000000b003f17c38719bmr13205308wmc.3.1683029712449; Tue, 02 May 2023 05:15:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id g10-20020a7bc4ca000000b003f171234a08sm35040330wmk.20.2023.05.02.05.15.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 05:15:12 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 25/35] qmp: Deprecate 'singlestep' member of StatusInfo Date: Tue, 2 May 2023 13:14:49 +0100 Message-Id: <20230502121459.2422303-26-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502121459.2422303-1-peter.maydell@linaro.org> References: <20230502121459.2422303-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info status' command, as we've moved that information to 'info jit'. It seems unlikely that anybody is monitoring the state of this obscure TCG setting via QMP, especially since QMP provides no means for changing the setting. So simply deprecate the field, without providing any replacement. Until we do eventually delete the member, correct the misstatements in the QAPI documentation about it. If we do find that there are users for this, then the most likely way we would provide replacement access to the information would be to put the accelerator QOM object at a well-known path such as /machine/accel, which could then be used with the existing qom-set and qom-get commands. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Message-id: 20230417164041.684562-11-peter.maydell@linaro.org --- docs/about/deprecated.rst | 14 ++++++++++++++ qapi/run-state.json | 14 +++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 6f5e689aa45..d5eda0f566c 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -199,6 +199,20 @@ accepted incorrect commands will return an error. Users should make sure that all arguments passed to ``device_add`` are consistent with the documented property types. +``StatusInfo`` member ``singlestep`` (since 8.1) +'''''''''''''''''''''''''''''''''''''''''''''''' + +The ``singlestep`` member of the ``StatusInfo`` returned from the +``query-status`` command is deprecated. This member has a confusing +name and it never did what the documentation claimed or what its name +suggests. We do not believe that anybody is actually using the +information provided in this member. + +The information it reports is whether the TCG JIT is in "one +instruction per translated block" mode (which can be set on the +command line or via the HMP, but not via QMP). The information remains +available via the HMP 'info jit' command. + Human Monitor Protocol (HMP) commands ------------------------------------- diff --git a/qapi/run-state.json b/qapi/run-state.json index 09ea1202927..db3cf52c62a 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -104,16 +104,24 @@ # # @running: true if all VCPUs are runnable, false if not runnable # -# @singlestep: true if VCPUs are in single-step mode +# @singlestep: true if using TCG with one guest instruction +# per translation block # # @status: the virtual machine @RunState # +# Features: +# @deprecated: Member 'singlestep' is deprecated (with no replacement). +# # Since: 0.14 # -# Notes: @singlestep is enabled through the GDB stub +# Notes: @singlestep is enabled on the command line with +# '-accel tcg,one-insn-per-tb=on', or with the HMP +# 'one-insn-per-tb' command. ## { 'struct': 'StatusInfo', - 'data': {'running': 'bool', 'singlestep': 'bool', 'status': 'RunState'} } + 'data': {'running': 'bool', + 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, + 'status': 'RunState'} } ## # @query-status: