From patchwork Thu Apr 20 15:00:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 675620 Delivered-To: patch@linaro.org Received: by 2002:a5d:4a41:0:0:0:0:0 with SMTP id v1csp363828wrs; Thu, 20 Apr 2023 08:00:49 -0700 (PDT) X-Google-Smtp-Source: AKy350YlkWbcbvYPw75g0ovFCArH6KFoYgqkf1V7auyCR7DJcug2OzCahGj7o59OjJZwFxytiiba X-Received: by 2002:a1f:4f47:0:b0:43f:ec5d:51e1 with SMTP id d68-20020a1f4f47000000b0043fec5d51e1mr865679vkb.9.1682002849037; Thu, 20 Apr 2023 08:00:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682002849; cv=none; d=google.com; s=arc-20160816; b=KBTVlE4nqQNOv/a+AGYlVKWDPK6WHwMSgVbhZ9xusE2yY0Ld8Q6LGN3cyVW5GE/S3/ gs/P3pbUC2O41pI/SltjJtknB1MNfCP6OHWR8FR7zp+AabIIHdnL8krYDY/jNbj+V75s 13Nv9gCJQqEhHYnmEn32sP3JRpoCcLZ9QBH4CzHGwbHZQ5T9R7tmj2u7XpbwrHZv9CU8 Dop/WMqIsW/bCXRviE05rs52ve0wbw1kZ7cn6XW98FiaTtGgZCOPw5f0EXw4ZqXxIjgw BK1DhFABkGV9WjuqRgI+o2XXkI9sjzgJU3tkJ0yCN9VqLtNZnazsKbQCGo/pNGyfQZRc VXTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BaYFv/GATacnspxitZxXqy32DjO2LBrHottpHojCTUU=; b=mlegy0yzWCpya+GtW3Ra5EptutT18y14cLCbEhuemiFUsXIeSuh/izcOkDswpJPFdP XuXHD5leVtb/sJmplv3xP/yfI5vtjK9K3cVi12Pmdpkv7whOwv0bSEMcfGThTMQzXhNn GMb9eZ1KKy+hrNk8mrJJw+bnw5/SOeQBjNV1JGg3uY1ycrahlNyhOHMr0797DxZ4c8dy n19ofLCaxu81HL6XlK/UqsYHe+eWAf0636JvEOjkC/DxUFGLUwWYDqO5LVk2fiba82jp xBwyMemFVP2w3Y9/6iR0hBYZipt8qLi8g3mcSZ8EB90J0wE3d6Le4XdAsh+5Lkgb4nz8 HJjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fab1SFaK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n8-20020a1f7208000000b004406663e3edsi508605vkc.94.2023.04.20.08.00.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Apr 2023 08:00:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fab1SFaK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppVlq-0003kR-WC; Thu, 20 Apr 2023 11:00:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppVlk-0003dB-6r for qemu-devel@nongnu.org; Thu, 20 Apr 2023 11:00:21 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppVle-00046H-4s for qemu-devel@nongnu.org; Thu, 20 Apr 2023 11:00:19 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f0a80b686eso5049405e9.1 for ; Thu, 20 Apr 2023 08:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682002813; x=1684594813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BaYFv/GATacnspxitZxXqy32DjO2LBrHottpHojCTUU=; b=fab1SFaKzW2HOaakn+2mXg5jcNE5tsUQ//PQY+SBl3xlP5qFyr5sYDhh5+5q/I926A ArZL0sR+CrrwKb4pT6nXc9ojPszq0sSVe7I0HtFEevTpGp+Lc9o3Kgisfsl/DtUrP05p SuKmfrcj1hyCAP5yUyyu4k3YCpaMLn2lKyRhgTSZXcUHYSnUDZPFugQF+bNOp1sbn+NG OgHrvC5KtJR0/rjJrZjAQ1AaFkZOQcWUFnzCDJurEvVV5++w2uGM5aFvbjnF/uN5Frh+ hLtqd5FZmqPJ5hikvt3L2sU2QJ8qe3yej+DWdJgvAoHHl97jXXnNcx7kBjW9v/eczDVD z6sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682002813; x=1684594813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BaYFv/GATacnspxitZxXqy32DjO2LBrHottpHojCTUU=; b=GuCoX2g+OiO8aVTYa7zKY4Ovcs6M6Vnkju6ToAxZcJTfB3PcMx9xxZEyhz5Za2fc87 wlRL5qhGWtOitRLM3ZnR2jjLwvl0ouvkS62Hxox2L8AlqhCzilR/hUsFd6TSOPU6WEUe 3Tntrsz/goWbvSEv3A838rjFfeOITZzAM2O2EwpFQ5sQxtsPyvzWaWr75sn4PUwNJvBI cLmrf34/lholocbtpzjksuZ2jzgPIB7TRIA6RerYsCj5kb4WgxSZswmYLTFmf8K78TUE GDtwOIkj/3WninBD/BwagU85CqLUD+HegXZrNQN+YTxVhrflLgDkoAQ+wEPOt/sFaVv+ cvbA== X-Gm-Message-State: AAQBX9dMMLXcVtFoYNiV5LCxxFx/2tKWFKY1ukV8h71SFiRV+PWInchB Yw2OI446KsFrEj8JZ4IYThS98Q== X-Received: by 2002:a5d:4488:0:b0:2ee:e47e:9014 with SMTP id j8-20020a5d4488000000b002eee47e9014mr1639487wrq.1.1682002812695; Thu, 20 Apr 2023 08:00:12 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m7-20020adfe947000000b003011baf89b3sm2176230wrn.40.2023.04.20.08.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 08:00:11 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2E8431FFBA; Thu, 20 Apr 2023 16:00:10 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Michael Roth , Riku Voipio , Christian Schoenebeck , Yanan Wang , Greg Kurz , Richard Henderson , Kyle Evans , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Eric Blake , Markus Armbruster , Warner Losh , Paolo Bonzini , Marcel Apfelbaum , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH 02/10] trace-events: remove the remaining vcpu trace events Date: Thu, 20 Apr 2023 16:00:01 +0100 Message-Id: <20230420150009.1675181-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230420150009.1675181-1-alex.bennee@linaro.org> References: <20230420150009.1675181-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While these are all in helper functions being designated vcpu events complicates the removal of the dynamic vcpu state code. TCG plugins allow you to instrument vcpu_[init|exit|idle]. Signed-off-by: Alex Bennée --- hw/core/cpu-common.c | 2 -- trace/control-target.c | 1 - trace/control.c | 2 -- trace-events | 31 ------------------------------- 4 files changed, 36 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 5ccc3837b6..8373a500d2 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -112,8 +112,6 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags) void cpu_reset(CPUState *cpu) { device_cold_reset(DEVICE(cpu)); - - trace_guest_cpu_reset(cpu); } static void cpu_common_reset_hold(Object *obj) diff --git a/trace/control-target.c b/trace/control-target.c index 232c97a4a1..c6132f243f 100644 --- a/trace/control-target.c +++ b/trace/control-target.c @@ -145,5 +145,4 @@ void trace_init_vcpu(CPUState *vcpu) } } } - trace_guest_cpu_enter(vcpu); } diff --git a/trace/control.c b/trace/control.c index 6c77cc6318..d24af91004 100644 --- a/trace/control.c +++ b/trace/control.c @@ -277,8 +277,6 @@ void trace_fini_vcpu(CPUState *vcpu) TraceEventIter iter; TraceEvent *ev; - trace_guest_cpu_exit(vcpu); - trace_event_iter_init_all(&iter); while ((ev = trace_event_iter_next(&iter)) != NULL) { if (trace_event_is_vcpu(ev) && diff --git a/trace-events b/trace-events index 691c3533e4..dd318ed1af 100644 --- a/trace-events +++ b/trace-events @@ -54,34 +54,3 @@ qmp_job_resume(void *job) "job %p" qmp_job_complete(void *job) "job %p" qmp_job_finalize(void *job) "job %p" qmp_job_dismiss(void *job) "job %p" - - -### Guest events, keep at bottom - - -## vCPU - -# trace/control-target.c - -# Hot-plug a new virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_enter(void) - -# trace/control.c - -# Hot-unplug a virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_exit(void) - -# hw/core/cpu.c - -# Reset the state of a virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_reset(void) -