From patchwork Mon Apr 3 16:01:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 669794 Delivered-To: patch@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp1964015wrt; Mon, 3 Apr 2023 09:02:32 -0700 (PDT) X-Google-Smtp-Source: AK7set+7ALnYVLtwjRIpRBjRg43WJIKvE6M6JO0Jdhc7xCHgw6kd9z0PXJqgH3J/bfpl8o2nLnNd X-Received: by 2002:a05:6808:18a0:b0:387:205b:70c7 with SMTP id bi32-20020a05680818a000b00387205b70c7mr21635934oib.13.1680537752649; Mon, 03 Apr 2023 09:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680537752; cv=none; d=google.com; s=arc-20160816; b=VdX1WjAsbHdvav6GAHLcvAZ/EYnf4BWr3edE8LyEEQL2DLZV7kpaR/eRCxOE2z0y9W w90duMuIt9Kvg5UJM7QukywhX4QZPK0a3DsTwqWRWD7omc7J/LtHgy6qWXoSi0ShExdr iOrkQ1WKI4q018Jqn5N7YC7UriWPWOJD2zEvvu6KwR/njuriJR5XuZyQuNAOFZt8tcGM vi2TvKnY0KhG/56aIj4W1qf2EIC3cIvaCuzvqtcYT1bzIhE9fnG1rMbE2bdNXzHK9ecQ ghfrYxmMQdFA/+BTq6tdycm19c3SWaHhGADDyOVxdij6su5e0Pm8O6/kqOXsStK0f0AC aNTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=V/wpFoRtLBHl9IngzkoD10ivVrKdxV4x7qoi+Upw/so=; b=qqua4aen6ZdTL/xCc6oQ4pki/vm9R2riSNqFWrphEHTK8mXaZPIUbEundkTaO0Al4O 1k489Gscj+pAwzy82B6F4R/FwmwcOo8R+GT7hiG8vTsfIVLEH2cX3wFbbMqQhlNxqX8d bECskb8XaUFRB3Ix/nusCbn9RwGhD9G0Rq2py7jM1E2IowVlShpgYVuw5Bt5zVD/H4O0 wLLPEmRi4JJeZ5b1vcFaGxeb+dFERNoxU4CEnJPPc7ob4nXqgPkZM39jdwxLG+ZtW0Ag r3EXE+khDT4InQQtZDBVDL+ruIRzzWTF7YKcr3/tdNfnRIxgD1p/ZHBginGW/u+i+ct7 HDjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HtbRkW21; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u5-20020a37ab05000000b00746a69c0233si6056443qke.60.2023.04.03.09.02.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Apr 2023 09:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HtbRkW21; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjMck-00059U-P3; Mon, 03 Apr 2023 12:01:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjMcX-00055R-U7 for qemu-devel@nongnu.org; Mon, 03 Apr 2023 12:01:25 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjMcU-0002BX-Gq for qemu-devel@nongnu.org; Mon, 03 Apr 2023 12:01:24 -0400 Received: by mail-wr1-x42f.google.com with SMTP id m2so29891628wrh.6 for ; Mon, 03 Apr 2023 09:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680537681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=V/wpFoRtLBHl9IngzkoD10ivVrKdxV4x7qoi+Upw/so=; b=HtbRkW21a7zfV7ELZNgGd5IQ/ZL/bdRZBqsompvJMKp/Sf4tiPzXzz31OAGoxmdBRF 14mhAHYIj0V7WvixvaGjBalgooKBJcVieG2Zml/AeTeXPZwI9tcpp/5GqNZVuQsvhJFk 69Xbc5DcAsbD9ZPQz/feKXpa3hKgO7knmr6Q7gmROpAnn4zGyZm2uLKRvaoapwhlXycW gVattwbREYY9qipBBGhGd6eSoDrRwfPtF5k+mlm2xtexz+l7SMuSrCtRquzOtKkYh0dv TZTwYIh5NeWjyOtKb/zxDOGlZNC/306mIHS68maNFVUwnwZ2qcoAbKb+4UvB/+m0tyqq 7BDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680537681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V/wpFoRtLBHl9IngzkoD10ivVrKdxV4x7qoi+Upw/so=; b=qlnIafhHdMEbkibCcOSpIWJbFRFbU7HY9TAd/GUcVjGpF+mKws6CHjZeyisAJB6wPh YWsve2JO8mWCvrGAJ6HqQ4Ah4iDT7uP1ylDpVycMb8IurpgutTyxN+k3XoWLRntX5SxM IsJKJ5TYUnj+2KtwRZPSYpC58KXdyDW5k6DM6qczUy4jtArNeM/smLZxgvb2iCYMINPS D1/lKnLl35V5ZkOR+CDBAvvKmeAAdR6Up0zQl0PuqjHmvtlR4cr3iAu9lc7ro3rJ4M1u fL4HWcddPwaJoBEsPxNOIWYj+Ky12L8ajh6vcVPPEy2VcWZQd3a1KWzi5lpzRme8jmV/ XIqg== X-Gm-Message-State: AAQBX9cWYbiXaWFw8dvHEUUkXlSY6DxxdxV5cSfnwzD4MWJXy+LGsQWf 5nA9tmUeaHGmhH6amQsgtB+Y0ToelDPZ+Wx9bzk= X-Received: by 2002:a5d:6ac8:0:b0:2e4:cc1c:102c with SMTP id u8-20020a5d6ac8000000b002e4cc1c102cmr12430466wrw.48.1680537681185; Mon, 03 Apr 2023 09:01:21 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id p1-20020a5d68c1000000b002c59f18674asm10088668wrw.22.2023.04.03.09.01.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 09:01:20 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/4] hw/ssi: Fix Linux driver init issue with xilinx_spi Date: Mon, 3 Apr 2023 17:01:17 +0100 Message-Id: <20230403160117.3034102-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230403160117.3034102-1-peter.maydell@linaro.org> References: <20230403160117.3034102-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Chris Rauer The problem is that the Linux driver expects the master transaction inhibit bit(R_SPICR_MTI) to be set during driver initialization so that it can detect the fifo size but QEMU defaults it to zero out of reset. The datasheet indicates this bit is active on reset. See page 25, SPI Control Register section: https://www.xilinx.com/content/dam/xilinx/support/documents/ip_documentation/axi_quad_spi/v3_2/pg153-axi-quad-spi.pdf Signed-off-by: Chris Rauer Message-id: 20230323182811.2641044-1-crauer@google.com Reviewed-by: Edgar E. Iglesias Signed-off-by: Peter Maydell --- hw/ssi/xilinx_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c index 552927622f4..d4de2e7aabc 100644 --- a/hw/ssi/xilinx_spi.c +++ b/hw/ssi/xilinx_spi.c @@ -156,6 +156,7 @@ static void xlx_spi_do_reset(XilinxSPI *s) txfifo_reset(s); s->regs[R_SPISSR] = ~0; + s->regs[R_SPICR] = R_SPICR_MTI; xlx_spi_update_irq(s); xlx_spi_update_cs(s); }