From patchwork Thu Mar 9 20:05:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 661113 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp502122wrb; Thu, 9 Mar 2023 12:20:42 -0800 (PST) X-Google-Smtp-Source: AK7set/iWe6BkPMBcjf+OhyApdrQqGIivdwLSqGpj5+/Fn3wLpqkcjoTMvSBDN5vUZTQlCMJBsWN X-Received: by 2002:a05:600c:c10:b0:3eb:248f:a13e with SMTP id fm16-20020a05600c0c1000b003eb248fa13emr499437wmb.22.1678393241959; Thu, 09 Mar 2023 12:20:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678393241; cv=none; d=google.com; s=arc-20160816; b=s15GWIfQlSQKHlzllv7nfhLquIrxgLq/En9XpeIDdSuCypnv2rV4vaxwVMzDpUUMFf 0Op0MNtFJqnVpLb9dhL5xf0oG43zGuu+GuwlM6gfUeq82DVNTWDJ5ylk5cloc3wHmCOb FGB2MTZHHpmfBm6s6lNI6dA6+lZjvUlk+kjPc1X5rFPBbwIgUHYr6o5XDmcvB0JdpXo6 qafgNgZkxxhAYN9WEwHSsr5t0gKAZj/IHCtHQD9VYh6zMXgQkEXufIyBa+03Na87tzeq uxbZFHOeu5J++f9q5h9jREQXw8FSwbcxcGUtJcdB/aJFLcC1TJFftbVfJT157a72Wwhh Cwdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yIghDNpSxJ6SxdMMppMACLdakWq5GNMtoSah4rU7gww=; b=fKpxnHoG4R4mZSZPBRAWFExbtOXr0KGbvLMIaybMW9cfLUjbG4ZSG75ly8A1WGRwIk PovNP8mZGPt6VhRPPooNWt0Kb9Eo9eGPlLCEgDU5PgvINiv6z/Ldk3CuX4aKoa4B5/Bx op8Y7gTmUbhVbLCDKHSLbpVNywejpEH8aY7z4dk43xNTbqRuKzuQ1bu0dYBCe3x7SUjc 9E4JTClvQWyzyDUz1CokT2WHzoyoa3puMFhUe+Eigqbw+T/kZRonWxKTTcW+XE6hki8T nvPcT9qg/rKfjZy/l36ulQNYjn9jiEyb5wRkNEmBzxSybG6LwyHglm23m+OU6LdVj8zT /fOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pj1KNx90; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a17-20020a5d5091000000b002c560e7f503si307048wrt.641.2023.03.09.12.20.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Mar 2023 12:20:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pj1KNx90; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paMaN-0005Mw-KG; Thu, 09 Mar 2023 15:09:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paMaK-00052b-8n for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:09:56 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paMaI-0001bb-If for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:09:55 -0500 Received: by mail-pl1-x62a.google.com with SMTP id p6so3272406plf.0 for ; Thu, 09 Mar 2023 12:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678392593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yIghDNpSxJ6SxdMMppMACLdakWq5GNMtoSah4rU7gww=; b=pj1KNx90wAYf5Mw1ObQUz7dQYGB4s07tczb/UABrDyIqn2+gLjoOw0CmFl4QhJGiY2 niaz31ahY+FtXJMe9HSbGOZ3Db9NBVHrmoW4k/2f3b1siqoROnfjU2VfFeU7n8K86Xsz OC9V1/U+TVGc7mORfHvvfzYqwct+Vf97wMzzxAFHdOOVnH07kiWJM2bY1DxWW6YhRpLn Nr/fKkyDLcUkj9uzsUkHvNW/nx4TzheSuANC5FfGFxvHYckW9zhcJDVH+TlFGphq9YkQ VR207dBYjgU42/n66Cg4Et6w/Ig/rYlHDZH2ygAhmRGUtp+elgJvtb+ihk692gZO7keP YJ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678392593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yIghDNpSxJ6SxdMMppMACLdakWq5GNMtoSah4rU7gww=; b=DXotkksTLGClJQmJtEiyVabF3IM8u2lhUFtdw+6UQU2KvxRw0W1MkKN7T/BNVsk5LD Q9vnjE6RUMeDrQQtmN0FqNKvzSX60JYdP5DMZTHM8W+T2WPS/5E+4b1Smdx58XqRfjMZ Pns3cqoMOg7ChCOQ6l5yKWAgYDeBbiddIe8ZBX6G9eeD4j8LPgnnta2afOmPmXyrRFZ3 ntt7h1ONH0VSq+ZhqE8GWyLq84r6wkA4xfLkynJXaiiNjljdJ5mkBRBZTES9mhe2Ki1o vgMeUlFZUAbMbGk+gNw9O255M94gX5JGvCO5Ox/tlo3PzKeSNjRoeY57nlLsHkAyEUak LUGA== X-Gm-Message-State: AO0yUKUszt7tQbRBwP8G7YaZbHxBVyX6d02O7KdRfuK9n7enm0ivJd6U PXLp7A75cq3VaBmcdr29ReT/8g6XQ5YicoJZgHA= X-Received: by 2002:a17:903:22c4:b0:19d:1897:8192 with SMTP id y4-20020a17090322c400b0019d18978192mr27629500plg.47.1678392593215; Thu, 09 Mar 2023 12:09:53 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:bf7f:79a0:a976:bdaf]) by smtp.gmail.com with ESMTPSA id c2-20020a170902aa4200b001991e4e0bdcsm43797plr.233.2023.03.09.12.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 12:09:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL v2 69/91] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf Date: Thu, 9 Mar 2023 12:05:28 -0800 Message-Id: <20230309200550.3878088-70-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230309200550.3878088-1-richard.henderson@linaro.org> References: <20230309200550.3878088-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While this enumerator has been present since the first commit, it isn't ever used. The first actual use of round-to-odd came with SVE, which currently uses float_round_to_odd instead of the arm-specific enumerator. Amusingly, the comment about unhandled TIEAWAY has been out of date since the initial commit of translate-a64.c. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/vfp_helper.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index 24e3d820a5..90cc324f71 100644 --- a/target/arm/vfp_helper.c +++ b/target/arm/vfp_helper.c @@ -1111,10 +1111,8 @@ int arm_rmode_to_sf(int rmode) rmode = float_round_ties_away; break; case FPROUNDING_ODD: - /* FIXME: add support for TIEAWAY and ODD */ - qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode: %d\n", - rmode); - /* fall through for now */ + rmode = float_round_to_odd; + break; case FPROUNDING_TIEEVEN: default: rmode = float_round_nearest_even;