From patchwork Thu Mar 9 20:04:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 661058 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp497366wrb; Thu, 9 Mar 2023 12:09:51 -0800 (PST) X-Google-Smtp-Source: AK7set8g4FQA9s+vxUWMqKyigN2CuvkBgRdh1SsJBYrIJ+kbKZ/lvxM/Ziv/yCUhM0ldwqvVKWmQ X-Received: by 2002:a05:6000:1a54:b0:2ca:6cb1:c9c5 with SMTP id t20-20020a0560001a5400b002ca6cb1c9c5mr15824181wry.30.1678392591098; Thu, 09 Mar 2023 12:09:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678392591; cv=none; d=google.com; s=arc-20160816; b=PlT4F7EsWwimlrihXnRn7EPMGiiTWK0hiTgvrIH7l9DDZTMgZfVBbwZ7tIsvtfyyHL 4hjCAZ/p9XTod26bwJwk6h4a9LcYZfwHhDoWXEkOsUWwmEVOK7b/Ikb4ZE1Q79u93Slf 20krlVeYtfGT5LkA1OBt+sCmEhfy0CO+jQFQ7qb8zutB9t5vxrt44KlJ5MX3ya8fxjLz aa2fDirhDPa5WX/IUHWUvO2uj76unj+DxJ6I2zs9BZhmDpoH3hpdOKgOFQ78MjY1OvGe dsaN7fw0osVpj4Zrn8HJB4fbsNk3751mkwluPLFgkhNVuNTcTHmGaZjEWdSbqJ40CvHd iH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=HfulFq+Cqr2VBSRU7AkG7rg7ZJVIwh0u6Fm6fWeEAgGptRwssfZ7174r9ts2xTf0OU vR5xaUcGP+9AyGqFJWmukUP5NBQ7YLHzB+C7Knh7O6ARjdiImNmy8rnt2Poy/3PxUB9j OfQoIDCiFqB+DZrumqKDPTnjb7/kBTMmnuO/7iotJciqjspVbkGal5el4rPDHNe5liua jOVpzwqsMVSPd7LpQqXvEkvRJuBoPDtQOit8QiPLKf50fuZMC0U8uAQ7n56gIT6WqCh+ GjNcO17rLdNmpfrVdkWSzFd3rrtU+L2U2rjNx3SLI17y786B04O4uOaaakrjN4itmi/J LCZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d6qVBPjJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a9-20020adfeec9000000b002c55dc05a54si294645wrp.572.2023.03.09.12.09.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Mar 2023 12:09:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d6qVBPjJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paMWg-0004Lc-Nl; Thu, 09 Mar 2023 15:06:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paMWe-0004B4-IF for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:06:08 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paMWb-0000ik-QM for qemu-devel@nongnu.org; Thu, 09 Mar 2023 15:06:08 -0500 Received: by mail-pl1-x631.google.com with SMTP id y11so3231473plg.1 for ; Thu, 09 Mar 2023 12:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678392364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=d6qVBPjJkP2N1no44GzGk2wy1YkjXa+rnWyyC1S0Dn/NuKE2CnKEgzaK8GOfJ2UdiR V9u41q4YpLVhCPYtv5rTGinR6mNtpmOtWFGwuZ4IG635AoW9aT/IKQ0PIxtQvfKGP5ck 79wxSB9gkDUV5+eXwYxFVMxrqI+ywJc4yMduL4bySEAaii3e52dSzR3P+QOqVP2fr/hH 4aYraIZWsFDmRVFwWWreWaewAdR8XnvxhbD9Dn9RZlNKkjyb9Xuhj+axZIYPe5yfgk/S 5Eyi5eHvjdkPMseEEM1jsDwJHL98q3FB+lPJ3RfO5se615kq/A9fU20941UaxbFZ/D7w /kgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678392364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=R4ZSOHVu+ZuedHZF/aduAxJFGVlval+y958CQIwfO+x4BehJRFUSVhr/fLgrEhdNHb h2KbPSEov9iWEGfcrZB7rYVHSDWtwFMYJskTibleOU4mjsYD4qBlO25G6Jdsr7KRO/aZ hTme6sPIGADz7vGCVqlv3cqoBQyhZw7LOrUnpzCvXWoEbOqgI/ZMSZdUdIDxkP3WNcN0 e3KexfSpdbyQ+qY31zBG5JCocvHrqJbmR/OFVcgjtl9Q+iwQzN/MiFz2qSOL3iHE4zBE 1hzsOBDJ83FwbOd19kEptMuwJYY1hL17MIW6SDbV56Q/BySN6SePsFVOxwO4ofSARMK3 4qlQ== X-Gm-Message-State: AO0yUKVjntzNrX4GaPIk8UG66Jn6mGOFAXsNNsJ9T9jk8++dt5SsXSIF xXiMido2NbK/WgvzKTPMaLgR4FobQz/99HgZ7zE= X-Received: by 2002:a17:90b:4acd:b0:22c:4d85:1725 with SMTP id mh13-20020a17090b4acd00b0022c4d851725mr24058656pjb.9.1678392364518; Thu, 09 Mar 2023 12:06:04 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:bf7f:79a0:a976:bdaf]) by smtp.gmail.com with ESMTPSA id t20-20020a17090ad15400b002340f58e19bsm308083pjw.45.2023.03.09.12.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 12:06:04 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, David Hildenbrand , Ilya Leoshkevich , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL v2 14/91] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext Date: Thu, 9 Mar 2023 12:04:33 -0800 Message-Id: <20230309200550.3878088-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230309200550.3878088-1-richard.henderson@linaro.org> References: <20230309200550.3878088-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org These fields are no longer read, so remove them and the writes. Acked-by: David Hildenbrand Reviewed-by: Ilya Leoshkevich Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 9ad6e75434..7969051ce9 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1061,7 +1061,6 @@ static const DisasFormatInfo format_info[] = { them, and store them back. See the "in1", "in2", "prep", "wout" sets of routines below for more details. */ typedef struct { - bool g_out, g_out2, g_in1, g_in2; TCGv_i64 out, out2, in1, in2; TCGv_i64 addr1; TCGv_i128 out_128, in1_128, in2_128; @@ -3159,9 +3158,7 @@ static DisasJumpType op_mc(DisasContext *s, DisasOps *o) static DisasJumpType op_mov2(DisasContext *s, DisasOps *o) { o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; return DISAS_NEXT; } @@ -3171,9 +3168,7 @@ static DisasJumpType op_mov2e(DisasContext *s, DisasOps *o) TCGv ar1 = tcg_temp_new_i64(); o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; switch (s->base.tb->flags & FLAG_MASK_ASC) { case PSW_ASC_PRIMARY >> FLAG_MASK_PSW_SHIFT: @@ -3202,11 +3197,8 @@ static DisasJumpType op_movx(DisasContext *s, DisasOps *o) { o->out = o->in1; o->out2 = o->in2; - o->g_out = o->g_in1; - o->g_out2 = o->g_in2; o->in1 = NULL; o->in2 = NULL; - o->g_in1 = o->g_in2 = false; return DISAS_NEXT; } @@ -3708,7 +3700,6 @@ static DisasJumpType op_rosbg(DisasContext *s, DisasOps *o) /* If this is a test-only form, arrange to discard the result. */ if (i3 & 0x80) { o->out = tcg_temp_new_i64(); - o->g_out = false; } i3 &= 63; @@ -4874,7 +4865,6 @@ static DisasJumpType op_zero2(DisasContext *s, DisasOps *o) { o->out = tcg_const_i64(0); o->out2 = o->out; - o->g_out2 = true; return DISAS_NEXT; } @@ -5142,7 +5132,6 @@ static void prep_new_x(DisasContext *s, DisasOps *o) static void prep_r1(DisasContext *s, DisasOps *o) { o->out = regs[get_field(s, r1)]; - o->g_out = true; } #define SPEC_prep_r1 0 @@ -5151,7 +5140,6 @@ static void prep_r1_P(DisasContext *s, DisasOps *o) int r1 = get_field(s, r1); o->out = regs[r1]; o->out2 = regs[r1 + 1]; - o->g_out = o->g_out2 = true; } #define SPEC_prep_r1_P SPEC_r1_even @@ -5375,7 +5363,6 @@ static void in1_r1(DisasContext *s, DisasOps *o) static void in1_r1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1)]; - o->g_in1 = true; } #define SPEC_in1_r1_o 0 @@ -5409,7 +5396,6 @@ static void in1_r1p1(DisasContext *s, DisasOps *o) static void in1_r1p1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1) + 1]; - o->g_in1 = true; } #define SPEC_in1_r1p1_o SPEC_r1_even @@ -5464,7 +5450,6 @@ static void in1_r3(DisasContext *s, DisasOps *o) static void in1_r3_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r3)]; - o->g_in1 = true; } #define SPEC_in1_r3_o 0 @@ -5595,7 +5580,6 @@ static void in1_m1_64(DisasContext *s, DisasOps *o) static void in2_r1_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r1)]; - o->g_in2 = true; } #define SPEC_in2_r1_o 0 @@ -5630,7 +5614,6 @@ static void in2_r2(DisasContext *s, DisasOps *o) static void in2_r2_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r2)]; - o->g_in2 = true; } #define SPEC_in2_r2_o 0