From patchwork Tue Mar 7 18:34:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659821 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2540618wrb; Tue, 7 Mar 2023 10:36:09 -0800 (PST) X-Google-Smtp-Source: AK7set/9Jyxg0atad9kVrwSttAsQuC/zqpUC7gnaPqA7+5eKEGfV4A5YkaCm0E/ISwYJhMMiMlP7 X-Received: by 2002:ac8:5f54:0:b0:3b9:bc8c:c210 with SMTP id y20-20020ac85f54000000b003b9bc8cc210mr33118035qta.27.1678214169295; Tue, 07 Mar 2023 10:36:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678214169; cv=none; d=google.com; s=arc-20160816; b=KlhmwdL7iUjiRWnoyn6VzHpuGMunNL+XwcBbPa0OlDTatUaGgax5fZr09ptFy4FOJY wKO3M1T4pElUxe5LcT37sq0lEH3sgmXsywETWGfvBAWwRdn1KeFWdEvyXj/au0Q6NsEJ XvULA6garBrZ1Y4sAnAUb4H/SNEpiCdv4IqdN7JvzM2KO8h11JjcOZHcxs9pRStQhMzx Fk+/MisDvQUB+sDgUonvU1OcfnMlIZS7pDbV5pMKaYk8ScMPjzL0mDPCunikgdRgeUm4 MH4krQC6X6BdIiNh2HvkXmS/lVA9DeoJgIZClE5BOpC0wCtIRW8vR87z760tytA7xMND QzZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ob6o2+PyWVMcZzAwGqvOjE3dmqAG4vSrJnMbHtf/LLI=; b=Hb6qmbmcqKlAImnwnDhM5THT4OlZ5+VBG+lh1lU5BZ4RxorxKiE0ZrplNvEZSqswgT nTyZV28kPJrafi3fknlmhP1ZQoTC1lpiycfRnzcmeCy6AVxlfXYH416v5VTN4pU9sM4w JVplW73ZeF659WT165hvs9/MfAtqCHAemdKu/wzEfQWVrzfu3Kmn9B7Ml0PltxI5NrLr ogwfNqD64/69AgrPEZF/KX9lf7900wKOCiPlNwqNk1dCyhWNrFrlnmcyzsvuME2U3vVH 1WrfdkmpMt94iftBXFLjKwPuhgNCJkV/41yX4Iry6j9kj8wFv7mwygUWoEDmEOOPLIpj cykA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5nTPWYo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u19-20020a05620a0c5300b0071eb8581636si11331946qki.666.2023.03.07.10.36.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2023 10:36:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d5nTPWYo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZc9h-0003i0-0z; Tue, 07 Mar 2023 13:35:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZc9f-0003e5-Az for qemu-devel@nongnu.org; Tue, 07 Mar 2023 13:35:19 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZc9d-0007jU-Mu for qemu-devel@nongnu.org; Tue, 07 Mar 2023 13:35:19 -0500 Received: by mail-pl1-x62f.google.com with SMTP id v11so15108294plz.8 for ; Tue, 07 Mar 2023 10:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678214117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ob6o2+PyWVMcZzAwGqvOjE3dmqAG4vSrJnMbHtf/LLI=; b=d5nTPWYoN300jTLNIIwcf82EgaX5/2v79sfJm8QFadwHkc3uDP2sqmPf3KIEi1I/24 6cOYQpUgWgpRDJqbR3lrIT9Hz0PNx8IBRkPbXEFzmv9/CmY9+yAnNGwZfATCjm2y5ozP souiqp9TKYnP/qdyvIAxk4mLrf94JDxQnaUqA/YOmUkCFzGN1xto1iAkCtnNhmqU1Gr/ 2HeqhgpB3TwShB0s82wHBZu2scrR6ya3nFeEou6XSmAOCmnA94UGakI8KnNhRnl5Bjo1 COwnPlb8vx1OTOJhg4SHRggk08jOSoAuPEIK4WS2GzRZqDwwmgvhce9x+nIp9UaUsrvY oeCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678214117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ob6o2+PyWVMcZzAwGqvOjE3dmqAG4vSrJnMbHtf/LLI=; b=SAwkVyoxK+YCMpMeQJlQz/YrzEhk5Xmh9oJ3dNXueKTCV6wL/0w54igqIzpEN+WlnO OvAjrLyWkBDWY4x2Uhbb0JSGEFgeP8Mti7MOMT7ZGXss6z8msmyO7k8tCddW/+v+5Rhg Cp0qwnxM9RbcUsVB5ZX8f31rnwZ3jUSIiDyThFyv4ZWJOX8026HnKe2MWsiesim+A1To SOi/AW78D1qyQDQsIVPIofAW5jD3+jeTmQqeXsJVIhdqEc5lecluz25zIzoSqhXDSZ6i NqiG0N/t1YgIfN+X/mqamIkiOPijOe2opCs08X4IQFQBULPkFGT7YYkoLsiVe7+M3nuy 0HUA== X-Gm-Message-State: AO0yUKVoNQK/U96yU6EdyJ+8D2NJIgU+5emBT23lTwFY2Gkq4c7VNntI QXvCfrDHhhsYVILHxHr+RRKf/MHlWfbVe9BWzD0= X-Received: by 2002:a17:90b:1bc5:b0:233:affd:a96c with SMTP id oa5-20020a17090b1bc500b00233affda96cmr19382846pjb.16.1678214116915; Tue, 07 Mar 2023 10:35:16 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:b1e0:bfd9:8b1a:efeb]) by smtp.gmail.com with ESMTPSA id q1-20020a17090a1b0100b0022c0a05229fsm7757940pjq.41.2023.03.07.10.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 10:35:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , =?utf-8?q?C=C3=A9dric_L?= =?utf-8?q?e_Goater?= , David Gibson , Greg Kurz , qemu-ppc@nongnu.org Subject: [PATCH v2 16/25] target/ppc: Avoid tcg_const_* in xxeval Date: Tue, 7 Mar 2023 10:34:54 -0800 Message-Id: <20230307183503.2512684-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230307183503.2512684-1-richard.henderson@linaro.org> References: <20230307183503.2512684-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Initialize a new temp instead of tcg_const_*. Fix a pasto in a comment. Signed-off-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daudé --- Cc: Daniel Henrique Barboza Cc: Cédric Le Goater Cc: David Gibson Cc: Greg Kurz Cc: qemu-ppc@nongnu.org --- target/ppc/translate/vsx-impl.c.inc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc index 6e63403727..9916784e64 100644 --- a/target/ppc/translate/vsx-impl.c.inc +++ b/target/ppc/translate/vsx-impl.c.inc @@ -2449,7 +2449,8 @@ static void gen_xxeval_i64(TCGv_i64 t, TCGv_i64 a, TCGv_i64 b, TCGv_i64 c, TCGv_i64 conj, disj; conj = tcg_temp_new_i64(); - disj = tcg_const_i64(0); + disj = tcg_temp_new_i64(); + tcg_gen_movi_i64(disj, 0); /* Iterate over set bits from the least to the most significant bit */ while (imm) { @@ -2492,8 +2493,9 @@ static void gen_xxeval_vec(unsigned vece, TCGv_vec t, TCGv_vec a, TCGv_vec b, int bit; TCGv_vec disj, conj; - disj = tcg_const_zeros_vec_matching(t); conj = tcg_temp_new_vec_matching(t); + disj = tcg_temp_new_vec_matching(t); + tcg_gen_dupi_vec(vece, disj, 0); /* Iterate over set bits from the least to the most significant bit */ while (imm) { @@ -2546,7 +2548,7 @@ static bool trans_XXEVAL(DisasContext *ctx, arg_8RR_XX4_imm *a) /* Equivalent functions that can be implemented with a single gen_gvec */ switch (a->imm) { - case 0b00000000: /* true */ + case 0b00000000: /* false */ set_cpu_vsr(a->xt, tcg_constant_i64(0), true); set_cpu_vsr(a->xt, tcg_constant_i64(0), false); break;