diff mbox series

[v2,15/25] target/ppc: Avoid tcg_const_* in vmx-impl.c.inc

Message ID 20230307183503.2512684-16-richard.henderson@linaro.org
State Superseded
Headers show
Series tcg: Remove tcg_const_* | expand

Commit Message

Richard Henderson March 7, 2023, 6:34 p.m. UTC
All remaining uses are strictly read-only.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: Cédric Le Goater <clg@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org
---
 target/ppc/translate/vmx-impl.c.inc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Daniel Henrique Barboza March 7, 2023, 9:42 p.m. UTC | #1
On 3/7/23 15:34, Richard Henderson wrote:
> All remaining uses are strictly read-only.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: qemu-ppc@nongnu.org
> ---
>   target/ppc/translate/vmx-impl.c.inc | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/target/ppc/translate/vmx-impl.c.inc b/target/ppc/translate/vmx-impl.c.inc
> index ca27c11d87..112233b541 100644
> --- a/target/ppc/translate/vmx-impl.c.inc
> +++ b/target/ppc/translate/vmx-impl.c.inc
> @@ -1624,7 +1624,7 @@ static void glue(gen_, name)(DisasContext *ctx)                         \
>               gen_exception(ctx, POWERPC_EXCP_VPU);                       \
>               return;                                                     \
>           }                                                               \
> -        uimm = tcg_const_i32(UIMM5(ctx->opcode));                       \
> +        uimm = tcg_constant_i32(UIMM5(ctx->opcode));                    \
>           rb = gen_avr_ptr(rB(ctx->opcode));                              \
>           rd = gen_avr_ptr(rD(ctx->opcode));                              \
>           gen_helper_##name(cpu_env, rd, rb, uimm);                       \
> @@ -1965,7 +1965,7 @@ static void gen_vsldoi(DisasContext *ctx)
>       ra = gen_avr_ptr(rA(ctx->opcode));
>       rb = gen_avr_ptr(rB(ctx->opcode));
>       rd = gen_avr_ptr(rD(ctx->opcode));
> -    sh = tcg_const_i32(VSH(ctx->opcode));
> +    sh = tcg_constant_i32(VSH(ctx->opcode));
>       gen_helper_vsldoi(rd, ra, rb, sh);
>   }
>   
> @@ -2575,7 +2575,7 @@ static void gen_##op(DisasContext *ctx)             \
>       rb = gen_avr_ptr(rB(ctx->opcode));              \
>       rd = gen_avr_ptr(rD(ctx->opcode));              \
>                                                       \
> -    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
> +    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
>                                                       \
>       gen_helper_##op(cpu_crf[6], rd, ra, rb, ps);    \
>   }
> @@ -2594,7 +2594,7 @@ static void gen_##op(DisasContext *ctx)             \
>       rb = gen_avr_ptr(rB(ctx->opcode));              \
>       rd = gen_avr_ptr(rD(ctx->opcode));              \
>                                                       \
> -    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
> +    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
>                                                       \
>       gen_helper_##op(cpu_crf[6], rd, rb, ps);        \
>   }
> @@ -2726,7 +2726,7 @@ static void gen_##op(DisasContext *ctx)       \
>       }                                         \
>       ra = gen_avr_ptr(rA(ctx->opcode));        \
>       rd = gen_avr_ptr(rD(ctx->opcode));        \
> -    st_six = tcg_const_i32(rB(ctx->opcode));  \
> +    st_six = tcg_constant_i32(rB(ctx->opcode));  \
>       gen_helper_##op(rd, ra, st_six);          \
>   }
>
Philippe Mathieu-Daudé March 9, 2023, 9:49 a.m. UTC | #2
On 7/3/23 19:34, Richard Henderson wrote:
> All remaining uses are strictly read-only.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: qemu-ppc@nongnu.org
> ---
>   target/ppc/translate/vmx-impl.c.inc | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/target/ppc/translate/vmx-impl.c.inc b/target/ppc/translate/vmx-impl.c.inc
index ca27c11d87..112233b541 100644
--- a/target/ppc/translate/vmx-impl.c.inc
+++ b/target/ppc/translate/vmx-impl.c.inc
@@ -1624,7 +1624,7 @@  static void glue(gen_, name)(DisasContext *ctx)                         \
             gen_exception(ctx, POWERPC_EXCP_VPU);                       \
             return;                                                     \
         }                                                               \
-        uimm = tcg_const_i32(UIMM5(ctx->opcode));                       \
+        uimm = tcg_constant_i32(UIMM5(ctx->opcode));                    \
         rb = gen_avr_ptr(rB(ctx->opcode));                              \
         rd = gen_avr_ptr(rD(ctx->opcode));                              \
         gen_helper_##name(cpu_env, rd, rb, uimm);                       \
@@ -1965,7 +1965,7 @@  static void gen_vsldoi(DisasContext *ctx)
     ra = gen_avr_ptr(rA(ctx->opcode));
     rb = gen_avr_ptr(rB(ctx->opcode));
     rd = gen_avr_ptr(rD(ctx->opcode));
-    sh = tcg_const_i32(VSH(ctx->opcode));
+    sh = tcg_constant_i32(VSH(ctx->opcode));
     gen_helper_vsldoi(rd, ra, rb, sh);
 }
 
@@ -2575,7 +2575,7 @@  static void gen_##op(DisasContext *ctx)             \
     rb = gen_avr_ptr(rB(ctx->opcode));              \
     rd = gen_avr_ptr(rD(ctx->opcode));              \
                                                     \
-    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
+    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
                                                     \
     gen_helper_##op(cpu_crf[6], rd, ra, rb, ps);    \
 }
@@ -2594,7 +2594,7 @@  static void gen_##op(DisasContext *ctx)             \
     rb = gen_avr_ptr(rB(ctx->opcode));              \
     rd = gen_avr_ptr(rD(ctx->opcode));              \
                                                     \
-    ps = tcg_const_i32((ctx->opcode & 0x200) != 0); \
+    ps = tcg_constant_i32((ctx->opcode & 0x200) != 0); \
                                                     \
     gen_helper_##op(cpu_crf[6], rd, rb, ps);        \
 }
@@ -2726,7 +2726,7 @@  static void gen_##op(DisasContext *ctx)       \
     }                                         \
     ra = gen_avr_ptr(rA(ctx->opcode));        \
     rd = gen_avr_ptr(rD(ctx->opcode));        \
-    st_six = tcg_const_i32(rB(ctx->opcode));  \
+    st_six = tcg_constant_i32(rB(ctx->opcode));  \
     gen_helper_##op(rd, ra, st_six);          \
 }