From patchwork Tue Mar 7 17:58:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659810 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2527585wrb; Tue, 7 Mar 2023 10:08:29 -0800 (PST) X-Google-Smtp-Source: AK7set/ai6MMNqh3Tve1Y3n5fXGDRGGcClMrXNpG7w/HxYgOlkzkxvLFYtMBf3MXl8r0NgFUud2p X-Received: by 2002:a05:6214:5299:b0:56e:b96c:2e03 with SMTP id kj25-20020a056214529900b0056eb96c2e03mr27161155qvb.25.1678212509758; Tue, 07 Mar 2023 10:08:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678212509; cv=none; d=google.com; s=arc-20160816; b=bLeH4AY6wwu2yfCRI9usAuoluOspfH+1CXC1uWyUi47W3CxzgA+tRwsCUPkWIdC4Iv Greta/QHFkHQByhHi88Z6mNKPL27zXMWax7gzZKRL2QnQGRKD/cMDd4bsDjpm8rZyzio hr06ZLcPM4ZZ9qaTMWe9wftQ753BIflo2K3zoVPd6Zb8MBpOJZqASE8GUBS8Cg2LZXz0 60NFAjqVBsJeLnqPIZfH3P/UWfVv2epj+rzV4WiGe7FApJxbt46O1muQcrkDwOR8QwVP Zp6A8o9Z8g/S8Um3CJNG1T9e0c27WzXtPEBcQnLF97uPLd+Yvyt/ojrqUYzKfIZI0iS0 MEvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GmSQ5EsnhiBz2/bI7UFdGFdPdrCS0Ujyapsg1y1C9MU=; b=WeLBeYFTjVYG1dh7ZsHwy03k7Ni7oORHPDrRIAShzqZolq8hcncL3guBzg983f8vz+ nU9sv29eDnmkpLTto+FAzZ/VWxtBFDjcc+f/4ssWCJqFVyd9AUddd/F5/jJXlqakUkrc UTOId4k8K4Ek6syh+5lC1YZUHuQepsjV20fzsTecYgto2GnTmpXVuRu0n8omkrVIrb81 2uhSXdDIhxisf7weS789sO52AkSHau37soxOnfAi8ctD3eDALYwpffUtW+K5W6lxJq1A Ir1ZQMWHnnMbdnDmV2/dny4qTgnBw5XH7QNgEJX7GeWtBlEzqbC0xnIcd3KG1iQdswtr ZiFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bgqfJkmv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e16-20020a0cf350000000b0056ea3d10d19si9784925qvm.396.2023.03.07.10.08.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2023 10:08:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bgqfJkmv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZbe8-0003ku-7K; Tue, 07 Mar 2023 13:02:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZbe5-0003Mf-SO for qemu-devel@nongnu.org; Tue, 07 Mar 2023 13:02:41 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZbe4-00018p-9O for qemu-devel@nongnu.org; Tue, 07 Mar 2023 13:02:41 -0500 Received: by mail-pg1-x531.google.com with SMTP id 16so8097082pge.11 for ; Tue, 07 Mar 2023 10:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678212159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GmSQ5EsnhiBz2/bI7UFdGFdPdrCS0Ujyapsg1y1C9MU=; b=bgqfJkmv8NYvoRawcdA60xm8ui/RX5EZLcgQaW84lQKergz3T53hZ/E5zFbaJmvLpH tvee6214B2oxvUgJImPCH/pqUbe0rjh2H8UTBmeXIJj7TaQPrI+uLSAEqP/rDnuHZv2B nVGxeZRbQfSIy1zzFSkzu+ZZkXUEgVPpWB5egdr+fAtITFB2nfKXmZ60EhC/FZ+3ksXs s6gD9fWOCZ5mEQt9J2XpJvORHjLhCYNj/SRJS5llIciKT+cCgN1FYQtLIiCTgTnvKfgB YVbJht40Gj13ISK+TY5/5YjzQLCcqgJti9J4yYAgpmJF/HB5/Le+BSLXJqswHtif4vUI PKpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678212159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmSQ5EsnhiBz2/bI7UFdGFdPdrCS0Ujyapsg1y1C9MU=; b=mI1zCaPCq/poJbI7uoi2zOz65/8jovHGlPyIC/4od7h57FXI2JuSYb8RcXYe/iS8o5 31ZH20klR1Y3kILtuc71siyo8fwIc8gIj1ZDxEuiW/z4YtNjbC2eCaojw3aitmOfdOAD 3P5UX96nIQdOz1udhwYfKIsnR4aDnCZHW9dEy1gg3mh9MEtxfQNMg9FzHuO3xw+aG2pH eTpCXcoS8Wnwao4KorR3hfqoXqUvori5Aj1bl1ZpJkXfyFLB/02d8JIhf+i/hcEQtUwN mvyNU2caBu7EkU7ApbmZt33ZLrM9aXlDuqfIHvQiJ4/lIIuCRHjqy9ouyzq3O/niZNIY 25Lg== X-Gm-Message-State: AO0yUKVkmVxNcdUIZ5StyYMRJOW3WJvCdn579wPqbmYDdgdFKuZi2OW8 fv7+SF9+pcjuqLiK2Tdh9Ltw55GTZKD+yblr6SM= X-Received: by 2002:aa7:97a2:0:b0:5a8:ea06:662 with SMTP id d2-20020aa797a2000000b005a8ea060662mr13755950pfq.20.1678212158839; Tue, 07 Mar 2023 10:02:38 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:b1e0:bfd9:8b1a:efeb]) by smtp.gmail.com with ESMTPSA id z4-20020a63e544000000b00502fd70b0bdsm8080441pgj.52.2023.03.07.10.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 10:02:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 61/67] tcg/sparc: Avoid tcg_const_tl in gen_edge Date: Tue, 7 Mar 2023 09:58:42 -0800 Message-Id: <20230307175848.2508955-62-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230307175848.2508955-1-richard.henderson@linaro.org> References: <20230307175848.2508955-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Push tcg_constant_tl into the shift argument directly. Since t1 no longer exists as a temp, replace with lo1, whose last use was just above. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/translate.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 5ee293326c..137bdc5159 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -2838,7 +2838,7 @@ static inline void gen_load_trap_state_at_tl(TCGv_ptr r_tsptr, TCGv_env cpu_env) static void gen_edge(DisasContext *dc, TCGv dst, TCGv s1, TCGv s2, int width, bool cc, bool left) { - TCGv lo1, lo2, t1, t2; + TCGv lo1, lo2; uint64_t amask, tabl, tabr; int shift, imask, omask; @@ -2905,10 +2905,8 @@ static void gen_edge(DisasContext *dc, TCGv dst, TCGv s1, TCGv s2, tcg_gen_shli_tl(lo1, lo1, shift); tcg_gen_shli_tl(lo2, lo2, shift); - t1 = tcg_const_tl(tabl); - t2 = tcg_const_tl(tabr); - tcg_gen_shr_tl(lo1, t1, lo1); - tcg_gen_shr_tl(lo2, t2, lo2); + tcg_gen_shr_tl(lo1, tcg_constant_tl(tabl), lo1); + tcg_gen_shr_tl(lo2, tcg_constant_tl(tabr), lo2); tcg_gen_andi_tl(dst, lo1, omask); tcg_gen_andi_tl(lo2, lo2, omask); @@ -2927,9 +2925,9 @@ static void gen_edge(DisasContext *dc, TCGv dst, TCGv s1, TCGv s2, lo2 |= -(s1 == s2) dst &= lo2 */ - tcg_gen_setcond_tl(TCG_COND_EQ, t1, s1, s2); - tcg_gen_neg_tl(t1, t1); - tcg_gen_or_tl(lo2, lo2, t1); + tcg_gen_setcond_tl(TCG_COND_EQ, lo1, s1, s2); + tcg_gen_neg_tl(lo1, lo1); + tcg_gen_or_tl(lo2, lo2, lo1); tcg_gen_and_tl(dst, dst, lo2); }