From patchwork Tue Mar 7 17:58:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659764 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2523498wrb; Tue, 7 Mar 2023 10:01:39 -0800 (PST) X-Google-Smtp-Source: AK7set/5g3dNrsqQ4CQYGkwK1drtTRcBgmxPLkyl9kcfwhPp9h2SWDaDa7HUhOCeQredzFWFM6So X-Received: by 2002:ad4:5d66:0:b0:56e:b16d:ec93 with SMTP id fn6-20020ad45d66000000b0056eb16dec93mr28892817qvb.4.1678212099076; Tue, 07 Mar 2023 10:01:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678212099; cv=none; d=google.com; s=arc-20160816; b=eDsigx0TdUX2lhiCckTg8rpWBWpy7ut427aWWe8okYD3oUR//254DkpHIhdwqwabwK lMDphQmRJ/ilA4CUrKZ7f+5of2b10mdBATQgXWdn20gaCVyuP0NKB32bjNWJhKK7kcsM rb7xSRvFxVj14vZy+/w5Au8Fph41iE/BSjqC+FUVDTPhM0SdRSON6vPpkNkVXVCiOALP TL6wFYpI5yCWD8Hl3C4qx3OdkMYc9Tu1JkEz+mO0ZkAKHDhaj/SPb8FFWlLquCZXLrpl DS9+AOVOqxTOQ0cESnpFi6RshkFaC8Od82vi18SECj/IVuAnCLoE7J4W/ikJ97nxKCAG KPPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+dzaTq4Hk7e5zysi1fCZtiBija1HdA1vnsnzcrh5iSw=; b=KzMDFfxJh8mRkB4TPJV8aeUraSm3OygCxGiX1LEvwuO2uTGvtNSq9LXxUhLcHRrW/A MKtcs/A2zDDDnzy0anYoZZN0s5zLRy3mahHUDBVB7rpVzr+JHTgntqHlx0NWeH9MPI26 10RYwAXPL2qt8uRSZ9ULYFjS0o8QJx0/zjJyqKEBjQkYmK+iTnFF9/toZoJWilCjMOhG f9CNx4S2HneqBPw9TjAgMkZcOVUNO9UE5VwsNR0aToyRRguXNpMpCr3HRev34vWlLxo3 oZVYZTZwk5aPOG0AmwWOBW/w5E8xhbE1CWqE3eymz4ayJs/DobX//tK43T5cyJFkMHyo +GTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XeLF3vLh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q3-20020a37f703000000b007223bb531aasi9141604qkj.726.2023.03.07.10.01.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2023 10:01:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XeLF3vLh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZbbK-0007dM-LJ; Tue, 07 Mar 2023 12:59:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZbav-0006fi-Jf for qemu-devel@nongnu.org; Tue, 07 Mar 2023 12:59:27 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZbas-0000LA-Iq for qemu-devel@nongnu.org; Tue, 07 Mar 2023 12:59:25 -0500 Received: by mail-pl1-x633.google.com with SMTP id h8so14979598plf.10 for ; Tue, 07 Mar 2023 09:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678211960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+dzaTq4Hk7e5zysi1fCZtiBija1HdA1vnsnzcrh5iSw=; b=XeLF3vLhXrUNh3TpTRsanq0zbRtXNxNPhYF25Qh+7/jN49Om+pUQf/terH69iSa/te tQ5WKXcNdPDBjQJv3PJZ2jzs4Lh28VrrLrH+aKOJqKAZDVqCwPSLIotBQLz7wMxsX51w qMZtZf/LKNS5AXSIT2jr0d899Ex0pEcSRJErPiIZC+STyYqtYe5JzUNtfIx8IGADBeCg +IC2K49dT7c7DshlzvqjiBXdA3X82jwTaoNj/RHwmzvl2RNW+I/t+ANYeYSXSIBXLK8U DbFtwHt9rTN44r48MiSAUaoFi88mnB1dze7lVzA/TbgBdWEr7NVuALqYpxawNUatS2wP 6Thw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678211960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+dzaTq4Hk7e5zysi1fCZtiBija1HdA1vnsnzcrh5iSw=; b=01gvbrl6AAk7LgovcQ5Li1L2PRr6XmJ23MoevFQPADBMoFE52srw8lt508Alui2Ec3 Hchz0uHuyGXhDSxrtzi00aNE5hIWZMW00z9LaXkUAzk/mndV5PQv2o+x5bSWa5JxzjBD ZYtZtbc2aqe8jt7TDI1IBPbiIgZxckZdvXrfIMjIG2A9d3vo3xEyY6aILOEey+kYUvVX WdPfWoaFaQ2hGHQvmY0xhF1GBjsJ35+cK0qZPVNPBYMQvoeybRTjmKuK5lrDwTQeGp/v H7O/yb7EBwSxzGRG84ZVPcwSU5Ospm8Q1rEaUQMGlw/MVcyp8deU7M1XMfupg6VQHkW6 upQg== X-Gm-Message-State: AO0yUKW1MH5c6AZxqkLufIED2vE3mRJxMAautjSMS5eqPAi5v0Tm668G MA9zLnEdvRZQDKzy6m35G9Yq7knspk3UAcEoYdg= X-Received: by 2002:a17:902:f548:b0:19c:947c:8819 with SMTP id h8-20020a170902f54800b0019c947c8819mr20211106plf.59.1678211960741; Tue, 07 Mar 2023 09:59:20 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:b1e0:bfd9:8b1a:efeb]) by smtp.gmail.com with ESMTPSA id bd6-20020a170902830600b00198e397994bsm8661802plb.136.2023.03.07.09.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 09:59:20 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 39/67] target/avr: Avoid use of tcg_const_i32 in SBIC, SBIS Date: Tue, 7 Mar 2023 09:58:20 -0800 Message-Id: <20230307175848.2508955-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230307175848.2508955-1-richard.henderson@linaro.org> References: <20230307175848.2508955-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The use of separate data/port variables is existing practice elsewhere, e.g. SBI, CBI. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/avr/translate.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index b9506a8d86..190d0c3f97 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -1288,12 +1288,13 @@ static bool trans_SBRS(DisasContext *ctx, arg_SBRS *a) */ static bool trans_SBIC(DisasContext *ctx, arg_SBIC *a) { - TCGv temp = tcg_const_i32(a->reg); + TCGv data = tcg_temp_new_i32(); + TCGv port = tcg_constant_i32(a->reg); - gen_helper_inb(temp, cpu_env, temp); - tcg_gen_andi_tl(temp, temp, 1 << a->bit); + gen_helper_inb(data, cpu_env, port); + tcg_gen_andi_tl(data, data, 1 << a->bit); ctx->skip_cond = TCG_COND_EQ; - ctx->skip_var0 = temp; + ctx->skip_var0 = data; return true; } @@ -1305,12 +1306,13 @@ static bool trans_SBIC(DisasContext *ctx, arg_SBIC *a) */ static bool trans_SBIS(DisasContext *ctx, arg_SBIS *a) { - TCGv temp = tcg_const_i32(a->reg); + TCGv data = tcg_temp_new_i32(); + TCGv port = tcg_constant_i32(a->reg); - gen_helper_inb(temp, cpu_env, temp); - tcg_gen_andi_tl(temp, temp, 1 << a->bit); + gen_helper_inb(data, cpu_env, port); + tcg_gen_andi_tl(data, data, 1 << a->bit); ctx->skip_cond = TCG_COND_NE; - ctx->skip_var0 = temp; + ctx->skip_var0 = data; return true; }