From patchwork Tue Mar 7 17:57:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659777 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2524192wrb; Tue, 7 Mar 2023 10:02:43 -0800 (PST) X-Google-Smtp-Source: AK7set9Ao31caEk3BmfASMbPkjLRr5JABxDcUUBlHPdHOQjeqguwX74b46xANqIAjD24Ot0UBng/ X-Received: by 2002:a05:622a:1895:b0:3bf:b504:d5ea with SMTP id v21-20020a05622a189500b003bfb504d5eamr26818292qtc.48.1678212163095; Tue, 07 Mar 2023 10:02:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678212163; cv=none; d=google.com; s=arc-20160816; b=1DAQSWjnGw7l71YMrwmt9Pm9f7+QeKHK/ewN1O26J7q1q42S941BafzbDtIJPlJsQM KAWUQRSTuBPRasMWt8kSlLdXdlr/AYqDca6g6HT6RDIzdlhJocqToB4y8hi068B1xD5D 5cxYpNfR+ZtkZuzKH8M+IqPF01yeBjRtaZ3dfNdWByBsJ+qzvnf/pjOeIblmtJmeHli8 7+5WaHm1fn3K9F3yKcoYo0Re8ySToJk3boO2HykrqkXDgAWPqx3QSlX8wGLz9ISE/aHN c7H7T4xzH8fs/Pxq8CRYGEHDV3DtftfLr2t7f807KFahX07s8gQ4oqSFefs3mq7HPRu7 3EVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=WYbXLC5LLqFiC6Ld3INTY+I4JPFr8wO/6AH8oAk1RI2FtoIafI+ah08+Tp44xl5Y91 mOS5CtxgoNgJk2kZPjc3w1WsHQYQRiRg133D4X5SKxOufde72fX3YG6fMZtarVBCWtgF j56GqwO46j6AHfy7yR/DRCYJYJlEcSt/8kxARy8ojFhMWQ+1wkNy1pL6baqkbvpenTz5 m81r0AxqkRLSgpIG7OS2ASgdcswqVFIltH+yXvS2kVy0RatFLxv9QhqloRXyM7cUP2nW OGBfR6gneIEv8T0X0LHydd35s5g/EZQy6Uz/Frqqw88/UooJFHaRObaYOkYzZGoEMUrO n29g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IkaIYc6n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 30-20020a05620a049e00b0073ba79a463csi9199291qkr.453.2023.03.07.10.02.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2023 10:02:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IkaIYc6n; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZbae-0006EY-IL; Tue, 07 Mar 2023 12:59:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZbaZ-000666-Qh for qemu-devel@nongnu.org; Tue, 07 Mar 2023 12:59:06 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZbaY-0000FI-4p for qemu-devel@nongnu.org; Tue, 07 Mar 2023 12:59:03 -0500 Received: by mail-pl1-x62c.google.com with SMTP id y11so15038632plg.1 for ; Tue, 07 Mar 2023 09:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678211940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=IkaIYc6ntVHiYxWWevcfIlVsVA4PfDGKab6ZxxRJE/E9G3syeFnZXPerW651ZN5c8f 1kpi7CcySKVrgQF914eS7xxZ6QnRKOZqsuqGMPbbNcdy6UPQYN/1X13GBWj3Rbc1u1/l xftgCm5SGwCuYmf6XUbHFToknfZU2T4HvraKWMBuU/ByGzXIrlZp0l+EGW+qBnNVUXzM +akjCESCY6x8sgZ61mYxt6tDIaeBLB05ADVtI95dORJQgvTmlGAkSZvhQAkST8nk9Zxb cUAgrlmGcmNllzXL7RtT5Xv4FVEVlvwWiOlFxyg0SIUrAZ8t9oRk5Uw2AvJcM8cztcjO CjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678211940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mg/FlCLv+ULszQuPgdUBYUpdYDGYF2qtD9xphrdhNP0=; b=PpkO+G7kmWcwlz0uKJysWRD+N4jCRukSJPUPwBJwu/g8zcg93yIi+C2MniifG6f5Ci +DsZItmyt35u02oqDqAzwIW+mWaK96bcni1iMNN8NMO6wEAtHkwHUPJNfqvtPnnYpKqI 4ZmG2FlXRFOivJpCM74xADMfRl9jTSWDNbdOInf6X1Txhcbeppnj/M9gsGqBQdxZ0Ddc K/BJ/6/gJQ3Df1RmZ5eo8yl36pXm6x2f7E+MGbp6W8q22vcMXhKKTR3v9L+Vytp+g1/p kxKU1XN5cnuC4HkX581ZuAlI35pSrgTG/Sa1XqD9tZ9AchDLCuo1+d6i2+dPMKG3MdKi HqTg== X-Gm-Message-State: AO0yUKVGUNvUaQmFrQvnGNR/Tk+eeykBIiIfRn+zv2OLif+xofoKub8e pv6WBStQwO1YcRkQvLXXRTcYI6s+mff0mOl3brc= X-Received: by 2002:a17:90b:33c2:b0:234:b35b:f8ee with SMTP id lk2-20020a17090b33c200b00234b35bf8eemr16428248pjb.0.1678211940631; Tue, 07 Mar 2023 09:59:00 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:b1e0:bfd9:8b1a:efeb]) by smtp.gmail.com with ESMTPSA id bd6-20020a170902830600b00198e397994bsm8661802plb.136.2023.03.07.09.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 09:59:00 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, David Hildenbrand , Ilya Leoshkevich , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 14/67] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext Date: Tue, 7 Mar 2023 09:57:55 -0800 Message-Id: <20230307175848.2508955-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230307175848.2508955-1-richard.henderson@linaro.org> References: <20230307175848.2508955-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org These fields are no longer read, so remove them and the writes. Acked-by: David Hildenbrand Reviewed-by: Ilya Leoshkevich Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 9ad6e75434..7969051ce9 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1061,7 +1061,6 @@ static const DisasFormatInfo format_info[] = { them, and store them back. See the "in1", "in2", "prep", "wout" sets of routines below for more details. */ typedef struct { - bool g_out, g_out2, g_in1, g_in2; TCGv_i64 out, out2, in1, in2; TCGv_i64 addr1; TCGv_i128 out_128, in1_128, in2_128; @@ -3159,9 +3158,7 @@ static DisasJumpType op_mc(DisasContext *s, DisasOps *o) static DisasJumpType op_mov2(DisasContext *s, DisasOps *o) { o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; return DISAS_NEXT; } @@ -3171,9 +3168,7 @@ static DisasJumpType op_mov2e(DisasContext *s, DisasOps *o) TCGv ar1 = tcg_temp_new_i64(); o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; switch (s->base.tb->flags & FLAG_MASK_ASC) { case PSW_ASC_PRIMARY >> FLAG_MASK_PSW_SHIFT: @@ -3202,11 +3197,8 @@ static DisasJumpType op_movx(DisasContext *s, DisasOps *o) { o->out = o->in1; o->out2 = o->in2; - o->g_out = o->g_in1; - o->g_out2 = o->g_in2; o->in1 = NULL; o->in2 = NULL; - o->g_in1 = o->g_in2 = false; return DISAS_NEXT; } @@ -3708,7 +3700,6 @@ static DisasJumpType op_rosbg(DisasContext *s, DisasOps *o) /* If this is a test-only form, arrange to discard the result. */ if (i3 & 0x80) { o->out = tcg_temp_new_i64(); - o->g_out = false; } i3 &= 63; @@ -4874,7 +4865,6 @@ static DisasJumpType op_zero2(DisasContext *s, DisasOps *o) { o->out = tcg_const_i64(0); o->out2 = o->out; - o->g_out2 = true; return DISAS_NEXT; } @@ -5142,7 +5132,6 @@ static void prep_new_x(DisasContext *s, DisasOps *o) static void prep_r1(DisasContext *s, DisasOps *o) { o->out = regs[get_field(s, r1)]; - o->g_out = true; } #define SPEC_prep_r1 0 @@ -5151,7 +5140,6 @@ static void prep_r1_P(DisasContext *s, DisasOps *o) int r1 = get_field(s, r1); o->out = regs[r1]; o->out2 = regs[r1 + 1]; - o->g_out = o->g_out2 = true; } #define SPEC_prep_r1_P SPEC_r1_even @@ -5375,7 +5363,6 @@ static void in1_r1(DisasContext *s, DisasOps *o) static void in1_r1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1)]; - o->g_in1 = true; } #define SPEC_in1_r1_o 0 @@ -5409,7 +5396,6 @@ static void in1_r1p1(DisasContext *s, DisasOps *o) static void in1_r1p1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1) + 1]; - o->g_in1 = true; } #define SPEC_in1_r1p1_o SPEC_r1_even @@ -5464,7 +5450,6 @@ static void in1_r3(DisasContext *s, DisasOps *o) static void in1_r3_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r3)]; - o->g_in1 = true; } #define SPEC_in1_r3_o 0 @@ -5595,7 +5580,6 @@ static void in1_m1_64(DisasContext *s, DisasOps *o) static void in2_r1_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r1)]; - o->g_in2 = true; } #define SPEC_in2_r1_o 0 @@ -5630,7 +5614,6 @@ static void in2_r2(DisasContext *s, DisasOps *o) static void in2_r2_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r2)]; - o->g_in2 = true; } #define SPEC_in2_r2_o 0