From patchwork Mon Mar 6 15:34:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 659262 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1915992wrb; Mon, 6 Mar 2023 08:48:16 -0800 (PST) X-Google-Smtp-Source: AK7set/CWFTRfW2fSnY8hd7TPmEQsZqcntoojD8/nLzRhL6k6H2D65a3nMf2N+M8Dqn2mOnsbmLa X-Received: by 2002:ad4:5dcb:0:b0:56f:154:2508 with SMTP id m11-20020ad45dcb000000b0056f01542508mr18050492qvh.1.1678121296776; Mon, 06 Mar 2023 08:48:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678121296; cv=none; d=google.com; s=arc-20160816; b=x/oyeI59UVsCyhuaYX/6q67xIcFgfLaok3KUYkS5qa5CEeE8SZ4qSu3JgFupqA1IDP bAvkIFUzuFluSbZ1Z/uNRWQqL54dOpjBe0u4CjFPk6js+N6foW3H4bhyJXa2cjLhnoyb gx+mGT2j3LXLjBX5qxbpUn+G58vAwTGfxbQgctk1zQ1xkvM/sSveHP945rqYUdIACxuF cHj5hqdLeqTyjmhHbcWYnYiaOHaaDuvAcZwjWWITHXErSEYOhPVxlNt3ovwv/dTpdBER xcQn11ps3eaWjII2lD+QVsgzHbax2HM5sdqFe/Y9+WEFjAdVKTpE+ufDELmCVz4L46h9 FHdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=8RypxeqHCkWrvhM6v/ukjoIBfsmqrjlJlNPR4BkYcx0=; b=PtdzQtqFnGJTbN05dNXmLeRvca6VI1l9bIJHtq9AEBgj2z2NZiFCPoNs4fLB2V2ut2 25Mz2Xu23JktDqQo4990jvPDlvOhqXNqQeJZSV6aKljU4paRhJEJObIwKRQ08iwV0vh5 RPjjcHjieQCNTv5oUuiXdyT6LxdRr8hWonAtO4D2EywEtRaXSaTb/R5R9WEVSoIqps3y 2dqxa3TqrnymBU2KRhRlDU2f7xRbMnoOeXKp5G+/pHVJnU4R41K8X3ByY4XcoCeg5YhQ zcXxdyErCMC8aUH1uuk2y+O4qnlUKn5mzzIgE+BrORhuspRbk930xqVlAP7vflwOv6++ 9+fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NsNUnGuy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i10-20020a0cf48a000000b0056ef8dad683si7165841qvm.290.2023.03.06.08.48.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Mar 2023 08:48:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NsNUnGuy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZCrQ-00043K-Aw; Mon, 06 Mar 2023 10:34:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCrP-000433-Hr for qemu-devel@nongnu.org; Mon, 06 Mar 2023 10:34:47 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZCrN-00029m-Tu for qemu-devel@nongnu.org; Mon, 06 Mar 2023 10:34:47 -0500 Received: by mail-wm1-x332.google.com with SMTP id k37so5970158wms.0 for ; Mon, 06 Mar 2023 07:34:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678116884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8RypxeqHCkWrvhM6v/ukjoIBfsmqrjlJlNPR4BkYcx0=; b=NsNUnGuyUFxD5ZETY4XHduffwIAYUWimVXUoAXkLBIstrQvQKhMBtrIRYgw8wT09aK KPbwkqtzESTDTZ3pBYzddLgksHZnmeyo2BBZAdc8jEM3tmAHOU2caUrPyL+2laEmDOVG nyYbE3mfJqYeuxWSSaehlX+YLV0OXWVMNgp8y20yB06ksHMzWe8x3Paa0EIsnpYOONN8 aqG7NiNzGUqOq+f6He4Q1bwUWhdI5jDVn/OA/YmhW+y0Xb/7LaQXSNaA/tTX0x17q32l 0LxQYnScMlVYz+7PbU/Ar4jIqT7mdeQ12WKrmGReyl2PGQrHXgmk+UgzOFWFw6B9PeQo GtQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678116884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8RypxeqHCkWrvhM6v/ukjoIBfsmqrjlJlNPR4BkYcx0=; b=WT7aFl+1bvOzYf4pP4gsP88iEiupraTgzB8zusMDnWVKTOyyZDBgNUgEHQKjTk12Z1 PawSwMsQvL5JolBtGb5kZiN9nDBtxcGDOGVqFwSCY93/za3CmqIHdChzUMUUhY3dOhXJ arpHX7xbxM8JRF3CtegalgfELyxX26S+ZaLJnmMdBWgnjydg5qJVt3sAByW3fTcFU400 pgbS8AMutTKX+VG6D2S7zxd2cLTKcR7V45i3n50SmTHLDhmML/2bDS1TnoKYds19IVPm 0VnQLoBFQMd/ZtfFB8a9v8byOYcACuqOVIvxEMtq50Av8eiljsMvjtaN246S85CCU51/ Vqew== X-Gm-Message-State: AO0yUKVX6FYMIYlQIm0M0a07+jt6pSNGQHZ7vMKOrPNshU28KtMGSaSZ MtTcKY5WIeAW0O1NvvCsEcmyJ8Opimx6TEuhaZM= X-Received: by 2002:a05:600c:4511:b0:3ea:e554:7808 with SMTP id t17-20020a05600c451100b003eae5547808mr9638293wmo.19.1678116884554; Mon, 06 Mar 2023 07:34:44 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id v7-20020a05600c444700b003eb0d6f48f3sm15287432wmn.27.2023.03.06.07.34.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 07:34:44 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 09/21] target/arm: Simplify iteration over bit widths Date: Mon, 6 Mar 2023 15:34:23 +0000 Message-Id: <20230306153435.490894-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306153435.490894-1-peter.maydell@linaro.org> References: <20230306153435.490894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Order suf[] by the log8 of the width. Use ARRAY_SIZE instead of hard-coding 128. This changes the order of the union definitions, but retains the order of the union-of-union members. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230227213329.793795-10-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/gdbstub64.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index 36166bf81eb..3d9e9e97c86 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -240,8 +240,8 @@ static void output_vector_union_type(GString *s, int reg_width, { "int8", 8, 'b', 's' }, }; - static const char suf[] = { 'q', 'd', 's', 'h', 'b' }; - int i, j, bits; + static const char suf[] = { 'b', 'h', 's', 'd', 'q' }; + int i, j; /* First define types and totals in a whole VL */ for (i = 0; i < ARRAY_SIZE(vec_lanes); i++) { @@ -256,7 +256,9 @@ static void output_vector_union_type(GString *s, int reg_width, * signed and potentially float versions of each size from 128 to * 8 bits. */ - for (bits = 128, i = 0; bits >= 8; bits /= 2, i++) { + for (i = 0; i < ARRAY_SIZE(suf); i++) { + int bits = 8 << i; + g_string_append_printf(s, "", name, suf[i]); for (j = 0; j < ARRAY_SIZE(vec_lanes); j++) { if (vec_lanes[j].size == bits) { @@ -270,7 +272,7 @@ static void output_vector_union_type(GString *s, int reg_width, /* And now the final union of unions */ g_string_append_printf(s, "", name); - for (bits = 128, i = 0; bits >= 8; bits /= 2, i++) { + for (i = ARRAY_SIZE(suf) - 1; i >= 0; i--) { g_string_append_printf(s, "", suf[i], name, suf[i]); }