From patchwork Mon Mar 6 00:39:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659168 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1573885wrb; Sun, 5 Mar 2023 16:46:40 -0800 (PST) X-Google-Smtp-Source: AK7set8WfHWRsDAim01Tn8/Sotrr3LwVuLXQ2YabBILdr9kxYsI1LFTPK/JtsXrmKjjGN1yehb9d X-Received: by 2002:a05:622a:1496:b0:3bf:afd1:8c98 with SMTP id t22-20020a05622a149600b003bfafd18c98mr16134521qtx.0.1678063600327; Sun, 05 Mar 2023 16:46:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063600; cv=none; d=google.com; s=arc-20160816; b=AdZudyM/Hb+2nMGwsPwqxly/IG31n57TDG/bfahSDaWnRHienYyoq0kK2UAEiZveWN Ukw07Z4NLZD1G8PaoaslNPG2VS+KEWFUTWsfdFK+M5wQbdF82t4hH5ibv3ZzGtgQ2hQN 6WMjMNH3oyLKKmyMkeXU+rzWcxkL8sSsiN4DPEvb20GBK3fMuFvRzbDETqR+aEyCsQdP w1KPuWa0j65QXz/b6KBDYYBAAmOqZHAJOLXQHbtEZjsrfpADMQswFXv6V546EE5jh7ds xrU34Mw9X4yTTXyx845+reJowWn7sWLmZNT+zXI2hWRDwvLA6A7JmmNvQ9DTW387RYTJ uC9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t+Ta6rrppFf/6kZnAGXoEQVlqShSzDNxBGECEUneH1U=; b=fCOD3odrPrt9XvvYET+YHdGerLosBHLlWgY6DRoiMPCiUEf2sfLjqxvPIlcq7E4Upx phwzaSoJy9Rr3lHD7IiJFZl5v7cdFs+7e+Qe1YjW9dTkgfnUY4Gxo1p5qdTQjyv4V1Nv 6yNVt7uTlxd7u6B7BU5nVKCfSstPVSLB7sr7MrrEi6qQS5jYbaTZwOD50K65EvxED6Bh hMznDp7+jfHUHjQqM9dmhveaFRjKPOXdQEa47RJvLfj5TkNqoKykZluVil1VboPl4vAh oIoOozWpPazZNJmToGOXH4UYYGU1HFcyisMAjtjLTYTfuohdNc8wly8lwdp5doea98Jq j7Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h7ADF0x9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c21-20020ac87d95000000b003b63c88f5e2si6648565qtd.345.2023.03.05.16.46.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:46:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h7ADF0x9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyyJ-0004LZ-Px; Sun, 05 Mar 2023 19:44:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYyxk-0002u2-KE for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:25 -0500 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyxi-0007M1-LM for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:24 -0500 Received: by mail-pj1-x1041.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so7368719pja.5 for ; Sun, 05 Mar 2023 16:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t+Ta6rrppFf/6kZnAGXoEQVlqShSzDNxBGECEUneH1U=; b=h7ADF0x9AN/dDfz2c1RLRlfhBuM3aji3C4fbtdcs78Ufea6XkkrKSM8R3akwPd/lRX 7hK7shZD7pz5MSwTnGMWZfgyORfNX/RaKpCxK+zRyvA7E0Ar0vXL4C2SYuJkEAJBLQQv Kb9tnKP7x2Ardha+DEp18QNK4ZMVM0zie5VnZccqgTVqFJ7BFhQqczHbotCUYa/E3Iod 7zjB7mDf3Ra8VvaB0nbV22WeH3abRYi6k1kPz6do5Q/nBvUMyOta5XiTC1cmvIF3CMrC p7JDvWn2KfarIGN8XGWRIk3JfNuftv8ZVyb3r/gbJM2Rve35fYuAKwFBaVTEuy05pCdL BAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t+Ta6rrppFf/6kZnAGXoEQVlqShSzDNxBGECEUneH1U=; b=Jk9/Zbbhg9ZsGPrH7imxLkGro72ycVZLbe4OBxGRSHQzcefSvj8c1RiylB+bsFaHXH tX98lOydOjopt61uYevQWNdUit4L/hXJtVhvOpWJ4vgiQtcjxLJ9+4chTm2t2ShAPgjr B/+MxuDLkY9/HJgwzQ2YzvQUe/a+1ebu6fC2aOv7cE9MX15gCZfk1Ut1D+QoVD7xKtW3 8l6O25mgdcskG5OnIT3cuZsHGwBw2nyAHegwfB2TJvMKHoVuCnU1UZeoWEC93WvPLTug /+Gxw4Lh9WrWs1KfyufbxvyfzPDNxhZQvIDjrDg86PBv0g2cwbpZf05mzA8wC4tz16p2 uXxQ== X-Gm-Message-State: AO0yUKVrBo3X4KEPK/kKfiM7gCoIrkJmU89oyJtWuiih6az7vjkXOukU tDLATNL4Z3QVdFWd7LkGC+f491T8dwhieMW4AA9JHXlZ X-Received: by 2002:a05:6a20:9146:b0:bb:b903:d836 with SMTP id x6-20020a056a20914600b000bbb903d836mr10387503pzc.54.1678063457564; Sun, 05 Mar 2023 16:44:17 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b005895f9657ebsm5045726pfu.70.2023.03.05.16.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:44:17 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Taylor Simpson Subject: [PULL 69/84] target/hexagon: Use tcg_constant_* for gen_constant_from_imm Date: Sun, 5 Mar 2023 16:39:39 -0800 Message-Id: <20230306003954.1866998-70-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Rename from gen_tmp_value_from_imm to match gen_constant vs gen_tmp. Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- target/hexagon/idef-parser/parser-helpers.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c index 0b401f7dbe..6fb5f31cf7 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -325,9 +325,9 @@ HexValue gen_tmp_value(Context *c, return rvalue; } -static HexValue gen_tmp_value_from_imm(Context *c, - YYLTYPE *locp, - HexValue *value) +static HexValue gen_constant_from_imm(Context *c, + YYLTYPE *locp, + HexValue *value) { HexValue rvalue; assert(value->type == IMMEDIATE); @@ -338,11 +338,11 @@ static HexValue gen_tmp_value_from_imm(Context *c, rvalue.is_dotnew = false; rvalue.tmp.index = c->inst.tmp_count; /* - * Here we output the call to `tcg_const_i` in + * Here we output the call to `tcg_constant_i` in * order to create the temporary value. Note, that we * add a cast * - * `tcg_const_i`((int_t) ...)` + * `tcg_constant_i`((int_t) ...)` * * This cast is required to avoid implicit integer * conversion warnings since all immediates are @@ -350,7 +350,7 @@ static HexValue gen_tmp_value_from_imm(Context *c, * integer is 32-bit. */ OUT(c, locp, "TCGv_i", &rvalue.bit_width, " tmp_", &c->inst.tmp_count); - OUT(c, locp, " = tcg_const_i", &rvalue.bit_width, + OUT(c, locp, " = tcg_constant_i", &rvalue.bit_width, "((int", &rvalue.bit_width, "_t) (", value, "));\n"); c->inst.tmp_count++; @@ -395,8 +395,7 @@ HexValue gen_imm_qemu_tmp(Context *c, YYLTYPE *locp, unsigned bit_width, HexValue rvalue_materialize(Context *c, YYLTYPE *locp, HexValue *rvalue) { if (rvalue->type == IMMEDIATE) { - HexValue res = gen_tmp_value_from_imm(c, locp, rvalue); - return res; + return gen_constant_from_imm(c, locp, rvalue); } return *rvalue; }