From patchwork Mon Mar 6 00:39:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659182 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1574864wrb; Sun, 5 Mar 2023 16:50:30 -0800 (PST) X-Google-Smtp-Source: AK7set9oeIz6NNup6F/ycoWw0YuogrnBx3vIF5GR7gF8PRivgQHRZyHrHT9vXwp29d2yYEtzMjie X-Received: by 2002:ac8:7d15:0:b0:3bf:ce15:ff25 with SMTP id g21-20020ac87d15000000b003bfce15ff25mr16669937qtb.12.1678063830752; Sun, 05 Mar 2023 16:50:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063830; cv=none; d=google.com; s=arc-20160816; b=L5NDtlUH4cMLaJzElSbnWyS03f1nNSqC+U6V/i4K+Cw+OOXYorZbxfG91I6G3hkngo Lkw2BFPfVZ6r85tgJKE+0F78THnO2hWIaczfWW4H7SW6mSaDLclFsSHIdXOKLfeBcRMf 1dr1m2LuV1JF5lBYiiJZhoLUIYcpX3BbklCB15dRMaY8Jb+gjkt/SkvG0cS7ZrUZc8DC PFBzKl+YRlmWGdU5ViZYWv21wkN76OWSX2jwmqv3GdxHj/SXs4QzUrEehT7IVl1Otfz+ Qo0vOFfoGoVz29tzvQ8A+j+ZKs2/q9bea1xAR2yGc5Y9Tql605Bpa4lNOSISIs7Mwt8a mNhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=; b=sRQms77feJ4rTesNmwi1/i0dMiArDt5Mn1VDkYywDqOTA9yoB0NdAk84wU6NUcR5eI lKbPk/G836Bm9tLAGOGtdq1weLiyqQcRP41W8zzcU9uvI8o8OlP2vECo5W75bF5d8IEC XJYvsaLCuDwlG4nHgHUv3DmAT1bs4SVbaJcWQYEMM+GZglUJOkUvizVP07JGOUJg2E3A GY8fkKxXZdeZBz42v1mQAAe0aoVRa14/lxNYzxQVPB1tqffw74OIQR9lucC4/YdRGjjP ehmFTLz5EJA0CC3dklzpGYOt5lDpIlNiLcnFVbzqCTY5VRbm4uZiQslAXdwfsYpqZH6x 3KuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hFZkzlgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w3-20020a05620a444300b0073b338a9ad7si6607444qkp.572.2023.03.05.16.50.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:50:30 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hFZkzlgB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyue-0005d0-9A; Sun, 05 Mar 2023 19:41:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYyu3-0004XP-Tb for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:40:35 -0500 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyu0-0006sn-5u for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:40:35 -0500 Received: by mail-pj1-x1041.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so9706356pjn.1 for ; Sun, 05 Mar 2023 16:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=; b=hFZkzlgB37Iwt8O+Lm7gTE073z0e7A082+fa4plp2WSq0A1DnKE7XLkQXPtxfFXy2D 5sy7DZle1kKPWdvUNwmjAREVDzAqkqARL4a0dMs6saZ0dJHl6J1PDJc4TtYt96Vi0UFe yfiZu9BHnI6aWVGY4V0UN3uaf8uGBaI0/LOw5No2T0okJmBFtk/ECjyJ+QLWjaHzhzce TqVjLYpToHP/IwDKFkY/Euew8Lno5w6YtpqQ6nV0vBRP4eLzfAVbcW5gar1VZEWy+oa3 C3H65dLwnZ0FTlhhVF8S46wtjgIWH+BtPevNG0D6icAgb70UtW7db9Yauor7kA6O9T4k NNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1rz9k7o4d//+CtCPfl15T22J2m9D1OS7OQgm/BQ1mJE=; b=nrumDRuN4TxDD/EK2BZ9a4GXLZV8OezsrJvA4sKEkdHVJAYrnf1wiOl0jtYzS+a7ev d+LIl5/3jpu9Ky2Fgr7kqCENRkMV+OzbrVxMfsbB+pDE4zxk1YCrdcWNLfi1Ob6xdjsU lxdoZiSfqkdZ1539bbDdFk4BgBN1nHJ/QeQLe68Vp6QYic4FL7hlssv31P0ofk5rfxAQ LrO++MgkcJCBcmEGYgNaYT2+lLCtPkc2EX0/xVUzHP/IcZD4NHXgougltZm5QJ8kvW90 MmpkjFmDh+fHCkYVaX0Ax0DCA9YR/95zzGsGAUWKkqmjBvaCanedhKGBybnNyB7Y87RL od7Q== X-Gm-Message-State: AO0yUKUVhcYq5+fNa+P78wF9Zmb0JtP51OzmeiIfoL/kKcHgrnHZGgxC ZKHy7BtxyRgdT4U2T+hZpuIRWLGrMAqbbLSUgPw34cNm X-Received: by 2002:a17:90a:7:b0:23a:6be8:9446 with SMTP id 7-20020a17090a000700b0023a6be89446mr9777893pja.48.1678063230693; Sun, 05 Mar 2023 16:40:30 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id r13-20020a17090b050d00b002372106a5c2sm6567901pjz.37.2023.03.05.16.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:40:30 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Taylor Simpson Subject: [PULL 39/84] target/hexagon/idef-parser: Drop HexValue.is_manual Date: Sun, 5 Mar 2023 16:39:09 -0800 Message-Id: <20230306003954.1866998-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This field is no longer used. Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- target/hexagon/idef-parser/idef-parser.h | 1 - target/hexagon/idef-parser/parser-helpers.c | 15 --------------- target/hexagon/idef-parser/idef-parser.y | 2 -- 3 files changed, 18 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef-parser/idef-parser.h index 5c49d4da3e..17d2ebfaf6 100644 --- a/target/hexagon/idef-parser/idef-parser.h +++ b/target/hexagon/idef-parser/idef-parser.h @@ -185,7 +185,6 @@ typedef struct HexValue { unsigned bit_width; /**< Bit width of the rvalue */ HexSignedness signedness; /**< Unsigned flag for the rvalue */ bool is_dotnew; /**< rvalue of predicate type is dotnew? */ - bool is_manual; /**< Opt out of automatic freeing of params */ } HexValue; /** diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c index bdbb8b6a5f..0b401f7dbe 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -278,7 +278,6 @@ static HexValue gen_constant(Context *c, rvalue.bit_width = bit_width; rvalue.signedness = signedness; rvalue.is_dotnew = false; - rvalue.is_manual = true; rvalue.tmp.index = c->inst.tmp_count; OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count, " = tcg_constant_i", &bit_width, "(", value, ");\n"); @@ -299,7 +298,6 @@ HexValue gen_tmp(Context *c, rvalue.bit_width = bit_width; rvalue.signedness = signedness; rvalue.is_dotnew = false; - rvalue.is_manual = false; rvalue.tmp.index = c->inst.tmp_count; OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count, " = tcg_temp_new_i", &bit_width, "();\n"); @@ -320,7 +318,6 @@ HexValue gen_tmp_value(Context *c, rvalue.bit_width = bit_width; rvalue.signedness = signedness; rvalue.is_dotnew = false; - rvalue.is_manual = false; rvalue.tmp.index = c->inst.tmp_count; OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count, " = tcg_const_i", &bit_width, "(", value, ");\n"); @@ -339,7 +336,6 @@ static HexValue gen_tmp_value_from_imm(Context *c, rvalue.bit_width = value->bit_width; rvalue.signedness = value->signedness; rvalue.is_dotnew = false; - rvalue.is_manual = false; rvalue.tmp.index = c->inst.tmp_count; /* * Here we output the call to `tcg_const_i` in @@ -375,7 +371,6 @@ HexValue gen_imm_value(Context *c __attribute__((unused)), rvalue.bit_width = bit_width; rvalue.signedness = signedness; rvalue.is_dotnew = false; - rvalue.is_manual = false; rvalue.imm.type = VALUE; rvalue.imm.value = value; return rvalue; @@ -390,7 +385,6 @@ HexValue gen_imm_qemu_tmp(Context *c, YYLTYPE *locp, unsigned bit_width, memset(&rvalue, 0, sizeof(HexValue)); rvalue.type = IMMEDIATE; rvalue.is_dotnew = false; - rvalue.is_manual = false; rvalue.bit_width = bit_width; rvalue.signedness = signedness; rvalue.imm.type = QEMU_TMP; @@ -1242,15 +1236,12 @@ void gen_rdeposit_op(Context *c, */ k64 = gen_bin_op(c, locp, SUB_OP, &k64, &width_m); mask = gen_bin_op(c, locp, LSR_OP, &mask, &k64); - begin_m.is_manual = true; mask = gen_bin_op(c, locp, ASL_OP, &mask, &begin_m); - mask.is_manual = true; value_m = gen_bin_op(c, locp, ASL_OP, &value_m, &begin_m); value_m = gen_bin_op(c, locp, ANDB_OP, &value_m, &mask); OUT(c, locp, "tcg_gen_not_i", &dst->bit_width, "(", &mask, ", ", &mask, ");\n"); - mask.is_manual = false; res = gen_bin_op(c, locp, ANDB_OP, dst, &mask); res = gen_bin_op(c, locp, ORB_OP, &res, &value_m); @@ -1410,8 +1401,6 @@ HexValue gen_convround(Context *c, HexValue and; HexValue src_p1; - src_m.is_manual = true; - and = gen_bin_op(c, locp, ANDB_OP, &src_m, &mask); src_p1 = gen_bin_op(c, locp, ADD_OP, &src_m, &one); @@ -1569,10 +1558,6 @@ HexValue gen_round(Context *c, b = gen_extend_op(c, locp, &src_width, 64, pos, UNSIGNED); b = rvalue_materialize(c, locp, &b); - /* Disable auto-free of values used more than once */ - a.is_manual = true; - b.is_manual = true; - n_m1 = gen_bin_op(c, locp, SUB_OP, &b, &one); shifted = gen_bin_op(c, locp, ASL_OP, &one, &n_m1); sum = gen_bin_op(c, locp, ADD_OP, &shifted, &a); diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef-parser/idef-parser.y index 59c93f85b4..fae291e5f8 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -534,7 +534,6 @@ rvalue : FAIL rvalue.imm.type = IMM_CONSTEXT; rvalue.signedness = UNSIGNED; rvalue.is_dotnew = false; - rvalue.is_manual = false; $$ = rvalue; } | var @@ -693,7 +692,6 @@ rvalue : FAIL } | rvalue '?' { - $1.is_manual = true; Ternary t = { 0 }; t.state = IN_LEFT; t.cond = $1;