From patchwork Sat Mar 4 18:18:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 658768 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1054582wrb; Sat, 4 Mar 2023 10:19:50 -0800 (PST) X-Google-Smtp-Source: AK7set9smMlV76Xp9yLa4FrBEf+bN9GfplJoP2M5ExGBd43py+ti/tj6/yQNXXQAxywj8kBYmnKY X-Received: by 2002:a05:6214:2681:b0:56e:b4e0:1bfc with SMTP id gm1-20020a056214268100b0056eb4e01bfcmr10507333qvb.11.1677953990669; Sat, 04 Mar 2023 10:19:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677953990; cv=none; d=google.com; s=arc-20160816; b=kfYLCx/RLvKszhfZ1+C/cxmyehTu3hn9rJed5loO5BCkHuabnlzqiQrH3BleXrcWgf xSShLuyHn/CCVC96bXXLdkQkAjcuUTsCB2baLUtR4jc5nyjlIJ1nfPEUf8HExVLY897Y SbgLi4KF/YUtpmg20B3/xHDGkpGr6KpbWLhLQu2yR064jIU3K1zKWvIJzdNY3JCB8pAX 8OVPoPq6SJppUVKCPHyYYNAWxwiFKaJSJor0yEUbCQmMuW7p/YGFKvtuBcbIdimfr9ad Eno4g+02uXoUhsWUfV5RZZuywKlyYAwYScgSXj5vYfNjGNIcooL6w+3xHlF5AVJvxfrz 8ShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eUy1JZzTuPGot+rHAkA2NlK/qSoLXklkglokMU7FjFM=; b=DfVXtnqy6hg0SZtXfzEsZ3HPio8h7AP4aKs5HJODosbifUIutAv9NXJXBtNdeo1GuN 45beZOLgME6JYhCDnV0hOei2l/mHYcr1N7oQzNmAdzcPlyaLQ6ViBDUYrBfMuXmMXslm mBptlnwnTsQ95peQAEkMuRWPFBMI6wMtK4hZPC6+6058vfcRSuTwket8GxuhUFl4sL2S jF00uGe6LY2ksuPxYV7FIUshN7NvTCRP6zQUWQDE+W/AePxptrqspZcGCEPqPd/eSUwC qfzwkazRWnzNmbeCJru+Y77FLHjmPOkdBuqEgWT3Xcx/v9Xh5OzuxGJQEVFWslkgnS4v AtSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PSmetU19; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o200-20020a3741d1000000b0073baac09237si3747483qka.495.2023.03.04.10.19.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Mar 2023 10:19:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PSmetU19; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYWTh-0006Wp-3J; Sat, 04 Mar 2023 13:19:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYWTa-0006VA-EY for qemu-devel@nongnu.org; Sat, 04 Mar 2023 13:19:22 -0500 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYWTW-0003Q7-C3 for qemu-devel@nongnu.org; Sat, 04 Mar 2023 13:19:22 -0500 Received: by mail-pg1-x536.google.com with SMTP id bn17so3285777pgb.10 for ; Sat, 04 Mar 2023 10:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677953957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eUy1JZzTuPGot+rHAkA2NlK/qSoLXklkglokMU7FjFM=; b=PSmetU192pX5NhrBoJffrp8d03rM8C6z0DYtTxZ7y+SdQjOPJ/db37V8Z0GU3Lv3GA I3HNDqn6lQjZwynsYOyDj/Fy4Jkff58DrLPo5R+FxNzmXTdKW1He+rY2Ph0nOgIQvqkd vYGFCqs87G/JU+rs8kIlk84Fh8JrKKdFwNS8VWUaaXGknlNmW+GYae79onnMOqvV+Bgr n4yFrVoUOHluW309Py4wtcSzDajNqAc+U6wYQyLyINxgWD0ryWFhOFqFf5ERWnuMByc2 ZtCAfSivTid/cIquPAsmqHXKkQFAcGIfERLlvi48wIfqAg2nDb2YLFT95LKL3u05Q6+u 40pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677953957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eUy1JZzTuPGot+rHAkA2NlK/qSoLXklkglokMU7FjFM=; b=p8d1KUSYdC5GE7LWSCuIMSdc6iIFncgnXhgqRVVW55LSr+91lcuB2EOqRvNT/OhuXY vwlmpQ/wHwfjb3Oivxd8wW9tpU3ppF7OMqw3Rmj0jUoKiffevKLdtPCQ5Mu85VbuMxql VdWLouTWDd07bgZfT4eFQQb8bePTC7dxK0HOc7QXk2IMn15BWgmiEuynMmk4mVeHEk5U W2RQhN3El/otoAD/NTwy1m9KvkbG0zmw4y7Aj+vfHEXqEm/FeFENxD8rOzXhQn/alKls Kl6hDxqb9JW4xFfS0TPAOQJFHaZwe0WUEeoQywZsJEFqUww0k1R5rF/vVANTlKid5miH WTpw== X-Gm-Message-State: AO0yUKW1lek4zcnN5NZudknAzOrxgWgG/b7vnczAasFy31Q9zDcWzgWK kDizmodCVpRPTFNLZvb4ne1TC/8oc1PXIBmrZEmqCA== X-Received: by 2002:a62:1b89:0:b0:5db:ba81:dd9f with SMTP id b131-20020a621b89000000b005dbba81dd9fmr5529561pfb.30.1677953956891; Sat, 04 Mar 2023 10:19:16 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:62b1:64d8:8207:f04e]) by smtp.gmail.com with ESMTPSA id 25-20020aa79259000000b005d866d184b5sm3529668pfp.46.2023.03.04.10.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Mar 2023 10:19:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: David Hildenbrand , Ilya Leoshkevich , Thomas Huth , qemu-s390x@nongnu.org Subject: [PATCH v3 17/20] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext Date: Sat, 4 Mar 2023 10:18:57 -0800 Message-Id: <20230304181900.1097116-18-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230304181900.1097116-1-richard.henderson@linaro.org> References: <20230304181900.1097116-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org These fields are no longer read, so remove them and the writes. Signed-off-by: Richard Henderson Acked-by: David Hildenbrand Reviewed-by: Ilya Leoshkevich --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc: Thomas Huth Cc: qemu-s390x@nongnu.org --- target/s390x/tcg/translate.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index c431903c67..9974162527 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1061,7 +1061,6 @@ static const DisasFormatInfo format_info[] = { them, and store them back. See the "in1", "in2", "prep", "wout" sets of routines below for more details. */ typedef struct { - bool g_out, g_out2, g_in1, g_in2; TCGv_i64 out, out2, in1, in2; TCGv_i64 addr1; TCGv_i128 out_128, in1_128, in2_128; @@ -3159,9 +3158,7 @@ static DisasJumpType op_mc(DisasContext *s, DisasOps *o) static DisasJumpType op_mov2(DisasContext *s, DisasOps *o) { o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; return DISAS_NEXT; } @@ -3171,9 +3168,7 @@ static DisasJumpType op_mov2e(DisasContext *s, DisasOps *o) TCGv ar1 = tcg_temp_new_i64(); o->out = o->in2; - o->g_out = o->g_in2; o->in2 = NULL; - o->g_in2 = false; switch (s->base.tb->flags & FLAG_MASK_ASC) { case PSW_ASC_PRIMARY >> FLAG_MASK_PSW_SHIFT: @@ -3202,11 +3197,8 @@ static DisasJumpType op_movx(DisasContext *s, DisasOps *o) { o->out = o->in1; o->out2 = o->in2; - o->g_out = o->g_in1; - o->g_out2 = o->g_in2; o->in1 = NULL; o->in2 = NULL; - o->g_in1 = o->g_in2 = false; return DISAS_NEXT; } @@ -3708,7 +3700,6 @@ static DisasJumpType op_rosbg(DisasContext *s, DisasOps *o) /* If this is a test-only form, arrange to discard the result. */ if (i3 & 0x80) { o->out = tcg_temp_new_i64(); - o->g_out = false; } i3 &= 63; @@ -4874,7 +4865,6 @@ static DisasJumpType op_zero2(DisasContext *s, DisasOps *o) { o->out = tcg_const_i64(0); o->out2 = o->out; - o->g_out2 = true; return DISAS_NEXT; } @@ -5142,7 +5132,6 @@ static void prep_new_x(DisasContext *s, DisasOps *o) static void prep_r1(DisasContext *s, DisasOps *o) { o->out = regs[get_field(s, r1)]; - o->g_out = true; } #define SPEC_prep_r1 0 @@ -5151,7 +5140,6 @@ static void prep_r1_P(DisasContext *s, DisasOps *o) int r1 = get_field(s, r1); o->out = regs[r1]; o->out2 = regs[r1 + 1]; - o->g_out = o->g_out2 = true; } #define SPEC_prep_r1_P SPEC_r1_even @@ -5375,7 +5363,6 @@ static void in1_r1(DisasContext *s, DisasOps *o) static void in1_r1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1)]; - o->g_in1 = true; } #define SPEC_in1_r1_o 0 @@ -5409,7 +5396,6 @@ static void in1_r1p1(DisasContext *s, DisasOps *o) static void in1_r1p1_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r1) + 1]; - o->g_in1 = true; } #define SPEC_in1_r1p1_o SPEC_r1_even @@ -5464,7 +5450,6 @@ static void in1_r3(DisasContext *s, DisasOps *o) static void in1_r3_o(DisasContext *s, DisasOps *o) { o->in1 = regs[get_field(s, r3)]; - o->g_in1 = true; } #define SPEC_in1_r3_o 0 @@ -5595,7 +5580,6 @@ static void in1_m1_64(DisasContext *s, DisasOps *o) static void in2_r1_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r1)]; - o->g_in2 = true; } #define SPEC_in2_r1_o 0 @@ -5630,7 +5614,6 @@ static void in2_r2(DisasContext *s, DisasOps *o) static void in2_r2_o(DisasContext *s, DisasOps *o) { o->in2 = regs[get_field(s, r2)]; - o->g_in2 = true; } #define SPEC_in2_r2_o 0