From patchwork Wed Mar 1 02:56:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 657774 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp3270562wrb; Tue, 28 Feb 2023 19:01:48 -0800 (PST) X-Google-Smtp-Source: AK7set8UnmsFa+K0SusDkik0nkenkoI29ZrlcB/eaasFHhjiad+tOIetXCEm760E7rm7IZT2ixd6 X-Received: by 2002:ac8:5890:0:b0:3bd:11a5:c12b with SMTP id t16-20020ac85890000000b003bd11a5c12bmr8817355qta.5.1677639708248; Tue, 28 Feb 2023 19:01:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677639708; cv=none; d=google.com; s=arc-20160816; b=hIq2uztpzs6LYAU9eJCF0eHXWqwBbEz9YMsUD4/m+omgNqJ9nMMxZxXZKkxfcji1fZ Gmg45W4UyWtX++HuZ+Mfsu761ChDCiDYpQsgqUbGvKegWDBz+5msuyhanuVezCAJjqp6 rygL70MNeBFO4HBS+7PzdyQGjCnBlYXx3qJFYEGmTDV6/cu7/CLI3V6z4JbGWGm1M5cQ x1UoIjUouBNdwVMWsgpcneET214GQH8K0+rJS/6Jr6JI5T1MMXrw1UgJ4/k8kCBONtfT c/B+BpZxF/qFe0DOsKASvWT5Ym4MqDpr1kUWo87H/XeqL7t6XIzWqWNh89l/zuJakYNh 0ATQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vU83YYyrnZO9CSiEIwUngfuoHOOKNpuPtr+zuP2063w=; b=WHSRqHJFxBvXBVgfiJdyLq7nu5zZQONq0bRJBZj6am30diRqs6FS4BkM8H2ec0pWBn YIliiPy0oDKEZhK+QWF2jXY96tw28szXf8cHLk5snulCYxxRVBt9YLgPWYDHaE9VRQwN HJHvLcnWIrE+S0utxyPUQTPCjzVt6cWlYK3tHXpFSxjxxJVQd4I3h2zh/n/rkskj24Td Erhtrqob4q1fV60gk6+ntZaG0hC1UoVUgwSqOSta9pW8fzRF1+G2fu03Np9eTe6BkiIg OvDVhscJt+XIvNofrqYY8TWtCwwEnetrHJzE2GWf9YkTAaAACYot2En9uBpUZPi/D1CN Gvxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bgHU20Wt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v17-20020ac85791000000b003ba119a056fsi10661599qta.739.2023.02.28.19.01.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Feb 2023 19:01:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bgHU20Wt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXCij-0003f5-Qh; Tue, 28 Feb 2023 22:01:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXCib-0002YE-Dz for qemu-devel@nongnu.org; Tue, 28 Feb 2023 22:01:25 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXCiY-0004Ll-Bh for qemu-devel@nongnu.org; Tue, 28 Feb 2023 22:01:23 -0500 Received: by mail-pj1-x102c.google.com with SMTP id u3-20020a17090a450300b00239db6d7d47so4542913pjg.4 for ; Tue, 28 Feb 2023 19:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vU83YYyrnZO9CSiEIwUngfuoHOOKNpuPtr+zuP2063w=; b=bgHU20WtLwBU+H5L2fe7TAItEsZZQo3bT2api9oghFznY25S4q+hpCgslmJCOFJfrE kVSoBTnqAaLB+x9TvQMfmUpsCida2eDnfbDeR0plfdZKDCAry/H1q9nZ2qhZlTH4KpBj 18adwNFykSUwutSah9L+AQuRbkpX7zQKI/CdIJrtLo2OhFifCHPK0nMZDeo8V4qUqUL/ P2XBsWPtpbhWlchUZNfNfzoOKGVuXSff9dRjbyyagIZEeVAdN7uzo8m07V2P82gOkCkW KTS7KpatF+RKDcGTLdpei1rw1e8p2ijCHPaQoSQUJ2fLgtlxkCGidY/fv+NC+XiCwcdk F4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vU83YYyrnZO9CSiEIwUngfuoHOOKNpuPtr+zuP2063w=; b=wJ+KsW9LL2jUSgwrMFGqWt7dWUsw3aqjK5hNGKo/f2x3Vniye0IadNsrbh8+tvq7B1 06vBLYU0S9MjlCPIJ8cekNtlbpPK8VDoEA5iXUznIz4B3cp+cqbtbLMz2xAFh4t20G6T wB28kyhoTZgHV539kXvThAzMssSAY0QMfyV70q42OTv/xOGBy53e1jF8Tu4yDa0plv6X gFKTi6vs3jxVXPcOLinS0yUU2mU+9sBLx9flt6f/bVuU8FYdPCl/I9vqwA8yNXqGoAAT 78EwalTRxdO7+I5W13OptElSeav9/KTC6aQ8BACxE7VR25l7hHMLPPo7gmkm13DS2cSa aeMg== X-Gm-Message-State: AO0yUKVjk/8jz3+9VPLXS7b386gknEw8ZZuuolSCogtlGuX8zbhj3+7a UuqUYnLPsrCeR1m9Brch7McfRZPPwVNp3JvHTxE= X-Received: by 2002:a17:903:1207:b0:19c:bcb7:a3f4 with SMTP id l7-20020a170903120700b0019cbcb7a3f4mr5038261plh.54.1677639680817; Tue, 28 Feb 2023 19:01:20 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id r11-20020a170902be0b00b0019aca830869sm7181444pls.238.2023.02.28.19.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 19:01:20 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 56/62] target/i386: Don't use tcg_temp_local_new Date: Tue, 28 Feb 2023 16:56:37 -1000 Message-Id: <20230301025643.1227244-57-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230301025643.1227244-1-richard.henderson@linaro.org> References: <20230301025643.1227244-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since tcg_temp_new is now identical, use that. In some cases we can avoid a copy from A0 or T0. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index f88d0e3671..defbc43deb 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -3426,13 +3426,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod == 3) { goto illegal_op; } - a0 = tcg_temp_local_new(); - t0 = tcg_temp_local_new(); + a0 = s->A0; + t0 = s->T0; label1 = gen_new_label(); - tcg_gen_mov_tl(a0, s->A0); - tcg_gen_mov_tl(t0, s->T0); - gen_set_label(label1); t1 = tcg_temp_new(); t2 = tcg_temp_new(); @@ -3444,9 +3441,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_brcond_tl(TCG_COND_NE, t0, t2, label1); tcg_temp_free(t2); - tcg_temp_free(a0); tcg_gen_neg_tl(s->T0, t0); - tcg_temp_free(t0); } else { tcg_gen_neg_tl(s->T0, s->T0); if (mod != 3) { @@ -6248,13 +6243,13 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) #endif { TCGLabel *label1; - TCGv t0, t1, t2, a0; + TCGv t0, t1, t2; if (!PE(s) || VM86(s)) goto illegal_op; - t0 = tcg_temp_local_new(); - t1 = tcg_temp_local_new(); - t2 = tcg_temp_local_new(); + t0 = tcg_temp_new(); + t1 = tcg_temp_new(); + t2 = tcg_temp_new(); ot = MO_16; modrm = x86_ldub_code(env, s); reg = (modrm >> 3) & 7; @@ -6263,11 +6258,8 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod != 3) { gen_lea_modrm(env, s, modrm); gen_op_ld_v(s, ot, t0, s->A0); - a0 = tcg_temp_local_new(); - tcg_gen_mov_tl(a0, s->A0); } else { gen_op_mov_v_reg(s, ot, t0, rm); - a0 = NULL; } gen_op_mov_v_reg(s, ot, t1, reg); tcg_gen_andi_tl(s->tmp0, t0, 3); @@ -6280,8 +6272,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_movi_tl(t2, CC_Z); gen_set_label(label1); if (mod != 3) { - gen_op_st_v(s, ot, t0, a0); - tcg_temp_free(a0); + gen_op_st_v(s, ot, t0, s->A0); } else { gen_op_mov_reg_v(s, ot, rm, t0); } @@ -6304,7 +6295,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) modrm = x86_ldub_code(env, s); reg = ((modrm >> 3) & 7) | REX_R(s); gen_ldst_modrm(env, s, modrm, MO_16, OR_TMP0, 0); - t0 = tcg_temp_local_new(); + t0 = tcg_temp_new(); gen_update_cc_op(s); if (b == 0x102) { gen_helper_lar(t0, cpu_env, s->T0); @@ -7052,7 +7043,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu) dc->tmp2_i32 = tcg_temp_new_i32(); dc->tmp3_i32 = tcg_temp_new_i32(); dc->tmp4 = tcg_temp_new(); - dc->cc_srcT = tcg_temp_local_new(); + dc->cc_srcT = tcg_temp_new(); } static void i386_tr_tb_start(DisasContextBase *db, CPUState *cpu)