From patchwork Wed Mar 1 02:56:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 657772 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp3270498wrb; Tue, 28 Feb 2023 19:01:40 -0800 (PST) X-Google-Smtp-Source: AK7set/ZESHegdQVmVxrJW+qwwraXhMOTQDD/TLsBfhm/ZaSIgooh5tXFTAQWKkS3Ks5HMWr0jAG X-Received: by 2002:ad4:4eee:0:b0:56e:f9a2:1aff with SMTP id dv14-20020ad44eee000000b0056ef9a21affmr9626931qvb.35.1677639700454; Tue, 28 Feb 2023 19:01:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677639700; cv=none; d=google.com; s=arc-20160816; b=Z13mfEUZbdlw+I8dshvxTU1KUh101Nln03uKwm7E+bIvs+4Z+fypdtrhYh3zEnfOz4 eWccNJOjCSICdzdeEv8MKV5ARXziyxIQnailOzRAb7GWvddwsEQDNP6T2qhpxtFKKArI PsLcHEe2XiGMNM6f8edexFy/p60he+aEGqUH3AF/sW115QpYZHzC4uaZfgb06JRV+Ifg +pS4Wzo/MsyhM9D9841CzpdHopNz/HOQrlIXQZQBdppyAY4hhftSXXmXip/aOsDdRWWt sn8CHzzBvsuTUZYpUYZU3zrMualFZtFDqfAUQNNdPaPy/jSVs2BxaMOY+rZMrukDpVcI kdzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wgP/VlqDeygJvTan3lYcCGUlGsSNoYjFb+BGi032whY=; b=lMT6OVbRocSG5Nm7mKqfdFG5AdwJq7PO9MFx5GPqr/tXhYM+dN6K7OwFW1+J3utkLk m0SCADHQKZNzgf7DG0d3nHh+0XrspV0LPukwKH0fYBAflPNhOsuybgdk6surA4Wb43vb XVthuJoEOSJXOJBlNUeCN8g+rTgt5I5fe8Ig7VEwTWN67Jr/9nJs5r/4XBhG/g6uKDUA eSehClbF6mK/wStB1Ayy4IZygQqtahJgLDVxBag4Zc/ZKcTjmHWKrVvp4DTgz/foPJGw MT3wdkJ4MhZn6WLuSe8nOK6OtJl6HfKk5JPM72uaNU4LX1pJVpp1dBCeUzq/k6ARhIag chpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NZYSrR0+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r17-20020a05620a299100b006f9b019034bsi11064132qkp.259.2023.02.28.19.01.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Feb 2023 19:01:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NZYSrR0+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXCil-0003j6-Ms; Tue, 28 Feb 2023 22:01:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXCib-0002Y0-EJ for qemu-devel@nongnu.org; Tue, 28 Feb 2023 22:01:25 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXCiO-0004Jn-Cs for qemu-devel@nongnu.org; Tue, 28 Feb 2023 22:01:13 -0500 Received: by mail-pj1-x102a.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so47965pjn.1 for ; Tue, 28 Feb 2023 19:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wgP/VlqDeygJvTan3lYcCGUlGsSNoYjFb+BGi032whY=; b=NZYSrR0++HnlOriFb/fTFrSn1xs8a23uCIA7JH8RTIQrOtboLQSaD3KMolrlBxL3+1 DUl7QyUruCydXFMQUqwJlLxnU/C4Qbjq0U9p9u42nwsey3Wnu3ZA8B01hTv5c+3W5CAm gV0DlEEd85N3dsKQnNAVxn5LJTtQ+i9XS8sjXCePt5sn6A5AxigVI7YLpqqgxrhewIMJ IW+jM9dKx3klF2OJLXrSYVV7Yq5WRHmI+wz7fGeJMF1pzspYXLojbVigB/+8TrBfoObc HAX58m+wSp8CS7TzBLgYkZWfliii27JvA38DNUG8AIAslLw0EBcdVR8URWbDrkNks9tj VtWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wgP/VlqDeygJvTan3lYcCGUlGsSNoYjFb+BGi032whY=; b=q40HmcMmExJPX8A+YmNcjQRh4xK6q7ehS3VZVnXCztqnztDn+7FSFePFJF/BYjSO00 KsmJSnIfrLUVjWWlyl/WuJAqsdgy6IjHD6DXP5pGG3RoOA9Y5U1hguPJ3cLl6YKwcR/u jFf2a7Ch+uxdkXc00sVtUxixUe22/8QaJxSdcq2bOOJ4BVIpjOTAwnwRax4MkCSo84YU Dg4ScH5csQiUZdIprOa8lKxMmfjKYrOJrlH86uw0l5PKCPxnOj515yZMMB74n9+EniNG ZKYfTuxdshWFiIFGBU+KlA8qZIGrHpLMv072THmxfCqCkfpJmVrRHN7IEp9h5WNVj0Vw Z+1A== X-Gm-Message-State: AO0yUKUv2RIgv879TuWCzPLfi57uaDn60EVH4D9yArRNsYtzVlvcIH7X 6rHDpJoJHBBnqgx4x27MdTWqZgF+f4MKRysJbc8= X-Received: by 2002:a17:902:db0f:b0:19c:edcd:26cf with SMTP id m15-20020a170902db0f00b0019cedcd26cfmr6052110plx.61.1677639671053; Tue, 28 Feb 2023 19:01:11 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id r11-20020a170902be0b00b0019aca830869sm7181444pls.238.2023.02.28.19.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 19:01:10 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PULL 50/62] target/arm: Drop copies in gen_sve_{ldr,str} Date: Tue, 28 Feb 2023 16:56:31 -1000 Message-Id: <20230301025643.1227244-51-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230301025643.1227244-1-richard.henderson@linaro.org> References: <20230301025643.1227244-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since we now get TEMP_TB temporaries by default, we no longer need to make copies across these loops. These were the only uses of new_tmp_a64_local(), so remove that as well. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.h | 1 - target/arm/tcg/translate-a64.c | 6 ------ target/arm/tcg/translate-sve.c | 32 -------------------------------- 3 files changed, 39 deletions(-) diff --git a/target/arm/tcg/translate-a64.h b/target/arm/tcg/translate-a64.h index ad3762d1ac..ca24c39dbe 100644 --- a/target/arm/tcg/translate-a64.h +++ b/target/arm/tcg/translate-a64.h @@ -19,7 +19,6 @@ #define TARGET_ARM_TRANSLATE_A64_H TCGv_i64 new_tmp_a64(DisasContext *s); -TCGv_i64 new_tmp_a64_local(DisasContext *s); TCGv_i64 new_tmp_a64_zero(DisasContext *s); TCGv_i64 cpu_reg(DisasContext *s, int reg); TCGv_i64 cpu_reg_sp(DisasContext *s, int reg); diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 7bbffdd1fe..f092aec801 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -436,12 +436,6 @@ TCGv_i64 new_tmp_a64(DisasContext *s) return s->tmp_a64[s->tmp_a64_count++] = tcg_temp_new_i64(); } -TCGv_i64 new_tmp_a64_local(DisasContext *s) -{ - assert(s->tmp_a64_count < TMP_A64_MAX); - return s->tmp_a64[s->tmp_a64_count++] = tcg_temp_local_new_i64(); -} - TCGv_i64 new_tmp_a64_zero(DisasContext *s) { TCGv_i64 t = new_tmp_a64(s); diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 621a2abb22..02150d93e8 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -4344,17 +4344,6 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int vofs, TCGLabel *loop = gen_new_label(); TCGv_ptr tp, i = tcg_const_local_ptr(0); - /* Copy the clean address into a local temp, live across the loop. */ - t0 = clean_addr; - clean_addr = new_tmp_a64_local(s); - tcg_gen_mov_i64(clean_addr, t0); - - if (base != cpu_env) { - TCGv_ptr b = tcg_temp_local_new_ptr(); - tcg_gen_mov_ptr(b, base); - base = b; - } - gen_set_label(loop); t0 = tcg_temp_new_i64(); @@ -4370,11 +4359,6 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int vofs, tcg_gen_brcondi_ptr(TCG_COND_LTU, i, len_align, loop); tcg_temp_free_ptr(i); - - if (base != cpu_env) { - tcg_temp_free_ptr(base); - assert(len_remain == 0); - } } /* @@ -4445,17 +4429,6 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs, TCGLabel *loop = gen_new_label(); TCGv_ptr tp, i = tcg_const_local_ptr(0); - /* Copy the clean address into a local temp, live across the loop. */ - t0 = clean_addr; - clean_addr = new_tmp_a64_local(s); - tcg_gen_mov_i64(clean_addr, t0); - - if (base != cpu_env) { - TCGv_ptr b = tcg_temp_local_new_ptr(); - tcg_gen_mov_ptr(b, base); - base = b; - } - gen_set_label(loop); t0 = tcg_temp_new_i64(); @@ -4471,11 +4444,6 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs, tcg_gen_brcondi_ptr(TCG_COND_LTU, i, len_align, loop); tcg_temp_free_ptr(i); - - if (base != cpu_env) { - tcg_temp_free_ptr(base); - assert(len_remain == 0); - } } /* Predicate register stores can be any multiple of 2. */