From patchwork Mon Feb 27 14:00:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 657081 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2381166wrb; Mon, 27 Feb 2023 06:28:29 -0800 (PST) X-Google-Smtp-Source: AK7set+i9vfP2Gznwf1GjGOcl75p97FYA75+4/D+zdBkfZCQ3lYa3duQGHL7eErktH3quI4zHy1Q X-Received: by 2002:a05:622a:18a6:b0:3bf:a7c1:46a9 with SMTP id v38-20020a05622a18a600b003bfa7c146a9mr37953740qtc.40.1677508109041; Mon, 27 Feb 2023 06:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677508109; cv=none; d=google.com; s=arc-20160816; b=SPm9a094nzZtiFV9CttpbvK22Hhc3dTXroKWDoe8nQh0zgGosxCtWq3cu+QpZ3Ejfc MV2QJoYF27MMJlMa2KkV7wx6LblBB1pHXLkjxhXkgkTrs26qu2TNOe/QuExmvT0vkzAY rpYfsvDbpHk60phH3kBpH1/DxtGEl8E53OTN6mJfHOdRWJNfLuadbj/plNZ00o3/zIrO lUUV2m9rG49RUtcJZzuRx/72t0bsvHTdBkz1BXSzM6PG/ebDku7tE9T+W04ATjKyIPV7 sLOzlNUhJaTR23XIzqCWPXUDYn4KAaLbgUaNUhI/XdyK9q8FeSvgn8BLD7wGx3yYO95J cJFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=hsqxNNnhQ7gTxIdnokXihLeuCOxh7TyQaqkWOyOK8ME=; b=AgxkvctczNLuhm4V3CFa0sJze5us6/RgsQMNtxRzybo85SGtjY/i2K22cJO8bkOCxW pldlYteSuljKocZXF82FcDciRGv6Ndq6ZJMu7iYawQWHFPEo8/wFd+iRz5EVG8szTxLR zpFfkrWbjB+0uIsxsiEa30fjs9QS1qGW3F5v4zQ738kT5pjns7WdttrY8jZC4/WOAKg6 JUWviXHmLPHwL8wZCaO2pmNGyuGk7xOzM423QcT2mQU9bziID89/qCtbjpOeOedLMCsA rpQypir3kWOATfcxuRDmdMVUUtFbRlkm1dYm0KjHkVYDNXdE8nNk4qehoW2rP2Ig0Aet //rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sysjHBe1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a5-20020ac85b85000000b003b68b54bf83si6531929qta.446.2023.02.27.06.28.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Feb 2023 06:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=sysjHBe1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWe84-0004Ls-Rl; Mon, 27 Feb 2023 09:05:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWe7y-0004Eu-AZ for qemu-devel@nongnu.org; Mon, 27 Feb 2023 09:05:19 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWe7w-0008FX-Ma for qemu-devel@nongnu.org; Mon, 27 Feb 2023 09:05:18 -0500 Received: by mail-wr1-x435.google.com with SMTP id j2so6330434wrh.9 for ; Mon, 27 Feb 2023 06:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hsqxNNnhQ7gTxIdnokXihLeuCOxh7TyQaqkWOyOK8ME=; b=sysjHBe10hz+V51SritdZTcs1CRGP9d/nPK4pl09u+eHDG3ijBjlZd2EiBE47fXGqI lmSmWucTLJpSxplEkYEKyISxyW/7TerUNVw0yNSj/ebNownzUkb1Om+OjRo7W9UHIyd6 JPU0udsPVgT7Sf1fAVGD250FUqh4G13U4FFHiBtQu3b+a9/kicALM4ZbdeWfQ6YhtRwh 5p1hrjkxKgS1XfCXW7ASwdN3oqp0jtnDXqUASCgqxT63IUDhGZSaFR5zUZ7YwiPtldhJ FBw0oLTN9n2saa4Fuqz+VblVM0mpXs0oloy9NgG8fFL80LDNdS8ZAh+TWFbBMDJ9FEak P/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hsqxNNnhQ7gTxIdnokXihLeuCOxh7TyQaqkWOyOK8ME=; b=C4KhNFEn3bNpCsmnuAcLd6zWucTh3gdht8P2fichxmxAYFtyH24J6CfZuHb/6ILLCA LjXTA9xGJJKVfq7Vg50VkJIHFzkGXWkPG7i1a3no9g/wPBy2eF2mM/5nSSV9aI5IDbgS WmIvC5mSC53oTxqDPxtmWoCzLP1hbGZbpakdOEQt3wY8iB8l4Z2p0dWCEtuTM2+5pij7 oHldC4nHhphhxFr8Hz6CO7h8l8FLbqq38TgIpQ+C+5U8AK/Q8M45ZhaH5wyFN7uxLQlK 2x8t2ocyebdYulz9/9psShBqlwCQBmt0t8seiJ2EQ/IF3kdBFHQoQCymzuJ6UZdfALEL VSCA== X-Gm-Message-State: AO0yUKUCXYxLEEU1xTVwEil5J/vGKxq/QStdG8V1Jmb2Q7x2mfeGL3C2 VMKz2wRSLAvRcWp4nobbCQbYh9y06UQByUTN X-Received: by 2002:adf:ec03:0:b0:2c9:850c:6b15 with SMTP id x3-20020adfec03000000b002c9850c6b15mr6041808wrn.41.1677506715237; Mon, 27 Feb 2023 06:05:15 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id n31-20020a05600c3b9f00b003e8dcc67bdesm14299032wms.30.2023.02.27.06.05.14 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Feb 2023 06:05:14 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 043/126] hw/i2c/smbus_ich9: Move ich9_smb_set_irq() in front of ich9_smbus_realize() Date: Mon, 27 Feb 2023 15:00:50 +0100 Message-Id: <20230227140213.35084-34-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230227140213.35084-1-philmd@linaro.org> References: <20230227140213.35084-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Bernhard Beschow This is a preparation for the next commit to make it cleaner. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230213173033.98762-5-shentey@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_ich9.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index 52ba77f3fc..d29c0f6ffa 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -80,6 +80,18 @@ static void ich9_smbus_write_config(PCIDevice *d, uint32_t address, } } +static void ich9_smb_set_irq(PMSMBus *pmsmb, bool enabled) +{ + ICH9SMBState *s = pmsmb->opaque; + + if (enabled == s->irq_enabled) { + return; + } + + s->irq_enabled = enabled; + pci_set_irq(&s->dev, enabled); +} + static void ich9_smbus_realize(PCIDevice *d, Error **errp) { ICH9SMBState *s = ICH9_SMB_DEVICE(d); @@ -125,18 +137,6 @@ static void ich9_smb_class_init(ObjectClass *klass, void *data) adevc->build_dev_aml = build_ich9_smb_aml; } -static void ich9_smb_set_irq(PMSMBus *pmsmb, bool enabled) -{ - ICH9SMBState *s = pmsmb->opaque; - - if (enabled == s->irq_enabled) { - return; - } - - s->irq_enabled = enabled; - pci_set_irq(&s->dev, enabled); -} - I2CBus *ich9_smb_init(PCIBus *bus, int devfn, uint32_t smb_io_base) { PCIDevice *d =