From patchwork Mon Feb 27 05:42:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656929 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2231519wrb; Mon, 27 Feb 2023 00:24:26 -0800 (PST) X-Google-Smtp-Source: AK7set9i9i+VAaXmAfzbCqny3Z1X1QRRrqjUEbXLsHRaDYCgPvoA7keU7xVvtvxvXh8ba/dW3Nta X-Received: by 2002:ac8:5c0c:0:b0:3b6:2f3f:2713 with SMTP id i12-20020ac85c0c000000b003b62f3f2713mr42582331qti.25.1677486266287; Mon, 27 Feb 2023 00:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677486266; cv=none; d=google.com; s=arc-20160816; b=B4oyi5Bf3//GioFMGJYJ9U/2eMKHBu1wsdmHYzVBjH0PktczWIV8pc4yqfw4j5a0gJ wWrj6fWhm26XmilfxuLxczRGLBlfwPtMYo6fL5tHWtjccHNDwUY+j82LigK9v5OF3wWR HX/cR1C7VYk9ZKJvUwDizZ0nLHldBGGWnfTeBHGE+E6gBFgUXq5acqOWnRbsHBbNpXZ6 k34A/+xTO5jQJkZ1qnflM48RL0+HZq2T7C92OPZ4b7rDkbuGMy/LqSmEcXHncv/WBTa7 8ZWcFI5lZEkYp0SeywzrCktA2Y7Dq3dW2dKKiFNFOkjgPxGlxj4+kbLBbSEqYlL/Bium oiyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YPI3gM35f9kqtK6SwX2bfmUKEAAhOjVzMIqtanR4H+c=; b=qMlfhczcCpbd7dtbdExGxkeav3EOIAIwviLH2MuFbhh2mtUyiSZpixUy7GyNnXYIx7 xtHcPlWzQRocO1yh16i/H4jHaqYuxHkv+sb/nP0gIEuxjLtMyNsc9lgIx/GFoq0BN3t5 ipS+X/AAZwkUEHTWmx6Tbxtao74zJlkT/zRfJZrNfZl9L6ydez/qK0L/EaB1throgoWg hdXxWyH53QVkOKZUS8DJVsfE052/ARkuMa2Y2o+1KW+aaBEAC5MoVTiKQu96yc3crfoY CZmFbHFyaLa4kj8eQicjHkOahWDDFC11hrCtABDkwxBok1WGRHZ82B2c5xsQmzA8NAxq rPnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wqCQ2XqR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d2-20020a05622a100200b003ba2a171913si5906650qte.578.2023.02.27.00.24.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Feb 2023 00:24:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wqCQ2XqR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWWMl-0001Nv-Bq; Mon, 27 Feb 2023 00:48:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWWMW-00087B-Lc for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:47:49 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWWMP-00074i-RB for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:47:47 -0500 Received: by mail-pl1-x630.google.com with SMTP id y11so1419682plg.1 for ; Sun, 26 Feb 2023 21:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YPI3gM35f9kqtK6SwX2bfmUKEAAhOjVzMIqtanR4H+c=; b=wqCQ2XqRqzMwN4CQ1dMPlJbwaxJMem8BYVNyRiptWNHYpZxnGZeVHhk43Xi4vzKBrI CUpIExMkypOscQNrlsDv090uQq0bnoJjvnBXcJ1KF43910HLsXYnN+vvdaRHOxlK58Vc rlRyFHxYDH7UXsLf0t3TqLyfX1HnowEAljpUYrqY5NRJudz3SrBK5YAzo6L8ZraZFzTd YioOkzvnQotfLB7lh4GOfujgB9BanYK5Dgve/G7GIJU+PpEmsrIRU3IsoNzZ4sw1j7Tl Nx1kQDJiaSCKUDlbQ2xossFWsnn8RnXdY7qFOMUO1qWedArYZes1DZjV6IcqJT6XIFJy U0pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YPI3gM35f9kqtK6SwX2bfmUKEAAhOjVzMIqtanR4H+c=; b=sYiYb7mazbWWbUO3YaAaHEKijTgcil3G402io50F5IT9f8uyuN41tsmxLHEjo1ktRo YaHVavd+RM+Zm1jhz2fh9DFZVJY5ZBnbUedePJj8uihd9hehLgeoDwq+Sa0KfZYz17km Kz0UBGFcUlL1NkSQiECVE/peHkQ4Va1ml5+EreKrweWBOad2E97LkXLOHnklwyD8j8Ru r+d8Imjnau9b1QJ3oKIBH86+ka5aaqIEquGn8ty9FV1ViS7m33AZQ9erFqOZsxBaxT4l acyJnvbP8mdbYRDvWI288Y0MbRFn7yGj026Smhz6TrTH3OchzEqxTNkImAz9MWlEW43a zfxg== X-Gm-Message-State: AO0yUKWpS1clX5ZwLTV+hUXYTqSk/hYlSvF0Sjpq771W11jde9RsGmbv fJFDpk7KF/gNFxPVOYK3M67RGYIoRBeHOzgVWP0= X-Received: by 2002:a17:903:2903:b0:19d:2542:96b7 with SMTP id lh3-20020a170903290300b0019d254296b7mr339748plb.39.1677476858650; Sun, 26 Feb 2023 21:47:38 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id im16-20020a170902bb1000b0019a983f0119sm3553986plb.307.2023.02.26.21.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 21:47:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com Subject: [PATCH 43/70] target/ppc: Fix gen_tlbsx_booke206 Date: Sun, 26 Feb 2023 19:42:06 -1000 Message-Id: <20230227054233.390271-44-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227054233.390271-1-richard.henderson@linaro.org> References: <20230227054233.390271-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Fix incorrect read from rD. Avoid adding 0 when rA == 0. Signed-off-by: Richard Henderson --- target/ppc/translate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f74f3b8f0d..52b812a01f 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -5867,12 +5867,10 @@ static void gen_tlbsx_booke206(DisasContext *ctx) CHK_SV(ctx); if (rA(ctx->opcode)) { t0 = tcg_temp_new(); - tcg_gen_mov_tl(t0, cpu_gpr[rD(ctx->opcode)]); + tcg_gen_add_tl(t0, cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); } else { - t0 = tcg_const_tl(0); + t0 = cpu_gpr[rB(ctx->opcode)]; } - - tcg_gen_add_tl(t0, t0, cpu_gpr[rB(ctx->opcode)]); gen_helper_booke206_tlbsx(cpu_env, t0); #endif /* defined(CONFIG_USER_ONLY) */ }