From patchwork Mon Feb 27 05:36:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656809 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2181988wrb; Sun, 26 Feb 2023 21:41:13 -0800 (PST) X-Google-Smtp-Source: AK7set+M8aLtKtDQRt9+pFNCkHZN1nL9JK6xImnJPOdRLVQAg3IaQ8s5QtugHomGjjlHF7RfFUBO X-Received: by 2002:a05:6214:76b:b0:56e:952b:7141 with SMTP id f11-20020a056214076b00b0056e952b7141mr13962627qvz.7.1677476473509; Sun, 26 Feb 2023 21:41:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677476473; cv=none; d=google.com; s=arc-20160816; b=x0E+vjeSQer/hAOEy527GckdQ6PQe7WN7mw05T6lyqdUYenpiiq3ATtTBSDq2eooGg a5JlmqlWvsgShctoSWZy9Nne62sd0DGGNkvFQ+wIK8ib83wpCiXgmA+rPXL+pz1TMCqz hNNQItJOXDssZi3O8YVSnNpT5A2KmtNJhnNbRZGLfslO939Ie8O0wYQPlHWmCLWx2RUo GQDb44UkCjzf0st31HxCNhZh2kDf0nyUPFt2sJT4+4suqB+Gp2Q9Kjh2wS6OCBMOnb80 iRxbUP/7QQNXHoH0uIb2HrZBvNGKWIXsryQ54N0Zcf28EgQ77vC/HfZU16c4frIZR7Js 8tKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=HtdHdHMK9qtV0EQhNVy5cXGgK4x8v+Bxf5N4YTC08YTp/XyIl/TC5y4P5dgs2guT9T RhXpk67+tZVaIxjAM4eLhFYKiGbjaFgOsEFT1Bw7M/13RsS2BvZ7fqBXhnalkInvzFt+ NnEoHvC6v6PsheKjqizKIA9bOl2IT+Fp/BF/euyswI+kB9Eh9tzlSZuRjwaAbx1NsQo/ 9oRzdls0YzjXmw7uuFXW3sDTdxPzaR85zP7sSqw7TCNTuChT/Af2JHFVRod7AUUQ7X6J 6ZDj/XntlAcyaRImfRokk3GeGXFlUvWQxq9qx0prK2ofoC1ki/mPD92/z/SVHvE6iqiZ 5BdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jGR7UdKM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z18-20020a0c8f12000000b0056ea6cf0fc2si5265059qvd.352.2023.02.26.21.41.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Feb 2023 21:41:13 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jGR7UdKM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWWCY-0002gj-Ep; Mon, 27 Feb 2023 00:37:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWWCV-0002O8-Jz for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:37:27 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWWCS-0002YR-94 for qemu-devel@nongnu.org; Mon, 27 Feb 2023 00:37:27 -0500 Received: by mail-pj1-x102d.google.com with SMTP id x20-20020a17090a8a9400b00233ba727724so10693032pjn.1 for ; Sun, 26 Feb 2023 21:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=jGR7UdKMY/UbA5lgVk7nCTF7YagWYPZsq3IB/OyPg75G5Iks5qjF26nYjASzUTvW3Z HW9W3eNtoisAl3ao2DLpvh1QZ/O7lEyVbHoeZHeiE74oBxW69xV7zqvHjTiaGR2GlR2d M5j17PG0OZ2W/S4q92AoxxPunwUmozd3VL8LdKut0nmx+Tk0QXep1mLf0uAKHfMapa2d FOu8jiYFGAC3U7dO3UiJyL0mZS1SnLsTGzs9jkUwzxiQ6Yvk27WQ8ZwTwFIfvLZ5/WzR 8FUMYYXZzPEJeUV+XS1OXyB0Nt+3WVqHkOROj4WJXoN7px8HlZ3K1iXZLYBxvbwl1hBl aBPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=DAsU8pt8T2PJ4WbKwNcNPxAYICoN7W3I5fwYodKsxevQu5Vopks0EUOQFwXlS8ZHuw G7uDsuDNJY5gyQkyMfvO+iVlW9NubIrqb1vMRB1woQ2Vai1jAaETktiHczMvXwYYbbxx 0Rf1dGqLVIVGCNSM7X3ne+WAM+cI+sNoPaVSC2WNv21Z9dD1uBz5hVMsyo8gWc/C3wT5 6nShiZd/NRITy5bi7poayDI8xH8bn840eaS6DP2rO2JTq9IfgyGtm6P9wNdBczNmar4X R0LVdwd0APb0HFdpl/UdsNKWt8R46Eo7NI5DAlicYHCzqbQ8J3BDnN1cuZtfPK4YQTPW anNw== X-Gm-Message-State: AO0yUKULmHe0hJJngSWeRRU/ZsKflYQskFhh3CG73tVjLH5UvdwTT46V tVmntjwtKYTn7YzPAkY2epJg8Nt4VmCKy/BJMEA= X-Received: by 2002:a05:6a20:6a1d:b0:be:e0c3:5012 with SMTP id p29-20020a056a206a1d00b000bee0c35012mr7245340pzk.1.1677476242617; Sun, 26 Feb 2023 21:37:22 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id k12-20020aa792cc000000b005a7c892b435sm3342137pfa.25.2023.02.26.21.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 21:37:22 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v4 06/31] tcg: Use noinline for major tcg_gen_code subroutines Date: Sun, 26 Feb 2023 19:36:36 -1000 Message-Id: <20230227053701.368744-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230227053701.368744-1-richard.henderson@linaro.org> References: <20230227053701.368744-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This makes it easier to assign blame with perf. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index bf2af8b0fe..7ee935701a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2636,7 +2636,8 @@ TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *old_op, } /* Reachable analysis : remove unreachable code. */ -static void reachable_code_pass(TCGContext *s) +static void __attribute__((noinline)) +reachable_code_pass(TCGContext *s) { TCGOp *op, *op_next, *op_prev; bool dead = false; @@ -2860,7 +2861,8 @@ static void la_cross_call(TCGContext *s, int nt) /* Liveness analysis : update the opc_arg_life array to tell if a given input arguments is dead. Instructions updating dead temporaries are removed. */ -static void liveness_pass_1(TCGContext *s) +static void __attribute__((noinline)) +liveness_pass_1(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps = s->nb_temps; @@ -3200,7 +3202,8 @@ static void liveness_pass_1(TCGContext *s) } /* Liveness analysis: Convert indirect regs to direct temporaries. */ -static bool liveness_pass_2(TCGContext *s) +static bool __attribute__((noinline)) +liveness_pass_2(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps, i;