Message ID | 20230225091427.1817156-77-richard.henderson@linaro.org |
---|---|
State | Superseded |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1358348wrb; Sat, 25 Feb 2023 01:23:51 -0800 (PST) X-Google-Smtp-Source: AK7set8WDBMPtbXs4tAnivQV7XOq4B0vXf+i4LVAOd2kYJQZxsMPcQgbcYXbt070cnNa+E4PNqV9 X-Received: by 2002:a05:622a:190e:b0:3bd:19b1:ccc with SMTP id w14-20020a05622a190e00b003bd19b10cccmr22872198qtc.33.1677317031718; Sat, 25 Feb 2023 01:23:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677317031; cv=none; d=google.com; s=arc-20160816; b=X86tgEXm0WPHnkuE1M50bCFedHLjeFlkvR2Zzkv1Fr0xg7TLr17CxiJ3/en3Kr7SCs ewREipa/OcK2DgWQRIHe90qM4U5tW2FP+GHtnAdAAYM3EYnH5L2MRV0+MXbnlUB+L2TW Opp3vUs/blOcFFAW3VCcnfHwHiZVj4otIhzhBpS9tCzRM20zwwSXHuUKVvD5fq6sMU/4 Uyjo1s1zKs4p6X6pkb1T9gQEjkMGNomP3iIn2xitVoOZ/8dMOdlvBZNF0jGzgn7u3rdF 7el8tBiTs1E1UlyQDYQybzLxh9uUKG10laA4Cjkb54xViQwApl4EcRPzaqNfQlhzHFdO agIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gBIK42bUcbYw07ufb58LbL1DVkfWS6Zfg0rOY806rL4=; b=lb6TZ0FkcJKi+P5OV6eQ9K2mzFmsGG3FG+QeqrxQSeWf4M9AO3rD9OcCdyV/FEihoz NfzsTx8XtlJUGa0rsuXTn5e/P0ocmS72dCMBfaQ9q1qIk/CC2ck2rVGfTS6/6IyZI59c IwwPGsqGoDvQrjgFP20FZggBfX8VvAVcqlWnsFspqdoArtlcGlNd1lUU70SFfWrIKAmF XSfiLdLi+iHzVrtFvb+USEiYh0ob5g5rJ2/6PnVaYqo+XhaBrd60MGqZyod38SjxyERV OLDtFTg6Nxeu4+k4PeTa3YMyfIHF6dugBzZIBd+c5vgzrqYqwnXWxzhLnYji006M7rID +1Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lcTOThPT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ay19-20020a05620a179300b00742703b0200si1376379qkb.349.2023.02.25.01.23.51 for <patch@linaro.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:23:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lcTOThPT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces@nongnu.org>) id 1pVqkP-0001gX-EC; Sat, 25 Feb 2023 04:21:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>) id 1pVqjf-00082k-Sl for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:20:55 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>) id 1pVqjb-0003sZ-MH for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:20:55 -0500 Received: by mail-pf1-x42f.google.com with SMTP id a7so833325pfx.10 for <qemu-devel@nongnu.org>; Sat, 25 Feb 2023 01:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gBIK42bUcbYw07ufb58LbL1DVkfWS6Zfg0rOY806rL4=; b=lcTOThPT/nK5u6u8s59JXGw4mqU/4nxsTBY0i2/GlYotooWtMHFLFyEA8MWmSuaiJB O/rzyZgQcU5rNi+ccqFudlEZY4HO+iuIOk+sph9icOgoPNm5RqmgzuN2yoXEUojnUbod 5v71EOi6nW7OG59ZKD9wpe9yNkjISbrUce6bUdIm8pOx9f+nUtwaQKM3s5qYqKHPyVKD r42nvZwGxhXefVbFlgu14PBDBs8l6LmN23caj+ZosnyNEI5CEGinfGsVMkKOPpSX4rQS /OhmbCUajjdjKGONBVic4i9cXB/Av3nT8/vF2YWY/SY/GqWpFJrNLMlk2oCXiMTZbyR4 tSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gBIK42bUcbYw07ufb58LbL1DVkfWS6Zfg0rOY806rL4=; b=rNQtx5XAkpma2g0pNrcXKFjV44uAwQ3I/W4QjiGFHPhG8SZX0L4SwblfCFP9IJcQhD osKZc98ij6FKX8HnUJMZgY2+bKFCR3yokwe3WJz+ouRZerhvYMOfQCiNjEv5c8a7nZH/ 6fvlYmY/klP6lv9MAxrJa4UPHYVb5VL50xwXQGb9ukD3DzTTTI90KK1RN8Zth4ylKMGx vItTVxYMUOuC3WOk+utgEIdHzF9KKhhVlPt1D9G90psPkI08hliB56XGHFzDHxhzT9tn nAlhFQoskZwOAuZ70DO4+kdXYVqM+a0Hlkn1XxxLUR+iAq943TSv0Xl8Iq/R3sLHV4GX S7KA== X-Gm-Message-State: AO0yUKUopwM0dEsec2hUtE2xI7M/P9SlZ200NiGRiRm1u7FzhM56u4vc 6gsz2YM2BlVJ0HAn2eq0uUoL5gMCA/edd9hR2+4= X-Received: by 2002:a62:1ad1:0:b0:5a8:bdae:caa7 with SMTP id a200-20020a621ad1000000b005a8bdaecaa7mr17178472pfa.14.1677316850312; Sat, 25 Feb 2023 01:20:50 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id 26-20020aa7921a000000b00592417157f2sm843114pfo.148.2023.02.25.01.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 01:20:49 -0800 (PST) From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com Subject: [PATCH 76/76] docs/devel/tcg-ops: Drop recommendation to free temps Date: Fri, 24 Feb 2023 23:14:27 -1000 Message-Id: <20230225091427.1817156-77-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230225091427.1817156-1-richard.henderson@linaro.org> References: <20230225091427.1817156-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org |
Series |
tcg: Drop tcg_temp_free from translators
|
expand
|
On 2/25/23 06:14, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > docs/devel/tcg-ops.rst | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/docs/devel/tcg-ops.rst b/docs/devel/tcg-ops.rst > index 561c416574..f3f451b77f 100644 > --- a/docs/devel/tcg-ops.rst > +++ b/docs/devel/tcg-ops.rst > @@ -951,10 +951,6 @@ Recommended coding rules for best performance > often modified, e.g. the integer registers and the condition > codes. TCG will be able to use host registers to store them. > > -- Free temporaries when they are no longer used (``tcg_temp_free``). > - Since ``tcg_const_x`` also creates a temporary, you should free it > - after it is used. > - > - Don't hesitate to use helpers for complicated or seldom used guest > instructions. There is little performance advantage in using TCG to > implement guest instructions taking more than about twenty TCG
diff --git a/docs/devel/tcg-ops.rst b/docs/devel/tcg-ops.rst index 561c416574..f3f451b77f 100644 --- a/docs/devel/tcg-ops.rst +++ b/docs/devel/tcg-ops.rst @@ -951,10 +951,6 @@ Recommended coding rules for best performance often modified, e.g. the integer registers and the condition codes. TCG will be able to use host registers to store them. -- Free temporaries when they are no longer used (``tcg_temp_free``). - Since ``tcg_const_x`` also creates a temporary, you should free it - after it is used. - - Don't hesitate to use helpers for complicated or seldom used guest instructions. There is little performance advantage in using TCG to implement guest instructions taking more than about twenty TCG
Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- docs/devel/tcg-ops.rst | 4 ---- 1 file changed, 4 deletions(-)