From patchwork Sat Feb 25 09:14:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656500 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1358337wrb; Sat, 25 Feb 2023 01:23:48 -0800 (PST) X-Google-Smtp-Source: AK7set/ERy+YF9cIyD4/LhG4x63zfFfncKLtzQrL8mEK14UetGKCfRxuykkKPCRaeEOPzs+ulcjt X-Received: by 2002:a05:622a:11c3:b0:3b9:2b0:5e7a with SMTP id n3-20020a05622a11c300b003b902b05e7amr31150802qtk.25.1677317028536; Sat, 25 Feb 2023 01:23:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677317028; cv=none; d=google.com; s=arc-20160816; b=Vc6Dz0sVwouceBdzT1068A+N6SLk60VwF8Jul37tKLN4GjDXi9wOLYWCc4xpDCkcbq Jb09ihlih2gQe2mzkyip5Ez6P+t09BBC9KAaz5V6V4ZouMTs2Bs+ZhWJyOlIWR9GjO0X RPhn+gkg4x9Vn0jbXUWNVF/nFCLfmCot4VnVpvleF78D/xf/USZ2vczsyAPYNb+8R3RV IvFu/vQjEsylRvwQ/PbkRSET2qFFyQe8Wpp32Z9iD/vM2oE0wg0n51yUrezxGSZl8ts+ AYTtuoGjHsCkV+1owlrFclh3qiS30mzmKfxq8XxoQy7N8WcF1wUYaXfpB2WRtWwVL9hp hwrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ynjwWGgj/GWnEPQQaPLH0AnCGUIHagoL6cGCq3NhAGI=; b=UG9a1ej5JED3+o2vEJ82WhOsjfL7C3GwCSLsQ+2suN41eyhUydyMETKz3EpdrCiMoI zsHPpHae7Q2BttDvDGm+Z8/H/VzdyZ4L4bWMqiHpLw4XXvDKAHfEAmlLepD5T8SxKDP9 PkoyLniYpM3MEEuDjBFUo8Jdz9pmpKsdVxWrKiCOmOlGHYoiRwqj4KwF2BLROak8lGrf qKhWp1B/mpyh/orHSLSqviUIuoXKdkAsOqP5fVY/Po8i93P5YBKf8rrRS4DhATGphGzu dOSZCLtIRR6Jz3j3hUJnYKxO/y10P3usN0xfnJo8+2cj2QNCHgo5I0We4F5TR4j9aOLM 8ICA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrDXayeb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y14-20020a05622a004e00b003bccff19a53si1688926qtw.686.2023.02.25.01.23.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:23:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KrDXayeb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVqk4-0000y1-6o; Sat, 25 Feb 2023 04:21:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVqjV-00071n-9N for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:20:45 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVqjQ-00038X-SP for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:20:44 -0500 Received: by mail-pg1-x531.google.com with SMTP id d10so902901pgt.12 for ; Sat, 25 Feb 2023 01:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ynjwWGgj/GWnEPQQaPLH0AnCGUIHagoL6cGCq3NhAGI=; b=KrDXayeb9vas0zc5uqAJyddUpBGhrFYNxF5dprxpTAOZaJ4Vm7hvlIoqESaneeEFq7 sD9k+zvhj2Ls4vrqCKYimKAdCC4QI2YNljYZ4z+ye1dRaSE9ayMXIk9Ll2DQzPVY/rDU AcNiUpzAA+9cV3ffVrTxh9eyaTBewNYz7CF2w1OlY686lFaeKqnq0GXLU3rucQTuKepJ lS+pMZTWbcjcfrwXKr7Lpsp1tzb7xfYK8fcWru8YkX0KPhYTvQ23cMmQ01k9MbzBpCa7 711equ4A1C5mr6t7zI6JY6CwFGXyyxduFREpsYAr1mASqE2ZJjGRu68z/B2z80uC8iND 7rTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ynjwWGgj/GWnEPQQaPLH0AnCGUIHagoL6cGCq3NhAGI=; b=KPw6z6eWtYHVvppH5WChlWbHsJIugT4kBJTsa0Co3LUohxG4vYxFBeASMrvP69O7rC 8RkBVg8uJNWWRj0wzGC1Dq/4Y+Rgu1OInpHXz99m194xovMBx4OvOAEtKhjAh6FrGzAl eIlZapYfRGM9yLTrzn1dCCi7sFSXenm6wSARXzjDxfqSYIZwLJYweRqycMRgcdduzpPL /Vo59mz2QVwdR5UqC0PE6ngqvR3BTIpMAsWDZx1gpsNRprgoa6nWgYLsJsCBIrExxhHo f77h0wMJTUpAJr5sRfGbou4/be9JUHr8oaSzXzmTzuJru13c9Kd49Qih9f0g9w2xEz5m OXbA== X-Gm-Message-State: AO0yUKWmfyxPRNARJZhwRH0KD0CbHo6/slf6at5VoqXBY9R9liJl7Hum WNyiri0kgN3dJcXqlzkmpEs3i215o0JU0r8g3H0= X-Received: by 2002:a62:6454:0:b0:5a9:c2b0:428f with SMTP id y81-20020a626454000000b005a9c2b0428fmr17724854pfb.31.1677316837811; Sat, 25 Feb 2023 01:20:37 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id 26-20020aa7921a000000b00592417157f2sm843114pfo.148.2023.02.25.01.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 01:20:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com Subject: [PATCH 71/76] target/sparc: Drop reset_sar_tracker Date: Fri, 24 Feb 2023 23:14:22 -1000 Message-Id: <20230225091427.1817156-72-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230225091427.1817156-1-richard.henderson@linaro.org> References: <20230225091427.1817156-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Translators are no longer required to free tcg temporaries. Remove sar_m32_allocated, as sar_m32 non-null is equivalent. Signed-off-by: Richard Henderson Reviewed-by: Max Filippov --- target/xtensa/translate.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 4af0650deb..910350dec6 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -57,7 +57,6 @@ struct DisasContext { bool sar_5bit; bool sar_m32_5bit; - bool sar_m32_allocated; TCGv_i32 sar_m32; unsigned window; @@ -284,14 +283,7 @@ static void init_sar_tracker(DisasContext *dc) { dc->sar_5bit = false; dc->sar_m32_5bit = false; - dc->sar_m32_allocated = false; -} - -static void reset_sar_tracker(DisasContext *dc) -{ - if (dc->sar_m32_allocated) { - tcg_temp_free(dc->sar_m32); - } + dc->sar_m32 = NULL; } static void gen_right_shift_sar(DisasContext *dc, TCGv_i32 sa) @@ -306,9 +298,8 @@ static void gen_right_shift_sar(DisasContext *dc, TCGv_i32 sa) static void gen_left_shift_sar(DisasContext *dc, TCGv_i32 sa) { - if (!dc->sar_m32_allocated) { + if (!dc->sar_m32) { dc->sar_m32 = tcg_temp_new_i32(); - dc->sar_m32_allocated = true; } tcg_gen_andi_i32(dc->sar_m32, sa, 0x1f); tcg_gen_sub_i32(cpu_SR[SAR], tcg_constant_i32(32), dc->sar_m32); @@ -1247,7 +1238,6 @@ static void xtensa_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) { DisasContext *dc = container_of(dcbase, DisasContext, base); - reset_sar_tracker(dc); if (dc->icount) { tcg_temp_free(dc->next_icount); }