diff mbox series

[45/76] target/mips: Fix trans_mult_acc return

Message ID	20230225091427.1817156-46-richard.henderson@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com Subject: [PATCH 45/76] target/mips: Fix trans_mult_acc return Date: Fri, 24 Feb 2023 23:13:56 -1000 Message-Id: <20230225091427.1817156-46-richard.henderson@linaro.org> In-Reply-To: <20230225091427.1817156-1-richard.henderson@linaro.org> References: <20230225091427.1817156-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org
Series	tcg: Drop tcg_temp_free from translators \| expand [00/76] tcg: Drop tcg_temp_free from translators [01/76] tcg: Remove tcg_check_temp_count, tcg_clear_temp_count [02/76] accel/tcg: Remove translator_loop_temp_check [03/76] target/alpha: Drop tcg_temp_free [04/76] target/arm: Remove arm_free_cc, a64_free_cc [05/76] target/arm: Remove value_global from DisasCompare [06/76] target/arm: Drop tcg_temp_free from translator.c [07/76] target/arm: Drop DisasContext.tmp_a64 [08/76] target/arm: Drop new_tmp_a64 [09/76] target/arm: Drop new_tmp_a64_zero [10/76] target/arm: Drop tcg_temp_free from translator-a64.c [11/76] target/arm: Drop tcg_temp_free from translator-m-nocp.c [12/76] target/arm: Drop tcg_temp_free from translator-mve.c [13/76] target/arm: Drop tcg_temp_free from translator-neon.c [14/76] target/arm: Drop tcg_temp_free from translator-sme.c [15/76] target/arm: Drop tcg_temp_free from translator-sve.c [16/76] target/arm: Drop tcg_temp_free from translator-vfp.c [17/76] target/arm: Drop tcg_temp_free from translator.h [18/76] target/avr: Drop DisasContext.free_skip_var0 [19/76] target/avr: Drop R from trans_COM [20/76] target/avr: Drop tcg_temp_free [21/76] target/cris: Drop cris_alu_free_temps [22/76] target/cris: Drop cris_alu_m_free_temps [23/76] target/cris: Drop addr from dec10_ind_move_m_pr [24/76] target/cris: Drop tcg_temp_free [25/76] target/cris: Drop tcg_temp_free from C code [26/76] target/cris: Drop tcg_temp_free from gen_tcg_funcs.py [27/76] target/hexagon/idef-parser: Drop tcg_temp_free [28/76] target/hexagon/idef-parser: Drop HexValue.is_manual [29/76] target/hppa: Drop tcg_temp_free [30/76] target/i386: Drop tcg_temp_free [31/76] target/loongarch: Drop temp_new [32/76] target/loongarch: Drop tcg_temp_free [33/76] target/m68k: Drop mark_to_release [34/76] target/m68k: Drop free_cond [35/76] target/m68k: Drop tcg_temp_free [36/76] target/microblaze: Drop tcg_temp_free [37/76] target/mips: Drop tcg_temp_free from micromips_translate.c.inc [38/76] target/mips: Drop tcg_temp_free from mips16e_translate.c.inc [39/76] target/mips: Drop tcg_temp_free from msa_translate.c [40/76] target/mips: Drop tcg_temp_free from mxu_translate.c [41/76] target/mips: Drop tcg_temp_free from nanomips_translate.c.inc [42/76] target/mips: Drop tcg_temp_free from octeon_translate.c [43/76] target/mips: Drop tcg_temp_free from translate_addr_const.c [44/76] target/mips: Drop tcg_temp_free from tx79_translate.c [45/76] target/mips: Fix trans_mult_acc return [46/76] target/mips: Drop tcg_temp_free from vr54xx_translate.c [47/76] target/mips: Drop tcg_temp_free from translate.c [48/76] target/nios2: Drop tcg_temp_free [49/76] target/openrisc: Drop tcg_temp_free [50/76] target/ppc: Drop tcg_temp_free [51/76] target/riscv: Drop ftemp_new [52/76] target/riscv: Drop temp_new [53/76] target/riscv: Drop tcg_temp_free [54/76] target/rx: Drop tcg_temp_free [55/76] target/s390x: Use tcg_constant_* in local contexts [56/76] target/s390x: Use tcg_constant_* for DisasCompare [57/76] target/s390x: Use tcg_constant_i32 for fpinst_extract_m34 [58/76] target/s390x: Use tcg_constant_* in translate_vx.c.inc [59/76] target/s390x: Drop free_compare [60/76] target/s390x: Drop tcg_temp_free from translate_vx.c.inc [61/76] target/s390x: Drop tcg_temp_free from translate.c [62/76] target/s390x: Remove assert vs g_in2 [63/76] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext [64/76] target/sh4: Drop tcg_temp_free [65/76] target/sparc: Drop get_temp_tl [66/76] target/sparc: Drop get_temp_i32 [67/76] target/sparc: Remove egress label in disas_sparc_context [68/76] target/sparc: Drop free_compare [69/76] target/sparc: Drop tcg_temp_free [70/76] target/tricore: Drop tcg_temp_free [71/76] target/sparc: Drop reset_sar_tracker [72/76] target/xtensa: Drop tcg_temp_free [73/76] include/exec/gen-icount: Drop tcg_temp_free in gen_tb_start [74/76] tracing: remove transform.py [75/76] tcg: Create tcg/tcg-temp-internal.h [76/76] docs/devel/tcg-ops: Drop recommendation to free temps

Commit Message

Richard Henderson Feb. 25, 2023, 9:13 a.m. UTC

Success from trans_* subroutines should be true.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/mips/tcg/vr54xx_translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Feb. 25, 2023, 7:47 p.m. UTC | #1

On 25/2/23 10:13, Richard Henderson wrote:
> Success from trans_* subroutines should be true.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/mips/tcg/vr54xx_translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/mips/tcg/vr54xx_translate.c b/target/mips/tcg/vr54xx_translate.c
> index 3e2c98f2c6..a7d241e4e7 100644
> --- a/target/mips/tcg/vr54xx_translate.c
> +++ b/target/mips/tcg/vr54xx_translate.c
> @@ -53,7 +53,7 @@ static bool trans_mult_acc(DisasContext *ctx, arg_r *a,
>       tcg_temp_free(t0);
>       tcg_temp_free(t1);
>   
> -    return false;
> +    return true;

Oops...

Fixes: 5fa38eedbd ("target/mips: Convert Vr54xx MACC* opcodes to 
decodetree")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Queued to mips-next, thanks!

diff mbox series

Patch

diff --git a/target/mips/tcg/vr54xx_translate.c b/target/mips/tcg/vr54xx_translate.c
index 3e2c98f2c6..a7d241e4e7 100644
--- a/target/mips/tcg/vr54xx_translate.c
+++ b/target/mips/tcg/vr54xx_translate.c
@@ -53,7 +53,7 @@  static bool trans_mult_acc(DisasContext *ctx, arg_r *a,
     tcg_temp_free(t0);
     tcg_temp_free(t1);
 
-    return false;
+    return true;
 }
 
 TRANS(MACC,     trans_mult_acc, gen_helper_macc);