From patchwork Sat Feb 25 08:59:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 656436 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1351398wrb; Sat, 25 Feb 2023 01:00:53 -0800 (PST) X-Google-Smtp-Source: AK7set/K/51g94W6jLHppwSqGL5i+H4YdilZSS+NqAun0Pt8Y7zw+iwFRek2zQRK2DruUfrimZm/ X-Received: by 2002:ac8:5f84:0:b0:3bc:fa90:e8b9 with SMTP id j4-20020ac85f84000000b003bcfa90e8b9mr32183810qta.20.1677315653320; Sat, 25 Feb 2023 01:00:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677315653; cv=none; d=google.com; s=arc-20160816; b=JdTfSLsGSQHHytoDQHxceW3UTtz5G16fkP63ZjZxb3CPaeOiGBfUdM9UJpMJOCVaxl hXMcxDOSFywW/VKaQhi4K56vWT8x1ENWfVM2Cf7ert2EZLBB5FoxW2NtRseG/VMm0su8 x+takiZTIb6obZ7sie+mn49Laj558G3tmu0GqCAUy0NC1YmclcGxP83aFEcY3yUi7Fkp QLE6dsJuOTnpxfsOd7SXLHEIo0mxubzAwZ/Iv6LVUrAATicZRWT9guT25E5nyW+vR41z ngvaOxPFg6Xx3/7NZKro/t5e4424udKDQUsm/OYyDQqaulMr2uAn0Dq/ky2/5K3DImt1 p5GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=Xl9WBbyL57R6bAQPI7pt1QRyBOKAagsoauFG1drzUKQ6owHVD9qqaX4XYIxZQYq4D/ IBTe5UknmCnkFDkU2WNMcOQtmFmHKENbnGmIKoN64LVjEhJp6smUjplZntH+vV75eSwJ mbEMsddocAakCKupyqd1tvtWPy7RNOuMa0VOcCgLUMiE+uPX1cycHO9owZewifu3ALiE 8kDb11qJJkmG/9gqDEr1IAkVdCu0EIwi48PCkV5TO4hzbf0CF5rgpjcb/HSWUdOv9fEr tQlG9gyBDFHWcMHSmWaLi5ri8A6AHYNmO7w3Z7yEABcBqlL4pWc8C/UrkltePb3GzoJE Zm1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GgoEsvJS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a5-20020ac85b85000000b003b630226888si1554610qta.551.2023.02.25.01.00.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2023 01:00:53 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GgoEsvJS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVqPT-0000Oy-QB; Sat, 25 Feb 2023 04:00:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVqPR-0000OS-M9 for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:01 -0500 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVqPQ-0004pk-4i for qemu-devel@nongnu.org; Sat, 25 Feb 2023 04:00:01 -0500 Received: by mail-pj1-x1033.google.com with SMTP id y2so1393718pjg.3 for ; Sat, 25 Feb 2023 00:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=GgoEsvJSMZTe9dbbA/yKWxjEYIhMIKA3wmJsrllL7XhwU9CFhdB4sIgIJJbkM3apOf Xg/uIbVp0IWqGGAFYYbRHx8NyF+bo4SVRzPfNESKd7jVoWwrwJCF2y/h2Bnb+kicnLNf tgzlvyx71scF33sjLKfsO8g9VFyQYwkO13LemgZnMN+d5ZyvDZFY3DgHXyLAFTZjGkea 6VEk14ESqmZpZSFcLC0xPRJP80e2RkyE3+najUyDrsoefnRkMfxJ/920aAb7UHwBu3Om ZOFzWtPZmNSB/DpyMxIDfSvITIjQACi57K76qdmdQwXDig8Gb9TLSXgNhpreXsE4asv2 xp8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XU8chpWpCvoR0LbgkNVM0m0xLd7d7yoa5DmO6k+5Uys=; b=x2M45POPT5qHvFDXP7IE084Qsvlwq1xyKBqYPkadmYmTXHNjKa127i2L14h2D6xQlZ Eyn60/ZlbhT4L8L4ay6z7NLIvixSgJYoCuPkBLjsaZjI6tgV+eakMd6a0F+iX19jIBs5 zzG0xO/dxXoq9izCMhZ3DDtn70LRCzijIoQS1+ZEbY1XkTzPWhyRe+Z6ajWlWoZzknCm RVNPxX7tgYTJPGoQaqfC05SHiYep5XE0oDM4n1CgmGK9vfCeknb4iUoBMyeknnzQj1nE y435lED41KGW0JL3JTtp0Udx+Ugd+Y1AqmizlyDl0s3ACzp2Vh7BYkonXlBVdt6mSbAu 8Pzw== X-Gm-Message-State: AO0yUKUwJJoDGd8zVkhbLix6Dw1TN+xo7+iLR9B/FRL+hOU2fSoKuev4 wzzCR3D3rpwjW1x6XEKFtN+sq9pygGctCBiosLE= X-Received: by 2002:a05:6a20:3ca6:b0:cc:8e18:420f with SMTP id b38-20020a056a203ca600b000cc8e18420fmr4495554pzj.35.1677315598614; Sat, 25 Feb 2023 00:59:58 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s17-20020a639251000000b00502ecb91940sm715546pgn.55.2023.02.25.00.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 00:59:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 06/30] tcg: Use noinline for major tcg_gen_code subroutines Date: Fri, 24 Feb 2023 22:59:21 -1000 Message-Id: <20230225085945.1798188-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230225085945.1798188-1-richard.henderson@linaro.org> References: <20230225085945.1798188-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This makes it easier to assign blame with perf. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index bf2af8b0fe..7ee935701a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2636,7 +2636,8 @@ TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *old_op, } /* Reachable analysis : remove unreachable code. */ -static void reachable_code_pass(TCGContext *s) +static void __attribute__((noinline)) +reachable_code_pass(TCGContext *s) { TCGOp *op, *op_next, *op_prev; bool dead = false; @@ -2860,7 +2861,8 @@ static void la_cross_call(TCGContext *s, int nt) /* Liveness analysis : update the opc_arg_life array to tell if a given input arguments is dead. Instructions updating dead temporaries are removed. */ -static void liveness_pass_1(TCGContext *s) +static void __attribute__((noinline)) +liveness_pass_1(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps = s->nb_temps; @@ -3200,7 +3202,8 @@ static void liveness_pass_1(TCGContext *s) } /* Liveness analysis: Convert indirect regs to direct temporaries. */ -static bool liveness_pass_2(TCGContext *s) +static bool __attribute__((noinline)) +liveness_pass_2(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps, i;